From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 757C148333 for ; Tue, 25 Jun 2024 18:16:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 169CF68D63B; Tue, 25 Jun 2024 21:16:55 +0300 (EEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B386268D412 for ; Tue, 25 Jun 2024 21:16:48 +0300 (EEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-70671ecd334so2454065b3a.0 for ; Tue, 25 Jun 2024 11:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719339406; x=1719944206; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=hYO6yUEWx30r2JbWQS8II7+lvlPyyO51T08/2s2Yw30=; b=hT8aTv7BexXXtotHU6beo5hiAKnIe2VlujVEMNqHbDhuZ6llvrsyUM84wr+oY8v6AD j87hYub66CXuRjTqKHdvxxibyZIiYEGcadqT79iK8YmcoTvvYAmAcKwb6JZNOtkWowbv MGBB5G6+qSIxYHoX//+R1STB1X/Uiqm+h0fvWBpTjofUl1hO9sJMSRdgUxrm5e3ZMbad xfcx33HrKtWrkv2iB1SrYnXPBF2hN+pYzvrGP+ogNfLws9U4zx6Y7PglmlTWiNpa7IEf YI/wEy7OUMtJuh/L2jDK+74tweev92EhptNDtYWLjwTSnn+bBd/j85NLTEJXO9hE303W P1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719339406; x=1719944206; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hYO6yUEWx30r2JbWQS8II7+lvlPyyO51T08/2s2Yw30=; b=nt4TyCm8lrXnvGRKg6MS/4RNB3jequoOCD2/4N19YtxVZRr2DotQG8+xqrB5QYbaoH f3cz9C9x+bB6g8uWUvPumhMi/8oumIKRtjg70jK0PA2aqviDIVTFnFzPzoVbLlS966WR RN6YyQLLKztsOwBREQXpLjPrLW2Xgww12EO03/34YTiY5g0Z0txvg9pK+HzAvrDlgTbd w8IRHwe/z48CPxhf97m0L7/D1pQYqNPuOWWSQpTv9bA7Yq/ohLScDeC99xmGRBgQLDbP 2vjJ85ivsis/6oQpYCauOiAlP610jq1wLDoXwxAmgF+2Hks4WaZvS7wqpVzhuGSy97Gh IW0A== X-Gm-Message-State: AOJu0Yz9qTPWmdxkhLseMNCUdZPb4Fdm+nqe3ulxMeZXTE1pEcUJ2D6I /yZEEI/blgUpAb56fp5SLEKskz0+mcUQ68a7eq7zc193gVLpPg4bTSF5lQ== X-Google-Smtp-Source: AGHT+IFIxZnb9t5FFWru4SFFchJXru0m6vcKTjUVz+xtaImwDqmBWBH8bCVSlnXGHJpNAoQ8p26MHg== X-Received: by 2002:a05:6a20:3952:b0:1bd:18ee:f145 with SMTP id adf61e73a8af0-1bd18eef235mr4045743637.1.1719339405686; Tue, 25 Jun 2024 11:16:45 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3c5c18sm84441855ad.173.2024.06.25.11.16.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 11:16:45 -0700 (PDT) Message-ID: <53ae342f-78e1-482f-8c31-6fde89eb8159@gmail.com> Date: Tue, 25 Jun 2024 15:17:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240529214632.9843-1-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/25/2024 3:13 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavcodec/packet.h | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/libavcodec/packet.h b/libavcodec/packet.h >> index a9a41576da..9dee035690 100644 >> --- a/libavcodec/packet.h >> +++ b/libavcodec/packet.h >> @@ -330,6 +330,20 @@ enum AVPacketSideDataType { >> */ >> AV_PKT_DATA_AMBIENT_VIEWING_ENVIRONMENT, >> >> + /** >> + * The number of pixels to discard from the >> + * top/bottom/left/right border of the decoded frame to obtain the sub-rectangle >> + * intended for presentation. >> + * >> + * @code >> + * u32le crop_top >> + * u32le crop_bottom >> + * u32le crop_left >> + * u32le crop_right >> + * @endcode >> + */ >> + AV_PKT_DATA_FRAME_CROPPING, >> + >> /** >> * The number of side data types. >> * This is not part of the public API/ABI in the sense that it may > > As I already said about an earlier iteration of this: The cropping is a > rational in ISOBMFF, so it should be here, too. No, i don't want it being a rational. It even makes no sense being one in ISOBMFF to begin with. I don't consider it worth making things any more complex. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".