Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness
Date: Thu, 6 Jul 2023 15:36:27 -0300
Message-ID: <535e745f-cb74-ba89-8f6a-6e749b3bd3d6@gmail.com> (raw)
In-Reply-To: <885a1668-5cd2-4414-6970-bc748cd1bd0@passwd.hu>

On 7/6/2023 2:56 PM, Marton Balint wrote:
> 
> 
> On Thu, 6 Jul 2023, James Almer wrote:
> 
>> On 7/6/2023 4:52 AM, Anton Khirnov wrote:
>>>  Quoting James Almer (2023-07-05 15:03:07)
>>>>  On 7/5/2023 9:56 AM, Anton Khirnov wrote:
>>>>>  Quoting James Almer (2023-07-05 01:26:14)
>>>>>>  Signed-off-by: James Almer <jamrial@gmail.com>
>>>>>>  ---
>>>>>>     configure               |  2 +-
>>>>>>     libavutil/random_seed.c | 16 ++++++++++++++++
>>>>>>     2 files changed, 17 insertions(+), 1 deletion(-)
>>>>>>
>>>>>>  diff --git a/configure b/configure
>>>>>>  index 107d533b3e..d6e78297fe 100755
>>>>>>  --- a/configure
>>>>>>  +++ b/configure
>>>>>>  @@ -3892,7 +3892,7 @@ avfilter_deps="avutil"
>>>>>>     avfilter_suggest="libm stdatomic"
>>>>>>     avformat_deps="avcodec avutil"
>>>>>>     avformat_suggest="libm network zlib stdatomic"
>>>>>>  -avutil_suggest="clock_gettime ffnvcodec libm libdrm libmfx opencl
>>>>>>  user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia
>>>>>>  bcrypt stdatomic"
>>>>>>  +avutil_suggest="clock_gettime ffnvcodec gcrypt libm libdrm libmfx
>>>>>>  opencl openssl user32 vaapi vulkan videotoolbox corefoundation
>>>>>>  corevideo coremedia bcrypt stdatomic"
>>>>>
>>>>>  What will this do exactly?
>>>>
>>>>  It's a soft dependency. Only if OpenSSL or GCrypt are enabled they 
>>>> will
>>>>  be added to avutil's library dependencies.
>>>>  Notice the bcrypt entry, also used in random_seed, and all the 
>>>> hwcontext
>>>>  backends.
>>>
>>>  Ok then.
>>
>> Any opinion on the order of function calls? Should i leave 
>> /dev/urandom as last resort after all (if any) external lib 
>> implementations failed, considering what Remí mentioned?
> 
> I think it is fine as is. Buffering can be turned off with
> setvbuf(f, NULL, _IONBF, 0); so that should not relevant.

Ok, applied as is, then.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-07-06 18:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 23:26 [FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random() James Almer
2023-07-04 23:26 ` [FFmpeg-devel] [PATCH v3 2/3] avutil/random_seed: add av_random_bytes() James Almer
2023-07-05 10:24   ` Anton Khirnov
2023-07-05 12:12     ` [FFmpeg-devel] [PATCH v4 2/4] " James Almer
2023-07-05 12:46       ` Anton Khirnov
2023-07-05 13:24         ` James Almer
2023-07-04 23:26 ` [FFmpeg-devel] [PATCH v3 3/3] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness James Almer
2023-07-05 12:56   ` Anton Khirnov
2023-07-05 13:03     ` James Almer
2023-07-06  7:52       ` Anton Khirnov
2023-07-06 17:03         ` James Almer
2023-07-06 17:56           ` Marton Balint
2023-07-06 18:36             ` James Almer [this message]
2023-07-05 12:43 ` [FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random() Anton Khirnov
2023-07-05 13:24   ` James Almer
2023-07-05 15:34 ` Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535e745f-cb74-ba89-8f6a-6e749b3bd3d6@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git