From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50721429DA for ; Mon, 11 Apr 2022 11:16:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 40D0268B2A9; Mon, 11 Apr 2022 14:16:30 +0300 (EEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2018368B1BC for ; Mon, 11 Apr 2022 14:16:24 +0300 (EEST) Received: by mail-qt1-f177.google.com with SMTP id z14so1774623qto.5 for ; Mon, 11 Apr 2022 04:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=F/R1wFvMUMTK8VdKIkrPOod2BoKC5++XhstXCw5OnUQ=; b=XphYj5tl0pRyu5WRB8QafRmNuQ5iZBAmITM1EoDAbz0skjEQ0hZQx7YdfiOBe0jMQo T+y++FY/+NZ9smT/QGtGfN7nkYFqlyQfQeOh20p/swVpnpHt68GMDs61DHxqra7z6fiM E57xrCb30dQtFmVuYy3KA371+rIe3vzrHR2/MIE2KB6pAHvUtfKAiPCQtU7RN6OYTJ+B +HDnHDxde9jM6ivoGgvSl7i+ZiqadKnHioTQmnKwDSd9R974JKGAUMH6/MH3QRkSVuni VQ9C9YRBF09/K1qvKA+v10EW+of72RBmRFnThy0mRdeHaqgJSHqldt+vc5BgO/7pST7P Fotw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=F/R1wFvMUMTK8VdKIkrPOod2BoKC5++XhstXCw5OnUQ=; b=OOMGULp1P67OoSHRrKFUdrAhAsaAS9mWjBDu1MdWxmpAwuUjhUrrqR6LXb4wy9RvNY R6RGlt9df3BjaeswJXKc7hPqmMk4NMw7T6GZH4mQZjQthY/rv7amvGMFyDqMnCF02qj6 j87nvpmAD/Pp1PgX5G3c+iFtefNdbeHUqq+n/FXIbnzhUPhq16OJmMCKxjzMs+psO2YT 3pva9cHqroT+7xbH8BCPsqFbGU8s4Qi9tyN/TrsAZLbMWDgk0ryI3gLI9tsxtFjm/Z+u +D7NFDWBkr107hUFIWR3pXuhKBBNC0lwujC1c2n43DrmPa1yLQz767LbJvf70E9XRJuh JGLw== X-Gm-Message-State: AOAM533CRpr32NMuLPRTQ55iO00KuJ9OfSkfUlBUWuDD/IwkZsgehKHK jLbARuzNrMhbfgKtvNMEg2lzyCN2ia0= X-Google-Smtp-Source: ABdhPJzI+aBjVsX9lXjJH5K43x+PECvoQZbAtukUa473Lv0aYbyUkYI3z6DMtpEpCaqavArChtNZvg== X-Received: by 2002:ac8:7dd5:0:b0:2e1:ea4a:a743 with SMTP id c21-20020ac87dd5000000b002e1ea4aa743mr25353036qte.30.1649675782624; Mon, 11 Apr 2022 04:16:22 -0700 (PDT) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id i68-20020a375447000000b006809e0adfffsm19459377qkb.25.2022.04.11.04.16.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 04:16:22 -0700 (PDT) Message-ID: <52971445-255c-1ecd-99ea-4303efd8ba73@gmail.com> Date: Mon, 11 Apr 2022 07:16:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US-large To: FFmpeg development discussions and patches References: <20220405165504.29261-1-leo.izen@gmail.com> <20220405165504.29261-4-leo.izen@gmail.com> <164951025246.21047.6570158843618793411@lain.red.khirnov.net> From: Leo Izen In-Reply-To: <164951025246.21047.6570158843618793411@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v13 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/9/22 09:17, Anton Khirnov wrote: > Quoting Leo Izen (2022-04-05 18:55:03) >> + >> + /* check for negative zero, our default */ >> + if (1.0f / ctx->distance == 1.0f / -0.0f) { > IIRC division by zero is UB. Why not make the default -1.0 and then just > check whether the number is negative? > The legal range is between 0 and 15, so if I set the default to -1, it whines that the value is invalid. Should I just set the legal range to -1 to 15 then and assume negative is unset? -Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".