From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B87DF4EF6E for ; Sat, 14 Jun 2025 16:14:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 11E0B68CF06; Sat, 14 Jun 2025 19:14:34 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6DDF868C409 for ; Sat, 14 Jun 2025 19:14:26 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id B4A56EA186 for ; Sat, 14 Jun 2025 18:11:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kPi8vpsj3sHP for ; Sat, 14 Jun 2025 18:11:28 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 13761EA175 for ; Sat, 14 Jun 2025 18:11:28 +0200 (CEST) Date: Sat, 14 Jun 2025 18:11:27 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <5254d4ce-9819-b984-574d-16feac92537c@passwd.hu> References: <20250516231041.4640-1-cus@passwd.hu> <20250516231041.4640-4-cus@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/4] Revert "fftools/resources: Add resource manager files with build-time compression" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 14 Jun 2025, Kacper Michajlow wrote: > On Sat, 17 May 2025 at 01:11, Marton Balint wrote: >> >> This reverts commit 517a8055655798970d94a4c5ea912511362520ea. >> >> Building resources directly in the ffmpeg util needs quite a bit of code, >> increases binary size and makes it harder for the users to change those >> resources at will. >> >> The only user of this, the mermaid and mermaidhtml graph formats were converted >> in an erlier commit to use file loading from the FFMPEG data dirs similar to >> ffpreset files. Therefore the infrastucture to build resources directly into >> ffmpeg CLI tools can be removed now. >> >> Signed-off-by: Marton Balint >> --- >> configure | 5 - >> ffbuild/common.mak | 43 +------ >> fftools/Makefile | 5 +- >> fftools/resources/.gitignore | 4 - >> fftools/resources/Makefile | 13 -- >> fftools/resources/resman.c | 231 ----------------------------------- >> fftools/resources/resman.h | 50 -------- >> 7 files changed, 3 insertions(+), 348 deletions(-) >> delete mode 100644 fftools/resources/.gitignore >> delete mode 100644 fftools/resources/Makefile >> delete mode 100644 fftools/resources/resman.c >> delete mode 100644 fftools/resources/resman.h >> [...] > > Hi Marton, > > Is this still on track to be merged? Resource embedding is broken on > some Windows builds and not sure if I should care to debug/fix that or > this code will be nuked anyway? Softworkz was strongly against nuking it, so I guess it will stay. I am not sure if there are pendig fixes for it. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".