Re: [FFmpeg-devel] [PATCH 4/4] Revert "fftools/resources: Add resource manager files with build-time compression"

[Marton Balint <cus@passwd.hu>]

On Sat, 14 Jun 2025, Kacper Michajlow wrote:

> On Sat, 17 May 2025 at 01:11, Marton Balint <cus@passwd.hu> wrote:
>>
>> This reverts commit 517a8055655798970d94a4c5ea912511362520ea.
>>
>> Building resources directly in the ffmpeg util needs quite a bit of code,
>> increases binary size and makes it harder for the users to change those
>> resources at will.
>>
>> The only user of this, the mermaid and mermaidhtml graph formats were converted
>> in an erlier commit to use file loading from the FFMPEG data dirs similar to
>> ffpreset files. Therefore the infrastucture to build resources directly into
>> ffmpeg CLI tools can be removed now.
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>>  configure                    |   5 -
>>  ffbuild/common.mak           |  43 +------
>>  fftools/Makefile             |   5 +-
>>  fftools/resources/.gitignore |   4 -
>>  fftools/resources/Makefile   |  13 --
>>  fftools/resources/resman.c   | 231 -----------------------------------
>>  fftools/resources/resman.h   |  50 --------
>>  7 files changed, 3 insertions(+), 348 deletions(-)
>>  delete mode 100644 fftools/resources/.gitignore
>>  delete mode 100644 fftools/resources/Makefile
>>  delete mode 100644 fftools/resources/resman.c
>>  delete mode 100644 fftools/resources/resman.h
>>

[...]

>
> Hi Marton,
>
> Is this still on track to be merged? Resource embedding is broken on
> some Windows builds and not sure if I should care to debug/fix that or
> this code will be nuked anyway?

Softworkz was strongly against nuking it, so I guess it will stay. I am 
not sure if there are pendig fixes for it.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".