From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0505D40E09 for ; Thu, 9 Jun 2022 20:22:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7990368B794; Thu, 9 Jun 2022 23:22:06 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DB39968B75C for ; Thu, 9 Jun 2022 23:21:59 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 259KLxPl005466-259KLxPm005466 for ; Thu, 9 Jun 2022 23:21:59 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 13FF3A142E for ; Thu, 9 Jun 2022 23:21:58 +0300 (EEST) Date: Thu, 9 Jun 2022 23:21:58 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <5253117-79a-fddd-1c2e-b6b3812a423b@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 9 Jun 2022, nil-admirari@mailo.com wrote: >> This looks fine to me, and the discussion seems to have converged, so I'll >> go ahead and push this. > > Build is now failing: https://github.com/yt-dlp/FFmpeg-Builds/runs/6819319105?check_suite_focus=true. > > In file included from /opt/ct-ng/i686-w64-mingw32/sysroot/mingw/include/dshow.h:33, > from libavcodec/mf_utils.h:32, > from libavcodec/mfenc.c:26: > ./libavutil/wchar_filename.h: In function 'add_extended_prefix': > ./libavutil/wchar_filename.h:211:9: error: 'wcscpy_instead_use_StringCbCopyW_or_StringCchCopyW' undeclared (first use in this function) > 211 | wcscpy(temp_w, unc_prefix); > | ^~~~~~ > ./libavutil/wchar_filename.h:211:9: note: each undeclared identifier is reported only once for each function it appears in This error isn't reproducible in git master - it's triggered by your yet-unmerged patches (that include wchar_filename.h in w32dlfcn.h). > Incompatible pointer types warning is still there as well: > > In file included from ./libavformat/internal.h:30, > from libavdevice/alldevices.c:21: > ./libavformat/os_support.h: In function 'win32_stat': > ./libavformat/os_support.h:241:36: warning: passing argument 2 of '_wstat64' from incompatible pointer type [-Wincompatible-pointer-types] > 241 | ret = _wstat64(filename_w, &crtstat); > | ^~~~~~~~ > | | > | struct _stati64 * > In file included from ./libavformat/os_support.h:32, > from ./libavformat/internal.h:30, > from libavdevice/alldevices.c:21: > /opt/ct-ng/i686-w64-mingw32/sysroot/mingw/include/sys/stat.h:129:69: note: expected 'struct _stat64 *' but argument is of type 'struct _stati64 *' > 129 | _CRTIMP int __cdecl _wstat64(const wchar_t *_Name,struct _stat64 *_Stat); > | ~~~~~~~~~~~~~~~~^~~~~ This I can indeed reproduce now. I did build these patches in a couple other environments (both mingw and msvc) where those warnings didn't appear, but now I managed to find one that shows those warnings. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".