From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D930549CD7 for ; Thu, 19 Jun 2025 09:37:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0213568D6CC; Thu, 19 Jun 2025 12:37:52 +0300 (EEST) Received: from smtp-190d.mail.infomaniak.ch (smtp-190d.mail.infomaniak.ch [185.125.25.13]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 77F3368C2F3 for ; Thu, 19 Jun 2025 12:37:45 +0300 (EEST) Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4bNFrn0W1mzDg2 for ; Thu, 19 Jun 2025 11:37:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=regaud-chapuy.fr; s=20201206; t=1750325864; bh=oF8/VCOu/b4JGTYAOMwktxfmzOcTxjzhA0hCt7YJhsA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=jcsNoC4kG3uV1uAAXhvKBzWX9Y2esVlKE4kBnQDeyRkZAgsf36n3g4aTFpLNaRGy5 sLcRv9Nx+EFbVclSl1bNMwWw11J54FjoPArro0rV+cAgvNAaLm8PwSNpj5hq8U8v+b BiJUtGdYb99VjGqsO0UsK+kH1dd7aClIQEnCX0LA= Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4bNFrm38yNzQQy for ; Thu, 19 Jun 2025 11:37:44 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------Jng5WMnVpSE1WVta8XUjEEOL" Message-ID: <522ab438-41c6-45d4-8292-78ead2f6b206@regaud-chapuy.fr> Date: Thu, 19 Jun 2025 11:37:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <2dc54cad-932f-4c30-9f9d-0a943e0a7be3@regaud-chapuy.fr> <639a031a-06c7-4855-8d97-de61626ba194@regaud-chapuy.fr> <20250617235625.GL29660@pb2> <20250619001725.GQ29660@pb2> Content-Language: fr, en-US From: =?UTF-8?B?VGltb3Row6ll?= In-Reply-To: <20250619001725.GQ29660@pb2> X-Infomaniak-Routing: alpha X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/codecview: Enable QP visualization for H.264 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------Jng5WMnVpSE1WVta8XUjEEOL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Context from the first version : Subject was "avcodec/h264: fixed qp table attach for h264" > Here is a patch where I fixed the attach of per-macroblock qp tables for > H.264. It was implemented for MPEG2 so I have only extended it. > > I tested the functionality with the codecview filter using the following > command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=qp=1 > output.mp4` Here is the new version of the patch. I have remove the unnecessary line in qp_table.h and changed the commit message. Timothee --------------Jng5WMnVpSE1WVta8XUjEEOL Content-Type: text/x-patch; charset=UTF-8; name="0001-avfilter-codecview-Enable-QP-visualization-for-H.264.patch" Content-Disposition: attachment; filename*0="0001-avfilter-codecview-Enable-QP-visualization-for-H.264.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3NGIzZmMzY2M5ZjEwYTk0ODNiM2NhMWM4MzhkNjlmZTRjYjZjM2JhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGhlZSA8dGltb3RoZWUuaW5mb3JtYXRpcXVl QHJlZ2F1ZC1jaGFwdXkuZnI+CkRhdGU6IFRodSwgMTkgSnVuIDIwMjUgMTE6MjM6NDUgKzAy MDAKU3ViamVjdDogW1BBVENIXSBhdmZpbHRlci9jb2RlY3ZpZXc6IEVuYWJsZSBRUCB2aXN1 YWxpemF0aW9uIGZvciBILjI2NAoKVGhlIGNvZGVjdmlld2ZpbHRlciwgd2hlbiB1c2VkIHdp dGggcXA9MSwgZGlkIG5vdCBkaXNwbGF5IHF1YW50aXphdGlvbiBwYXJhbWV0ZXIgdmFsdWVz IGZvciBILjI2NCBzdHJlYW1zIGJlY2F1c2UgdGhlIFFQIHRhYmxlIGV4dHJhY3Rpb24gd2Fz IHJlc3RyaWN0ZWQgdG8gTVBFRy0yIHZpZGVvLgoKVGhpcyBwYXRjaCBlbmFibGVzIEguMjY0 IHN1cHBvcnQgYnkgdXBkYXRpbmcgZmZfcXBfdGFibGVfZXh0cmFjdHRvIGFjY2VwdCBBVl9W SURFT19FTkNfUEFSQU1TX0gyNjQuIFRoaXMgYWxsb3dzIGZvciBjb3JyZWN0IFFQIG92ZXJs YXkgb24gSC4yNjQgdmlkZW8KClNpZ25lZC1vZmYtYnk6IFRpbW90aGVlIDx0aW1vdGhlZS5p bmZvcm1hdGlxdWVAcmVnYXVkLWNoYXB1eS5mcj4KLS0tCiBsaWJhdmZpbHRlci9xcF90YWJs ZS5jIHwgNSArKystLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWJhdmZpbHRlci9xcF90YWJsZS5jIGIvbGliYXZm aWx0ZXIvcXBfdGFibGUuYwppbmRleCA4MTM3ZGMwMTlmLi5hYmU0NmU4MTBiIDEwMDY0NAot LS0gYS9saWJhdmZpbHRlci9xcF90YWJsZS5jCisrKyBiL2xpYmF2ZmlsdGVyL3FwX3RhYmxl LmMKQEAgLTM5LDggKzM5LDkgQEAgaW50IGZmX3FwX3RhYmxlX2V4dHJhY3QoQVZGcmFtZSAq ZnJhbWUsIGludDhfdCAqKnRhYmxlLCBpbnQgKnRhYmxlX3csIGludCAqdGFibGUKICAgICBz ZCA9IGF2X2ZyYW1lX2dldF9zaWRlX2RhdGEoZnJhbWUsIEFWX0ZSQU1FX0RBVEFfVklERU9f RU5DX1BBUkFNUyk7CiAgICAgaWYgKCFzZCkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgcGFy ID0gKEFWVmlkZW9FbmNQYXJhbXMqKXNkLT5kYXRhOwotICAgIGlmIChwYXItPnR5cGUgIT0g QVZfVklERU9fRU5DX1BBUkFNU19NUEVHMiB8fAorICAgIHBhciA9IChBVlZpZGVvRW5jUGFy YW1zICopc2QtPmRhdGE7CisgICAgaWYgKChwYXItPnR5cGUgIT0gQVZfVklERU9fRU5DX1BB UkFNU19NUEVHMiAmJgorICAgICAgICAgcGFyLT50eXBlICE9IEFWX1ZJREVPX0VOQ19QQVJB TVNfSDI2NCkgfHwKICAgICAgICAgKHBhci0+bmJfYmxvY2tzICE9IDAgJiYgcGFyLT5uYl9i bG9ja3MgIT0gbmJfbWIpKQogICAgICAgICByZXR1cm4gQVZFUlJPUihFTk9TWVMpOwogCi0t IAoyLjM5LjUKCg== --------------Jng5WMnVpSE1WVta8XUjEEOL Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------Jng5WMnVpSE1WVta8XUjEEOL--