From 74b3fc3cc9f10a9483b3ca1c838d69fe4cb6c3ba Mon Sep 17 00:00:00 2001 From: Timothee Date: Thu, 19 Jun 2025 11:23:45 +0200 Subject: [PATCH] avfilter/codecview: Enable QP visualization for H.264 The codecviewfilter, when used with qp=1, did not display quantization parameter values for H.264 streams because the QP table extraction was restricted to MPEG-2 video. This patch enables H.264 support by updating ff_qp_table_extractto accept AV_VIDEO_ENC_PARAMS_H264. This allows for correct QP overlay on H.264 video Signed-off-by: Timothee --- libavfilter/qp_table.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/qp_table.c b/libavfilter/qp_table.c index 8137dc019f..abe46e810b 100644 --- a/libavfilter/qp_table.c +++ b/libavfilter/qp_table.c @@ -39,8 +39,9 @@ int ff_qp_table_extract(AVFrame *frame, int8_t **table, int *table_w, int *table sd = av_frame_get_side_data(frame, AV_FRAME_DATA_VIDEO_ENC_PARAMS); if (!sd) return 0; - par = (AVVideoEncParams*)sd->data; - if (par->type != AV_VIDEO_ENC_PARAMS_MPEG2 || + par = (AVVideoEncParams *)sd->data; + if ((par->type != AV_VIDEO_ENC_PARAMS_MPEG2 && + par->type != AV_VIDEO_ENC_PARAMS_H264) || (par->nb_blocks != 0 && par->nb_blocks != nb_mb)) return AVERROR(ENOSYS); -- 2.39.5