From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7358147D24 for ; Tue, 19 Dec 2023 12:09:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E173668D028; Tue, 19 Dec 2023 14:09:00 +0200 (EET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 948F668CFAC for ; Tue, 19 Dec 2023 14:08:54 +0200 (EET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d0c4d84bf6so20265755ad.1 for ; Tue, 19 Dec 2023 04:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702987732; x=1703592532; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Ha9gl5fdUmYLWj1cX4jrPoo2aYyKR23APJh3iK+5AAE=; b=OjF55fvIfyh1VX9bcf2bHMNuz9QzyBoFwiVOymnzccU+rpaBNpiadC6JgB0dIQIjqJ gOIpgvR958rsbckL6diPb2zhNWYSlLmG930qj1vDqAGYjwCDxzPLAi1x+fjy4f+/l/L6 /vmMKpMJ5jMFW2S8TrSY/xBxDjIIeCKNpRVPECZI532s1rVjUe5Y/YN3BoMckrhgFa70 bo3eAMT2lSVADyamaw/7LvrPAKHJ9RqeDcPD050/nff5NdMWpJPgstEGy45+5p6pTw4t ZF7FKUCh361QF31g6fTqEXOOhemB1JuxrPzb1ipirzNY35o13H+oio6KxOiu3U168qAs 2z3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702987732; x=1703592532; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ha9gl5fdUmYLWj1cX4jrPoo2aYyKR23APJh3iK+5AAE=; b=jvLvS3QWa0+5OssE7a8VpI72n1KNslWk221Jst1c6oYVrGjxkp/rMLHy6kg0D4lufX iSnWYa7cgFBGJty3CF+FTroDgFskKB8kc8XLGCMcKD32LLVbjTq4F8WDAuLSGLRS2K8o 4YFgzZBqlyyiDuLAPTsnz/nHroxW/bTEmF3pSTF3I23hFkxyq5+R8AQcNNRzAo3ImZi3 HtUMyqO5pk2jJyUryKlgVpVCkz3Vu2Bcxwl8UQlOPrTKT5SPbydgsTVMTJaPAXAL5ISX Cy9ZS5w/+GItzZlSDVsWS7VZ74HLKx35K6Ck9H2U4KozyxkEp62NE+748DdQ1SYtx5Eg reXA== X-Gm-Message-State: AOJu0YwJSUFE7lX3Vz2tmKGbIc6CZx+mfHXUtDuiKz/JyXPp6olUCQWg Xw3Ch6sDss98H/NFttvjJLtQomOx+7M= X-Google-Smtp-Source: AGHT+IFpiRbiwa9Pqnn3GlDedf3YNnY50yuSVXhwRv52cySFCfh4wpcAfAq8HwazruuBMt47lp204g== X-Received: by 2002:a17:902:a383:b0:1d0:307f:1bd8 with SMTP id x3-20020a170902a38300b001d0307f1bd8mr8722153pla.68.1702987732222; Tue, 19 Dec 2023 04:08:52 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id u3-20020a17090341c300b001d3cb4e3302sm2792076ple.214.2023.12.19.04.08.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 04:08:51 -0800 (PST) Message-ID: <52289c00-e190-45e9-92bc-028459cd6f9d@gmail.com> Date: Tue, 19 Dec 2023 09:09:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231218191913.2071-1-anton@khirnov.net> <170298247031.8914.4423993700905646592@lain.khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <170298247031.8914.4423993700905646592@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf: allow setting AVStream.discard as an AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/19/2023 7:41 AM, Anton Khirnov wrote: > Quoting James Almer (2023-12-18 20:30:47) >> On 12/18/2023 4:19 PM, Anton Khirnov wrote: >>> --- >>> libavformat/options.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/libavformat/options.c b/libavformat/options.c >>> index bf6113ca95..cc89dd6c72 100644 >>> --- a/libavformat/options.c >>> +++ b/libavformat/options.c >>> @@ -229,6 +229,16 @@ static const AVOption stream_options[] = { >>> { "metadata", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_METADATA }, .unit = "disposition" }, >>> { "dependent", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_DEPENDENT }, .unit = "disposition" }, >>> { "still_image", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_STILL_IMAGE }, .unit = "disposition" }, >>> + >>> + { "discard", NULL, offsetof(AVStream, discard), AV_OPT_TYPE_INT, { .i64 = AVDISCARD_DEFAULT }, INT_MIN, INT_MAX, >>> + .flags = AV_OPT_FLAG_DECODING_PARAM, .unit = "avdiscard" }, >>> + { "none", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONE }, .unit = "avdiscard" }, >>> + { "default", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_DEFAULT }, .unit = "avdiscard" }, >>> + { "noref", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONREF }, .unit = "avdiscard" }, >>> + { "bidir", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_BIDIR }, .unit = "avdiscard" }, >>> + { "nointra", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONINTRA }, .unit = "avdiscard" }, >>> + { "nokey", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONKEY }, .unit = "avdiscard" }, >>> + { "all", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_ALL }, .unit = "avdiscard" }, >>> { NULL } >>> }; >> >> Should be ok. >> >> Maybe also add "id" like i did for AVStreamGroup while at it. > > The problem with id is how to flag it - it's read-only for demuxing and > user-settable for muxing. Wouldn't the AV_OPT_FLAG_ENCODING_PARAM flag be enough for the CLI to reject it for demuxing cases? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".