From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6556546CF9 for ; Sun, 8 Oct 2023 12:08:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DFB168CA03; Sun, 8 Oct 2023 15:08:52 +0300 (EEST) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB2C568C8E8 for ; Sun, 8 Oct 2023 15:08:45 +0300 (EEST) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-35135b79b6aso14073875ab.0 for ; Sun, 08 Oct 2023 05:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696766923; x=1697371723; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ipyhufYN5nYWp4QSs5hDtqy2qiUVE+9vsA3HMu8vArQ=; b=RbNkqPMvbqWfEX6OfkE+cHKV//109iXSNOjEr5ZlvV2qnbyrIzidfbylkwkvcWS3LH fV0i/GzYIQ9518rt0r+uRAA2dgaferpMsU93EAZEleywdUxC1UADAuCphcCtahokG+t8 idUj5gJkwRW8VCly5eEiDWEyNOjC5FGhdeg5oU2Q6NXh0p5v3L2sIOe7mdn0hbe0ZhwL v31meZmHoPd4CuzemeVo8vh3v88MyZF+Gvszw0S8KkBz5vRmPz0qUUcC0vhNED3ORZlz XL/BZUKdlZIMeC9z6ezcJgC6EkzacD1z/3gyThB4AvrqMLlyKVOFvYIDP5tntjVBYoqd eoEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696766923; x=1697371723; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ipyhufYN5nYWp4QSs5hDtqy2qiUVE+9vsA3HMu8vArQ=; b=X5ItVlHV9Nbz1X7sfdCsxvPPXIjcCrY+z6UurrqDSwjWx6TwdyIH9TRYNXZ/+Ql2SV xnrSnx5ZIraCLPH/OrQS+HCkC2DhbXJG27sVJN5eET2CpOb0KcQI5nO1TL+5tk/3PiND QzqXo3/XCi9rxe0HilPrvGfasOgOW3+oJ/0E2yIFUirwoqakJmgmINIReR1VoVlr0NB/ R5vtagSsKLomdXC1dGSeZQuF1sqhUsBuWsK+sALFt8xljTS1Ai0o7EVBLgLLrFPeyWGI JjIYhLX+uwBzoaPOGhWLkZq8F3Ba4o48UXJl+WU06bQNQ1J6uHdpiYNou3msPw/IaKjE 92oA== X-Gm-Message-State: AOJu0YzygJRImN1AqOb3StumW73NM442/2D/+jCtw4/Kz1h+/GkhP5uo KWpNZ2YxVxO+Pq5US6m960N2DHvhIEI= X-Google-Smtp-Source: AGHT+IGqXHMRwAEvya86MsbwjGJcIAvWlC028Wc6Wo8D30Uh9vhQMS1svTvFL9zi63vslifzzxxCKw== X-Received: by 2002:a05:6e02:1243:b0:34f:9f86:dd45 with SMTP id j3-20020a056e02124300b0034f9f86dd45mr11464494ilq.3.1696766923488; Sun, 08 Oct 2023 05:08:43 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id f24-20020aa78b18000000b0068fd026b496sm4374998pfd.46.2023.10.08.05.08.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Oct 2023 05:08:43 -0700 (PDT) Message-ID: <52191ea3-cea6-4f23-82b0-4c5c99573fd2@gmail.com> Date: Sun, 8 Oct 2023 09:09:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231008115737.80200-1-lq@chinaffmpeg.org> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231008115737.80200-1-lq@chinaffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/8/2023 8:57 AM, Steven Liu wrote: > Makes the output of the libaom av1 decoder consistent with external decoders like > libdav1d. > > reference commit: 1652f2492f88434010053289d946dab6a57e4d58 But it is known at this point. picture->sample_aspect_ratio is set directly above. What needs to be done is initializing the decoder in aom_init() using the extradata, so lavf will not attempt to decode frames in order to get stream info, which is what i assume is happening here and why you want SAR to be 0/1. > > Signed-off-by: Steven Liu > --- > libavcodec/libaomdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > index 695d901051..ff4137bfc6 100644 > --- a/libavcodec/libaomdec.c > +++ b/libavcodec/libaomdec.c > @@ -204,7 +204,6 @@ static int aom_decode(AVCodecContext *avctx, AVFrame *picture, > picture->height * img->r_w, > picture->width * img->r_h, > INT_MAX); > - ff_set_sar(avctx, picture->sample_aspect_ratio); > > if ((img->fmt & AOM_IMG_FMT_HIGHBITDEPTH) && img->bit_depth == 8) > ff_aom_image_copy_16_to_8(picture, img); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".