From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9A13548C0C for ; Mon, 22 Jan 2024 21:52:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B79D68CCB8; Mon, 22 Jan 2024 23:52:05 +0200 (EET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6596E68B02D for ; Mon, 22 Jan 2024 23:51:59 +0200 (EET) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33922d2cb92so3287834f8f.1 for ; Mon, 22 Jan 2024 13:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1705960318; x=1706565118; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JgZcvOL+0PuRAoNv/vFNCfXbLlL89UxBSPNsvonFYKA=; b=Srn/NsAEF7qGQkgJu25lRPAuXV44mvb+u505w/TE4lLY56z+W9MEeeK+T0hQeIQdBY Vp3xJ4x9YGAcUUa23Z/7aGF/QY5aT/IoLykZ1/Yq+0Am4ZiFN1eRavl4llUi0Vp3tPqE uYH9zQhY9UzHwg4xZ51jCgg2NBgfM3O8wgORjTptTZDTAqeiJHW1Q87tZUvrfwmylm2A sHiavFFDQUR4aSzOETUnQ3igZf5RfwR6pqcqgDQKEICdemeMT8MDNhj2JFDqTG0Vtsmu y/k+zg/IX+xjECDIgNjJulOQyGtCeOnH2/JJgXVRwSCjsvWxbtALwjYM5fJX63e/qW1i Ev4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705960318; x=1706565118; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JgZcvOL+0PuRAoNv/vFNCfXbLlL89UxBSPNsvonFYKA=; b=aGwBZWrQQbE0SQV/BNbFYTGJhjcJ7F83ET1v2QDdTixrEjdu+SBaFZO1xZZCR93hc7 J5uaRhniJnJ5lOc2Dhn14YuRVY3uP008CzjCOj1FIOGQ8460erhDdH02lTtcsaZ59y4X VTDatxZQyuXbctxRub94+X7NQQsVx/kMYG5vhaycGzSUAqiPQfvkEMy7YMxx4heHHLBS gTW0JqC6OVZYgFFCV5RNosftQ53/E/htIRJpjU6rj7re5TZOb450VP0olvwTYZIxqSqK NnAzPFjj/Y4zl4flINXVJQypAVP8IH7H+lI5tLaGCZY8CITh7cx4rTQpfcv/7etDw+S/ VyQg== X-Gm-Message-State: AOJu0YwTpv425SNl16xgjnJWj0NTi648rB+CMd/Ybj3ZccC4AbCINkpw 4+JFOi70NLWOhIxwAnGSA2Dlioe6IrbqxXO+dZV77NhYwNVvwBf2KwEjCkIsvhPVUsr3hRihyW6 7 X-Google-Smtp-Source: AGHT+IFybgLkThphd5H6TOSHbvrhD/379ODgh+3Llqz4dvwqIGUAgxeasOvu+WLkJ3kMJeRMU+4QRQ== X-Received: by 2002:a05:6000:11cb:b0:336:6e55:2350 with SMTP id i11-20020a05600011cb00b003366e552350mr1668483wrx.200.1705960318472; Mon, 22 Jan 2024 13:51:58 -0800 (PST) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id b7-20020a5d45c7000000b003392e798899sm5206379wrs.35.2024.01.22.13.51.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 13:51:58 -0800 (PST) Message-ID: <52035da0-1c0a-48fc-8846-6f2705230fb3@jkqxz.net> Date: Mon, 22 Jan 2024 21:52:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240122055756.1142-1-tong1.wu@intel.com> <20240122055756.1142-7-tong1.wu@intel.com> From: Mark Thompson In-Reply-To: <20240122055756.1142-7-tong1.wu@intel.com> Subject: Re: [FFmpeg-devel] [PATCH 7/9] avutil/hwcontext_d3d12va: add Flags for resource creation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 22/01/2024 05:57, tong1.wu-at-intel.com@ffmpeg.org wrote: > From: Tong Wu > > Flags field is added to support diffferent resource creation. > > Signed-off-by: Tong Wu > --- > doc/APIchanges | 3 +++ > libavutil/hwcontext_d3d12va.c | 2 +- > libavutil/hwcontext_d3d12va.h | 5 +++++ > libavutil/version.h | 2 +- > 4 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index e477ed78e0..a33e54dd3b 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09 > > API changes, most recent first: > > +2024-01-xx - xxxxxxxxxx - lavu 58.37.100 - hwcontext_d3d12va.h > + Add AVD3D12VAFramesContext.Flags > + > 2023-11-xx - xxxxxxxxxx - lavfi 9.16.100 - buffersink.h buffersrc.h > Add av_buffersink_get_colorspace and av_buffersink_get_color_range. > Add AVBufferSrcParameters.color_space and AVBufferSrcParameters.color_range. > diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c > index 414dd44290..0d94f48543 100644 > --- a/libavutil/hwcontext_d3d12va.c > +++ b/libavutil/hwcontext_d3d12va.c > @@ -237,7 +237,7 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size) > .Format = hwctx->format, > .SampleDesc = {.Count = 1, .Quality = 0 }, > .Layout = D3D12_TEXTURE_LAYOUT_UNKNOWN, > - .Flags = D3D12_RESOURCE_FLAG_NONE, > + .Flags = hwctx->Flags, This seems like a hole in the existing decoder implementation? How does it work without making D3D12_RESOURCE_FLAG_VIDEO_DECODE_REFERENCE_ONLY textures when required by the device? > }; > > frame = av_mallocz(sizeof(AVD3D12VAFrame)); > diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h > index ff06e6f2ef..dc1c17d3f9 100644 > --- a/libavutil/hwcontext_d3d12va.h > +++ b/libavutil/hwcontext_d3d12va.h > @@ -129,6 +129,11 @@ typedef struct AVD3D12VAFramesContext { > * If unset, will be automatically set. > */ > DXGI_FORMAT format; > + > + /** > + * This field is used for resource creation. This documentation could be better. Used to do what? Can it not be set, and what is the behaviour if it isn't? > + */ > + D3D12_RESOURCE_FLAGS Flags; Use lowercase for structure elements. > } AVD3D12VAFramesContext; > > #endif /* AVUTIL_HWCONTEXT_D3D12VA_H */ > diff --git a/libavutil/version.h b/libavutil/version.h > index 772c4e209c..3ad1a9446c 100644 > --- a/libavutil/version.h > +++ b/libavutil/version.h > @@ -79,7 +79,7 @@ > */ > > #define LIBAVUTIL_VERSION_MAJOR 58 > -#define LIBAVUTIL_VERSION_MINOR 36 > +#define LIBAVUTIL_VERSION_MINOR 37 > #define LIBAVUTIL_VERSION_MICRO 101 > > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \ It's not good to be changing the user-facing API like this. Are there any more properties here which really should be user-visible? Adding them one at a time later would be very unfortunate and make compatibility harder. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".