Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: "Martin Storsjö" <martin@martin.st>, ffmpeg-devel@ffmpeg.org
Cc: zhilizhao@tencent.com
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode
Date: Tue, 4 Feb 2025 13:58:41 +0100
Message-ID: <51fb302d-3b75-44e2-920a-bf74acebfaa9@rothenpieler.org> (raw)
In-Reply-To: <ff5bd9ed-a2f9-1a24-18ff-2c907d429a18@martin.st>

On 04/02/2025 13:25, Martin Storsjö wrote:
> On Mon, 3 Feb 2025, Zhao Zhili wrote:
> 
>> ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> | Thu Jan 
>> 23 22:17:29 2025 +0800| [1438f6997db70945173f01aea1768e3b27ce2679] | 
>> committer: Zhao Zhili
>>
>> avcodec/nvenc: Enable recovery point SEI for intra refresh mode
>>
>> Otherwise all frames can be dropped after seek without the
>> output_corrupt/showall flags.
>>
>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>> Reviewed-by: Timo Rothenpieler <timo@rothenpieler.org>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/? 
>>> a=commit;h=1438f6997db70945173f01aea1768e3b27ce2679
>> ---
>>
>> libavcodec/nvenc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
>> index c52e47734e..c359c2bc8a 100644
>> --- a/libavcodec/nvenc.c
>> +++ b/libavcodec/nvenc.c
>> @@ -1281,6 +1281,7 @@ static av_cold int 
>> nvenc_setup_h264_config(AVCodecContext *avctx)
>>         h264->intraRefreshPeriod = cc->gopLength;
>>         h264->intraRefreshCnt = cc->gopLength - 1;
>>         cc->gopLength = NVENC_INFINITE_GOPLENGTH;
>> +        h264->outputRecoveryPointSEI = 1;
> 
> This change breaks building with older versions of nv-codec-headers 
> installed.

Even the 8.1 SDK has this, which is the oldest version still supported 
by FFmpeg:
https://github.com/FFmpeg/nv-codec-headers/blob/sdk/8.1/include/ffnvcodec/nvEncodeAPI.h#L1279
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-02-04 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250203174043.141F7412710@natalya.videolan.org>
2025-02-04 12:25 ` Martin Storsjö
2025-02-04 12:58   ` Timo Rothenpieler [this message]
2025-02-04 13:23     ` Martin Storsjö
2025-02-04 13:32       ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51fb302d-3b75-44e2-920a-bf74acebfaa9@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=martin@martin.st \
    --cc=zhilizhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git