From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 0B60B4847C
	for <ffmpegdev@gitmailbox.com>; Thu,  4 Jan 2024 12:48:59 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A84A368C849;
	Thu,  4 Jan 2024 14:48:57 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8A32A68A9C0
 for <ffmpeg-devel@ffmpeg.org>; Thu,  4 Jan 2024 14:48:51 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 404CmovE004629-404CmovF004629
 for <ffmpeg-devel@ffmpeg.org>; Thu, 4 Jan 2024 14:48:50 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id E6A11A1482
 for <ffmpeg-devel@ffmpeg.org>; Thu,  4 Jan 2024 14:48:50 +0200 (EET)
Date: Thu, 4 Jan 2024 14:48:50 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20231220124248.2816809-1-martin@martin.st>
Message-ID: <51fa1ddc-72d8-b348-7fa2-b6c7ea29cce3@martin.st>
References: <20231220124248.2816809-1-martin@martin.st>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] configure: Disable inline assembly with
 nonlocal labels with LTO on Clang on Windows
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-15"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/51fa1ddc-72d8-b348-7fa2-b6c7ea29cce3@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Wed, 20 Dec 2023, Martin Storsj=F6 wrote:

> The file libavcodec/x86/mlpdsp_init.c uses inline assembly with
> nonlocal labels that are referenced outside of the assembly in C.
> This fails to link with LTO when built with Clang when targeting
> Windows.
>
> The root cause has been reported upstream at
> https://github.com/llvm/llvm-project/issues/76046.
>
> Fixes: https://trac.ffmpeg.org/ticket/10548
> ---
> configure | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index 7742ea4ba2..b4f7c2de66 100755
> --- a/configure
> +++ b/configure
> @@ -7372,6 +7372,16 @@ if [ -n "$lto" ]; then
>     check_cflags  $lto
>     check_ldflags $lto $cpuflags
>     disable inline_asm_direct_symbol_refs
> +    if test "$cc_type" =3D "clang"; then
> +        # Clang's LTO fails on Windows, when there are references outside
> +        # of inline assembly to nonlocal labels defined within inline as=
sembly,
> +        # see https://github.com/llvm/llvm-project/issues/76046.
> +        case $target_os in
> +        mingw32|win32)
> +            disable inline_asm_nonlocal_labels
> +            ;;
> +        esac
> +    fi
> fi

Will push soon

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".