From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 537F948988 for ; Fri, 22 Dec 2023 01:22:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A577A68CE38; Fri, 22 Dec 2023 03:22:39 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59F7068CE38 for ; Fri, 22 Dec 2023 03:22:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703208157; x=1734744157; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=UbaoOvgPcDexUAIUgkd31DZTcRAH+xdPOClUAV61iFA=; b=k+5H+Ab9126G6rJ1O5ifO5WN/QxUokCjTP9VavF//gWUQbyn2326GUw+ lRirfF7Nz95plSQoQf6p+nyLG8hXkXe7ahYeT9bskbKtbtdLe8Q/7MDgM kYlnRHiKHJrmKtWQbd5ruGXwMklXz7u5HwVT/O62XhiY5KbH8ONjxk3Cl 7a1YzBElUzP5IY5GQwn9mx5N3pdPgo+kAgFnI3TaPmoiqIW9AwTXBD1IV gHufF390ZSPDJCclNQafcwEXsdYqfV/GX7ODXSjqQZKGCplEFAKL5Akeh k7i+lN2Hew4nwxY5TjeH2ku64boeUwb06zZfWnOWy6sA//arCcEW/JKJj w==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="386487147" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="386487147" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 17:22:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="18881285" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 17:22:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 17:22:29 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 17:22:29 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 17:22:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jo0kl0etHswaawKKkwGtMzz6r9pj3o9dEK4DM3bNJS0qJ3UUjJHl+QHQYDIvAeVu/QXnJB36EI4HRlKfF1LHKxZY0bKZR1YuyJD3W/2D59GKeltlzvJ5GAsMOghez3udd4AYUmFcjaLXJsuu/kvW5usBE1VK8P0DzYcsh385NHJkjtc0wtaDP5xds0V7+GA2wB3FioRzjifrRyVk7ZKWgL6w5f2f9UALzuFWhQpiSwspazGf5U6f0R0CAcDZfQCaO/dgMxaMYlMS1+PLi7RacFEphYXPQ9422kDaJQZHqb71R8VWEJ9IlA0hQCvsmKSYrpLH1yXPcLvrOiMpNs2V+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbaoOvgPcDexUAIUgkd31DZTcRAH+xdPOClUAV61iFA=; b=m0h68+CKDYi19VzMRd4iC9YKZXNzgcma8VAIBAWgdhhMETqsxCAID4vqb/qgUIE0Gb/PEhFKOixhGLcJRDcMDnBlz2RtH7W6bRZyGn6iArKb25XudvZSyxOoIBQDJIUtOe9ss3dWrGKZp8JSI4MwuZzAy5XxBzdWbw1Y9Ws+8SY9U6YVmi8OJYnbFxPI+ZSyVsoGOC8cPIunCz3OxIFIy/D9xYl2hXQgQdzoKgmW0JHbEY39zJTA1E3ATtIz18fXPn5YUb63VIGwxbUW37XmhX35HLO4g2d/Ga7/51ejARkEDqCmHR6PYbc1o9564U3jJyckRWeKiqqn4XHHjDKNNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB5034.namprd11.prod.outlook.com (2603:10b6:806:f8::15) by SJ0PR11MB4781.namprd11.prod.outlook.com (2603:10b6:a03:2d8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 01:22:26 +0000 Received: from SA2PR11MB5034.namprd11.prod.outlook.com ([fe80::6875:d72c:7048:9358]) by SA2PR11MB5034.namprd11.prod.outlook.com ([fe80::6875:d72c:7048:9358%7]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 01:22:25 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list Thread-Index: AQHaM18UuTF0F5Vr3E+ZBi8a6HaHkLCy55oAgAE1coCAAGcLgA== Date: Fri, 22 Dec 2023 01:22:24 +0000 Message-ID: <51d4f55fcabe1704f17ac4154b3d108fec4dbacc.camel@intel.com> References: <20231220084356.796186-1-fei.w.wang@intel.com> <0ec4a5a324fcb829eea33916dfc4b44e7a91b79b.camel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB5034:EE_|SJ0PR11MB4781:EE_ x-ms-office365-filtering-correlation-id: fe185643-ef10-46bb-0974-08dc028c744b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pQKPtgGuclab3kK5eRKsMWarWaBKXW5bS0OFiZt1LYZjeUIG/5HTTtbIyYAMn3a1uyAE97OPHxAZrMn2i6kEW4eCPSewFUVgulP+Fk9PXvi/lwo2Hxx9mQItMaUItvthKfVcY7tH9mgOaGG9dlSFvUhMP2V1hikotNk8QfVr3SnICkko/v3Sw7Rja2vS2umPEmguLlTTNABtd1hjPwQOvOCfurgjTqqSwwzu9uKKjxXB3bub5La1sm/XoP1vplIPKJPP6yWYpZYmFyTrim0vrLHW7bKQJT/G9xfTN918VWbzsmCm04H2u0U3tY09NnIYZX78KhOzrwS6y7CBkYgRfUCb/cYjXEWSkwP4PqnrIBjV+eQLGiaqGXQEuYButvcWAXoMLUYKhxNvADntOajeb5/hMZ4aeR6vhNdUxmhbQ7j+VGhOgGSrfZrJXCPF7mjo2ryw+EwCCFqT2++CV0kzoAqbK34adtUOHZLSv/RBWfbHz8R70ucl4WLWQxMxFuvv6TNEYaPXaQpJepGXrdsmHjPeES6O/ucTvRdIME4m3Km4Yk8Ij30qVHhLEgFKiq+bV5ufY256UCVKoIpYW4iDdM3YIS8MFyfstXbOfTADOqw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5034.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(396003)(136003)(376002)(366004)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(76116006)(122000001)(8676002)(8936002)(66899024)(91956017)(64756008)(66446008)(66476007)(66556008)(66946007)(6916009)(316002)(82960400001)(4001150100001)(2906002)(41300700001)(86362001)(36756003)(38070700009)(38100700002)(5660300002)(478600001)(6506007)(6512007)(71200400001)(966005)(83380400001)(26005)(2616005)(6486002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXlyNmxsbmpxUzduQXlGODJFSVgwYVlSZlRQUXI4WXRNNDN5TWpEQWtSSmZp?= =?utf-8?B?ZE5XNHlFS0FDMWJSUnplVHRkTUFyT2NaU0g0cXlXZ2JhUUR2Y1hEVGozSnoz?= =?utf-8?B?eTFBak45bUpZOXpmMk9MeHY0WTgzYkpIMGdxbi9HS1VEV00xWkNWT1lKS2dY?= =?utf-8?B?M2l1eFNGTHhXZDR3dFdGTnNqaE9PN1kzZHdVRU1oZmhwcEFHemVVSTkzcy8r?= =?utf-8?B?RFpueUYvb2RBOHRNYVNFa0tTbmQ3OEE4NDcyVWhURnl5SzVpWkpZcTZXTFdR?= =?utf-8?B?RWJsSjNkOTJ3bmROL0VrcjVad1ZpREVyeWo5aWgxQlZDbmhMVmwzczNJMVNk?= =?utf-8?B?a20wd0o3RFdzKzErT3B1VVNUMDhxZkRpSGlIWW9XU0U3bG1vUEdVSjc1OXE5?= =?utf-8?B?SENWMzhVK3hMVWl3ZGMzKzRUYVBqb01xWWwrTWVlMTlFeTdmZG9MQjJtVTZN?= =?utf-8?B?QndXOHkyaU4zRW1WVEJEVkU5aHIvNllJeDhuK3VRK2pZd211MnFiUkcxNTVI?= =?utf-8?B?bFRTVzdFNzdMYWFTaDBKWk0rbDBDQVUrT3dGY3F5OFRJQWtIWWJXYzdGcmxo?= =?utf-8?B?WGlvVEMvaUNEMWRQbUlrUU1NOTlYS2QwcCtmL2RKSllsL0ZvWDVDS0FkSkhz?= =?utf-8?B?Ym9JRmp3VGVReG9BRG4zdFZxeWRubk1yWnd5aFNjeGwySUpIck1mSmt5bjBn?= =?utf-8?B?TmNFY2M3Qko3aG1nNzV3RXJpMUdGdHpjTXBkTklsNlRwVkhKVzBUTmNpbWZG?= =?utf-8?B?SXNuV2pwYWxweVN2eGwyaXgwQ3dNOWxzU2VhY3U0WlN2R3ZCZ2hTQ3BaWWJE?= =?utf-8?B?OHREdEZsUUF5RDV4bnprK05NVmhmZ05tVDJTTFpXUElVMEd5cEx2c3RyWjRI?= =?utf-8?B?OXByL3BnSk1pK2pCelFGZzJxdExnckVEa3lsTlNWYVp5MURRMTVnSzc2ay9u?= =?utf-8?B?Sy95UWE2QWtRQzFvRnFHaG5oNUhXSUtCTUluWlJ6Y01QcDZRaWFZZkF4ZzNi?= =?utf-8?B?QmkxRVh1MVNtVnpOeDlXSGpnSGozZjRZa1d5aFRUMDBFV3RXK081ZDhqQzFH?= =?utf-8?B?aUFZOGV3Uy94U0dvMVdhOFZtQStiQTlVQS9kQ0lZckRxMmdiRHNubHZDVkht?= =?utf-8?B?V1dwRkZWZ1hWTVF2K3g4QjdKck1DeXppWVdnRHJkYUZsVVVCWjRGWDFJOXRp?= =?utf-8?B?V1ZsTWNVOUpaNzhRM1Q0czhJcTNnV3NDN2t2cVphRkZRSGhZV2JmbysrNHg4?= =?utf-8?B?YWZxdnBneG1lZ0cweUVCMEhnblJONnBXYzE3S3B5VWkzbWhneStUSzF5Q2x6?= =?utf-8?B?N3ZvN1NKUytWSW42YkpDMmQ1WURJL0c0WEdyMWcya3BIMGxZQjBqYjUyUDE5?= =?utf-8?B?cUxhK29HQ0JxSjh3TllTQ0psdXdYNGp5ZG5oNWpqMVBFUE5vcFEyOFYyRFdn?= =?utf-8?B?MG9ZS3dVWmphT3U1VDJ2TitNc0hadTQ3c2EyK3p0ZkdYVmRmeTU0b25GeXF3?= =?utf-8?B?V0h3UHd6MHA4SE45a0d2NTErNWI4bDZ1YnZuN0pONEFUYi9yTXRMeFJrL082?= =?utf-8?B?b01jUlNwSWNSbnZIZDJXd2NOeU9LSldjd0hxQlc5N0RONllhQ0hYemhvdkt2?= =?utf-8?B?UUlJNWo3YkJJMFlQSHJleFVpZHNmY0pFeEd0NkZ6Q0dmSTQ1V3cyKzVUR2RI?= =?utf-8?B?S0FudkhROVNIOVYxb1Z0eVJMbXYzcDhHY3BxN290TCswOGZGNTVqSlptTjFq?= =?utf-8?B?cnBDQUR0U3Q3WU1BR3lFZ05JMG8xWHM2MStud0FTdG92ZDNsQXQxeUFXOFRM?= =?utf-8?B?Tmw2L0NPenlXTmZEQmdybVlWSkJOVHRVYi9vUXBydU5tbEk5RnY5SEc0N0lB?= =?utf-8?B?VTNjdndlOWxnRzNURE4vK1hwM2F1OE52ZXFzRmJtWm5oQUExL0VrSXZYUGNY?= =?utf-8?B?YSt4U2N5eGxra2JQNjhlc0pXMldrbUxVc25CMmV5NDVXSXZ6bnlITEk0VUdv?= =?utf-8?B?UEYxZ2FHSUg5cERPVnlxQzJLcVEwUGZieDdNZ2Q0UWxDRE0ySFdJRjk0Z3F0?= =?utf-8?B?eHR5a3NSRUhrYmZhU29teEZrSDBpb0Z1K002QWt3QVV1aktGclhUeko5Zkdw?= =?utf-8?B?RGFxK2dteTFjeXpsMmhtNWs0VCs0Rkh2WVVONnVOY1JrRzVVajFVY3QxM1hQ?= =?utf-8?B?UWc9PQ==?= Content-ID: <1C9049958F06434492E4033720D20040@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5034.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe185643-ef10-46bb-0974-08dc028c744b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 01:22:24.9102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H++cN/lQVHO+qAMw0A/F737Pr18E/GROH5c+aSNj5O0lBPLlC8+ZCijfN9fjlfKzziHL0yzCI9sh3E4JR4Nilg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4781 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2023-12-21 at 20:14 +0100, Andreas Rheinhardt wrote: > Wang, Fei W: > > On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: > > > fei.w.wang-at-intel.com@ffmpeg.org: > > > > From: Fei Wang > > > > > > > > Show the unsupported message and return unsupported for clips > > > > contain > > > > tile list OBU since it hasn't been implemented. Otherwise, > > > > decoding > > > > maybe successful but result is incorrect. > > > > > > > > Signed-off-by: Fei Wang > > > > --- > > > > libavcodec/av1dec.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > > > > index 4dcde234c6..629e37c3f8 100644 > > > > --- a/libavcodec/av1dec.c > > > > +++ b/libavcodec/av1dec.c > > > > @@ -805,6 +805,7 @@ static const CodedBitstreamUnitType > > > > decompose_unit_types[] = { > > > > AV1_OBU_SEQUENCE_HEADER, > > > > AV1_OBU_TEMPORAL_DELIMITER, > > > > AV1_OBU_TILE_GROUP, > > > > + AV1_OBU_TILE_LIST, > > > > > > What do you need this for? Decomposing it would only change > > > whether > > > CodedBitstreamUnit.content is available, but you are only reading > > > CodedBitstreamUnit.type. > > > > To show the unsupported error and let user know that there are tile > > list OBUs in bitstream that decoder can't handle them. Otherwise, > > like > > my commit mentioned, tile list obu bitsteam may be decoded > > 'successful' > > according to log. > > > > As I said: You do not need CodedBitstreamUnit.content for the error > message. No, obu will be filtered if it is not listed in decompose, decoder can't receive its type neither. Thanks Fei > > > > > }; > > > > > > > > static av_cold int av1_decode_init(AVCodecContext *avctx) > > > > @@ -1327,6 +1328,10 @@ static int > > > > av1_receive_frame_internal(AVCodecContext *avctx, AVFrame > > > > *frame) > > > > } > > > > break; > > > > case AV1_OBU_TILE_LIST: > > > > + av_log(avctx, AV_LOG_ERROR, "Large scale tile > > > > decoding > > > > is unsupported.\n"); > > > > + ret = AVERROR_PATCHWELCOME; > > > > + goto end; > > > > + break; > > > > case AV1_OBU_TEMPORAL_DELIMITER: > > > > case AV1_OBU_PADDING: > > > > break; > > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".