Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8

From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8
Date: Mon, 23 May 2022 14:11:48 +0300 (EEST)
Message-ID: <517c2dda-35fc-9361-b5ee-9a41826ad931@martin.st> (raw)
In-Reply-To: <DM8P223MB0365BEA0C40B729C2B787864BAD49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>

On Mon, 23 May 2022, Soft Works wrote:

>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Martin
>> Storsjö
>> Sent: Monday, May 23, 2022 12:58 PM
>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8
>>
>> On Mon, 23 May 2022, Soft Works wrote:
>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Martin
>>>> Storsjö
>>>> Sent: Monday, May 23, 2022 12:53 PM
>>>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel@ffmpeg.org>
>>>> Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using
>> av_fopen_utf8
>>>>
>>>> On Sat, 21 May 2022, Soft Works wrote:
>>>>
>>>>> LGTM. (all three)
>>>>>
>>>>> Tested with VS project build (full static linkage, though).
>>>>
>>>> I discussed this with Anton on irc, and he was ok with the patchset
>> too,
>>>> so I pushed it now.
>>>>
>>>> // Martin
>>>
>>> Great, thanks.
>>>
>>> Shall I update mine now to cover the remaining fopen() calls?
>>
>> Yep, that sounds good to me. It should be easier to move forward with the
>> uncontroversial parts of the patchsets now.
>>
>> // Martin
>
> Sure, will do.
>
> I think I have addressed all concerns from the side of nil-admirari;
> the last point was the mapping of the stat() function, which -
> even though it works - could use a few more eyes taking a look at.
>
> Any other specific concerns from your side?

I haven't followed your discussion closely (I was waiting for it to 
converge, which it apparently mostly has) so I haven't got anything to add 
offhand right now. I can try to read through the latest iteration (or the 
next one if rebased and reposted) and give a more qualified opinion in a 
day or two.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".