* [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING @ 2025-06-13 8:56 Jack Lau via ffmpeg-devel 2025-06-21 2:15 ` Jack Lau 0 siblings, 1 reply; 4+ messages in thread From: Jack Lau via ffmpeg-devel @ 2025-06-13 8:56 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Jack Lau [-- Attachment #1: Type: message/rfc822, Size: 4752 bytes --] From: Jack Lau <jacklau1222@qq.com> To: ffmpeg-devel@ffmpeg.org Cc: Jack Lau <jacklau1222@qq.com> Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING Date: Fri, 13 Jun 2025 16:56:03 +0800 Message-ID: <tencent_0016E08BCAC9D3C8CB2C185FD51820948A06@qq.com> Signed-off-by: Jack Lau <jacklau1222@qq.com> --- libavformat/whip.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..a6827d3478 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1885,13 +1885,13 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket } #define OFFSET(x) offsetof(WHIPContext, x) -#define DEC AV_OPT_FLAG_DECODING_PARAM +#define ENC AV_OPT_FLAG_ENCODING_PARAM static const AVOption options[] = { - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, DEC }, - { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, DEC }, - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC }, + { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC }, + { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, + { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, + { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, { NULL }, }; -- 2.49.0 [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING 2025-06-13 8:56 [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING Jack Lau via ffmpeg-devel @ 2025-06-21 2:15 ` Jack Lau 2025-06-21 4:58 ` Zhao Zhili 0 siblings, 1 reply; 4+ messages in thread From: Jack Lau @ 2025-06-21 2:15 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > > > From: Jack Lau <jacklau1222@qq.com> > Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING > Date: June 13, 2025 at 16:56:03 GMT+8 > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau <jacklau1222@qq.com> > > > Signed-off-by: Jack Lau <jacklau1222@qq.com> > --- > libavformat/whip.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 710f24fc5a..a6827d3478 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -1885,13 +1885,13 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket > } > > #define OFFSET(x) offsetof(WHIPContext, x) > -#define DEC AV_OPT_FLAG_DECODING_PARAM > +#define ENC AV_OPT_FLAG_ENCODING_PARAM > static const AVOption options[] = { > - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, DEC }, > - { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, DEC }, > - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, > - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, > - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, > + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC }, > + { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC }, > + { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, > + { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, > + { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, > { NULL }, > }; > > -- > 2.49.0 > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”. PING. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING 2025-06-21 2:15 ` Jack Lau @ 2025-06-21 4:58 ` Zhao Zhili 2025-06-23 14:16 ` Jack Lau 0 siblings, 1 reply; 4+ messages in thread From: Zhao Zhili @ 2025-06-21 4:58 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 21, 2025, at 10:15, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote: > > > >> On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: >> >> >> From: Jack Lau <jacklau1222@qq.com> >> Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING >> Date: June 13, 2025 at 16:56:03 GMT+8 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Jack Lau <jacklau1222@qq.com> >> >> >> Signed-off-by: Jack Lau <jacklau1222@qq.com> >> --- >> libavformat/whip.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/libavformat/whip.c b/libavformat/whip.c >> index 710f24fc5a..a6827d3478 100644 >> --- a/libavformat/whip.c >> +++ b/libavformat/whip.c >> @@ -1885,13 +1885,13 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket >> } >> >> #define OFFSET(x) offsetof(WHIPContext, x) >> -#define DEC AV_OPT_FLAG_DECODING_PARAM >> +#define ENC AV_OPT_FLAG_ENCODING_PARAM >> static const AVOption options[] = { >> - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, DEC }, >> - { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, DEC }, >> - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >> - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >> - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >> + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC }, >> + { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC }, >> + { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >> + { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >> + { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >> { NULL }, >> }; >> >> -- >> 2.49.0 >> >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”. > PING. Applied, thanks. > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING 2025-06-21 4:58 ` Zhao Zhili @ 2025-06-23 14:16 ` Jack Lau 0 siblings, 0 replies; 4+ messages in thread From: Jack Lau @ 2025-06-23 14:16 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 21, 2025, at 12:58, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote: > > > >> On Jun 21, 2025, at 10:15, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote: >> >> >> >>> On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: >>> >>> >>> From: Jack Lau <jacklau1222@qq.com> >>> Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING >>> Date: June 13, 2025 at 16:56:03 GMT+8 >>> To: ffmpeg-devel@ffmpeg.org >>> Cc: Jack Lau <jacklau1222@qq.com> >>> >>> >>> Signed-off-by: Jack Lau <jacklau1222@qq.com> >>> --- >>> libavformat/whip.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/libavformat/whip.c b/libavformat/whip.c >>> index 710f24fc5a..a6827d3478 100644 >>> --- a/libavformat/whip.c >>> +++ b/libavformat/whip.c >>> @@ -1885,13 +1885,13 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket >>> } >>> >>> #define OFFSET(x) offsetof(WHIPContext, x) >>> -#define DEC AV_OPT_FLAG_DECODING_PARAM >>> +#define ENC AV_OPT_FLAG_ENCODING_PARAM >>> static const AVOption options[] = { >>> - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, DEC }, >>> - { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, DEC }, >>> - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >>> - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >>> - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, DEC }, >>> + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC }, >>> + { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC }, >>> + { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >>> + { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >>> + { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, >>> { NULL }, >>> }; >>> >>> -- >>> 2.49.0 >>> >>> >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”. >> PING. > > Applied, thanks. > >> >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”. There’re two other patches in this patchset https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14768 , Could you help merge these please? I want to submit WHIP NACK patch that depends on these patches. Best regards Jack _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-23 14:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-06-13 8:56 [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING Jack Lau via ffmpeg-devel 2025-06-21 2:15 ` Jack Lau 2025-06-21 4:58 ` Zhao Zhili 2025-06-23 14:16 ` Jack Lau
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git