From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 091634024F for ; Mon, 21 Feb 2022 01:54:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3005268B0B8; Mon, 21 Feb 2022 03:54:01 +0200 (EET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8887C68AF91 for ; Mon, 21 Feb 2022 03:53:54 +0200 (EET) Received: by mail-ot1-f43.google.com with SMTP id s1-20020a056830148100b005acfdcb1f4bso6404175otq.4 for ; Sun, 20 Feb 2022 17:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=SuB8M0bnIOLlpQMqibwlyiu7cjcm99Da5X3a9o2aGOA=; b=px6yEsG1si4pU/cJiDTNZdX2oHrywSxNOC0yUCoY9MDF62QWCvN2WmawiMh/4LqrPp 3CrqJnuTvE7eRP+5Y7aGuvPEpgCrhc27C7OPPzaay4MUTCLbIZXShu8z4Aj8ypni0g5V MoJnV6AX6uKGIGaF/G6O+HFBqYt723Q0GIDDx+eS6/58ECblzwWMHfDKcauhO6J2yRfi mBj7DM4nkOzqCkVL7kvKYu3GUTarSxg3CpE9TE9mJyP5hGlzggstQF/tGLgtCDS8ACwg H5aZy7sRnNZhG/nvgqngaeATOKXg1IUtgXzaRwEo7rEuRjGwH4wk/kJIB9K9KcvoyYpA AN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=SuB8M0bnIOLlpQMqibwlyiu7cjcm99Da5X3a9o2aGOA=; b=JaXsqroknBBI5RGxZMDuj8O9JfYDl8i7f9PvT98VcHTrK2cTQzIMRzfokhnFw0ZLnc oUjjSg0ARB9vj+EeUqKQYKc2U87DLh2qxwHJ2Lm0RQlhzwXkFBWemo3zgjywcL5CvpPG JZInIKIBKG+Qrx34v3tvIDzQVTksQZRiDVsYXR3fD9ipAGHtuxNHERO8bJOIta2Y/zI6 bngFY5K4oiyknGTjs8mvwbZ6F3CFGdKmPW7LxizQ4TccoRbyVnaGfaj6NsIHLeDe0mwo 9evJD8jhQ8hBe3dmIjUOfA7FdGXkqqB+UgRa23uMUg+S2WPim0Hsudw7HVJ3KK8W4dv/ MXdA== X-Gm-Message-State: AOAM532Yaxf4pm47MLiTIfpY/VbnoU1WvSM8/i8tngPyeXH5YJsztJnF 4BdrW1htd/+/RAGYE9MOKIdm9IhJW/2Rcw== X-Google-Smtp-Source: ABdhPJwkGqHXDyKQcPgq2Ac7xvVr84wHPiafsT3LxiqNbd77XtddwNYFx5V4GWXnd5+1OmCyzAnwYA== X-Received: by 2002:a9d:1f7:0:b0:5ad:2f15:7b94 with SMTP id e110-20020a9d01f7000000b005ad2f157b94mr4801049ote.264.1645408432513; Sun, 20 Feb 2022 17:53:52 -0800 (PST) Received: from [192.168.0.11] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id t192sm6382989oie.14.2022.02.20.17.53.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 17:53:52 -0800 (PST) Message-ID: <51258010-516b-ca27-4dba-3f05506ea5b3@gmail.com> Date: Sun, 20 Feb 2022 22:53:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220220220242.401901-1-onemda@gmail.com> From: James Almer In-Reply-To: <20220220220242.401901-1-onemda@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/20/2022 7:02 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/audio.c | 11 +++++------ > libavfilter/framepool.c | 16 ++++++---------- > libavfilter/video.c | 11 +++++------ > 3 files changed, 16 insertions(+), 22 deletions(-) > > diff --git a/libavfilter/audio.c b/libavfilter/audio.c > index cebc9709dd..a0408226a3 100644 > --- a/libavfilter/audio.c > +++ b/libavfilter/audio.c > @@ -22,15 +22,13 @@ > #include "libavutil/avassert.h" > #include "libavutil/channel_layout.h" > #include "libavutil/common.h" > +#include "libavutil/cpu.h" > > #include "audio.h" > #include "avfilter.h" > #include "framepool.h" > #include "internal.h" > > -#define BUFFER_ALIGN 0 > - > - > AVFrame *ff_null_get_audio_buffer(AVFilterLink *link, int nb_samples) > { > return ff_get_audio_buffer(link->dst->outputs[0], nb_samples); > @@ -41,12 +39,13 @@ AVFrame *ff_default_get_audio_buffer(AVFilterLink *link, int nb_samples) > AVFrame *frame = NULL; > int channels = link->channels; > int channel_layout_nb_channels = av_get_channel_layout_nb_channels(link->channel_layout); > + int align = av_cpu_max_align(); > > av_assert0(channels == channel_layout_nb_channels || !channel_layout_nb_channels); > > if (!link->frame_pool) { > link->frame_pool = ff_frame_pool_audio_init(av_buffer_allocz, channels, > - nb_samples, link->format, BUFFER_ALIGN); > + nb_samples, link->format, align); > if (!link->frame_pool) > return NULL; > } else { > @@ -62,11 +61,11 @@ AVFrame *ff_default_get_audio_buffer(AVFilterLink *link, int nb_samples) > } > > if (pool_channels != channels || pool_nb_samples < nb_samples || > - pool_format != link->format || pool_align != BUFFER_ALIGN) { > + pool_format != link->format || pool_align != align) { > > ff_frame_pool_uninit((FFFramePool **)&link->frame_pool); > link->frame_pool = ff_frame_pool_audio_init(av_buffer_allocz, channels, > - nb_samples, link->format, BUFFER_ALIGN); > + nb_samples, link->format, align); > if (!link->frame_pool) > return NULL; > } > diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c > index 7c63807df3..ebfd5dc0e0 100644 > --- a/libavfilter/framepool.c > +++ b/libavfilter/framepool.c > @@ -76,14 +76,10 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size), > } > > if (!pool->linesize[0]) { > - for(i = 1; i <= align; i += i) { > - ret = av_image_fill_linesizes(pool->linesize, pool->format, > - FFALIGN(pool->width, i)); > - if (ret < 0) { > - goto fail; > - } > - if (!(pool->linesize[0] & (pool->align - 1))) > - break; > + ret = av_image_fill_linesizes(pool->linesize, pool->format, > + FFALIGN(pool->width, align)); > + if (ret < 0) { > + goto fail; > } > > for (i = 0; i < 4 && pool->linesize[i]; i++) { > @@ -92,11 +88,11 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size), > } > > for (i = 0; i < 4 && pool->linesize[i]; i++) { > - int h = FFALIGN(pool->height, 32); > + int h = pool->height; > if (i == 1 || i == 2) > h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h); > > - pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + 16 + 16 - 1, > + pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h, Why are you removing the padding on each plane? Just add align padding bytes and it should be good. > alloc); > if (!pool->pools[i]) > goto fail; > diff --git a/libavfilter/video.c b/libavfilter/video.c > index 7ef04144e4..fa3d588044 100644 > --- a/libavfilter/video.c > +++ b/libavfilter/video.c > @@ -24,6 +24,7 @@ > #include > > #include "libavutil/buffer.h" > +#include "libavutil/cpu.h" > #include "libavutil/hwcontext.h" > #include "libavutil/imgutils.h" > > @@ -32,9 +33,6 @@ > #include "internal.h" > #include "video.h" > > -#define BUFFER_ALIGN 32 > - > - > AVFrame *ff_null_get_video_buffer(AVFilterLink *link, int w, int h) > { > return ff_get_video_buffer(link->dst->outputs[0], w, h); > @@ -46,6 +44,7 @@ AVFrame *ff_default_get_video_buffer(AVFilterLink *link, int w, int h) > int pool_width = 0; > int pool_height = 0; > int pool_align = 0; > + int align = av_cpu_max_align(); > enum AVPixelFormat pool_format = AV_PIX_FMT_NONE; > > if (link->hw_frames_ctx && > @@ -65,7 +64,7 @@ AVFrame *ff_default_get_video_buffer(AVFilterLink *link, int w, int h) > > if (!link->frame_pool) { > link->frame_pool = ff_frame_pool_video_init(av_buffer_allocz, w, h, > - link->format, BUFFER_ALIGN); > + link->format, align); > if (!link->frame_pool) > return NULL; > } else { > @@ -76,11 +75,11 @@ AVFrame *ff_default_get_video_buffer(AVFilterLink *link, int w, int h) > } > > if (pool_width != w || pool_height != h || > - pool_format != link->format || pool_align != BUFFER_ALIGN) { > + pool_format != link->format || pool_align != align) { > > ff_frame_pool_uninit((FFFramePool **)&link->frame_pool); > link->frame_pool = ff_frame_pool_video_init(av_buffer_allocz, w, h, > - link->format, BUFFER_ALIGN); > + link->format, align); > if (!link->frame_pool) > return NULL; > } _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".