[FFmpeg-devel] [aac] Don't attempt to parse ADTS from USAC packets.

[FFmpeg-devel] [aac] Don't attempt to parse ADTS from USAC packets.

[Dale Curtis]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

It's not possible to put USAC into ADTS due to exceeding the
field size (4 bits) for ADTS profile. As such cases where
the frame starts with 0xfff shouldn't be checked.

This ensures the sample at https://crbug.com/396190942 is
properly detected as USAC content.

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>

[-- Attachment #2: usac_v0.patch --]
[-- Type: application/octet-stream, Size: 1317 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [aac] Don't attempt to parse ADTS from USAC packets.

[Dale Curtis]

Any comments for this one?

- dale

On Tue, Feb 25, 2025 at 12:16 PM Dale Curtis <dalecurtis@chromium.org>
wrote:

> It's not possible to put USAC into ADTS due to exceeding the
> field size (4 bits) for ADTS profile. As such cases where
> the frame starts with 0xfff shouldn't be checked.
>
> This ensures the sample at https://crbug.com/396190942 is
> properly detected as USAC content.
>
> Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [aac] Don't attempt to parse ADTS from USAC packets.

[Lynne]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 589 bytes --]

On 06/03/2025 00:25, Dale Curtis wrote:
> Any comments for this one?
> 
> - dale
> 
> On Tue, Feb 25, 2025 at 12:16 PM Dale Curtis <dalecurtis@chromium.org>
> wrote:
> 
>> It's not possible to put USAC into ADTS due to exceeding the
>> field size (4 bits) for ADTS profile. As such cases where
>> the frame starts with 0xfff shouldn't be checked.
>>
>> This ensures the sample at https://crbug.com/396190942 is
>> properly detected as USAC content.
>>
>> Signed-off-by: Dale Curtis <dalecurtis@chromium.org>

Pushed, thanks for sending it.
Did not notice it was sent.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".