From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E9DE43277 for ; Fri, 23 Dec 2022 07:14:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABF2168B8F2; Fri, 23 Dec 2022 09:14:14 +0200 (EET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D993E68AF35 for ; Fri, 23 Dec 2022 09:14:07 +0200 (EET) Received: from kwepemm600007.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Nddg621bkzRq3x for ; Fri, 23 Dec 2022 15:12:50 +0800 (CST) Received: from kwepemi500014.china.huawei.com (7.221.188.232) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 23 Dec 2022 15:14:04 +0800 Received: from kwepemi500014.china.huawei.com ([7.221.188.232]) by kwepemi500014.china.huawei.com ([7.221.188.232]) with mapi id 15.01.2375.034; Fri, 23 Dec 2022 15:14:04 +0800 From: "Wujian(Chin)" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*) Thread-Index: AdkVJGWdoWk3SK1uRBeLFSi2TaoyFAA1BIuAACkm/qA= Date: Fri, 23 Dec 2022 07:14:03 +0000 Message-ID: <50c8043b13fb48028c5cbd8535e86fff@huawei.com> References: <2f52afe919284d9a872738dd68ab886f@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.136.102.143] MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: [FFmpeg-devel] =?gb2312?b?tPC4tDogIFtQQVRDSF0gZmZ0b29scy9mZm1w?= =?gb2312?b?ZWdfZmZwbGF5X2ZmcHJvYmVfY21kdXRpbHM6YWRkIC1tYXNrX3VybCB0byBy?= =?gb2312?b?ZXBsYWNlIHRoZSBwcm90b2NvbCBhZGRyZXNzIGluIHRoZSBjb21tYW5kIHdp?= =?gb2312?b?dGggdGhlIGFzdGVyaXNrICgqKQ==?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "wangqinghua \(I\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Wujian(Chin) (12022-12-21): >> I have modified the issues again. Please review it again. Thank you. >> >> If the protocol address contains the user name and password, the ps >> -ef command exposes plaintext. The -mask_url parameter option is added >> to replace the protocol address in the command line with the asterisk (*). >> Because other users can run the ps -ef command to view sensitive >> information such as the user name and password in the protocol >> address, which is insecure. >> >> Signed-off-by: wujian_nanjing >> --- >> doc/fftools-common-opts.texi | 11 +++++++ >> fftools/cmdutils.c | 75 ++++++++++++++++++++++++++++++++++++++++++-- >> fftools/cmdutils.h | 25 +++++++++++++++ >> fftools/ffmpeg.c | 10 +++--- >> fftools/ffplay.c | 9 ++++-- >> fftools/ffprobe.c | 10 +++--- >> 6 files changed, 126 insertions(+), 14 deletions(-) >This new patch still has issues not addressed since the first review. >Regards, -- > Nicolas George I've modified most of the issues, and I've explained some of the issues that don't. If you don't accept my explanation, do you have any other better suggestions and methods? Thank you. _______________________________________________ ffmpeg-user mailing list ffmpeg-user@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-user To unsubscribe, visit link above, or email ffmpeg-user-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".