Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Wujian(Chin)" <wujian2@huawei.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "wangqinghua \(I\)" <wangqinghua9@huawei.com>
Subject: [FFmpeg-devel] 答复:  [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)
Date: Fri, 23 Dec 2022 07:14:03 +0000
Message-ID: <50c8043b13fb48028c5cbd8535e86fff@huawei.com> (raw)
In-Reply-To: <Y6SvyRqmIWhMQLBl@phare.normalesup.org>


>Wujian(Chin) (12022-12-21):
>> I have modified the issues again. Please review it again. Thank you.
>> 
>> If the protocol address contains the user name and password, the ps 
>> -ef command exposes plaintext. The -mask_url parameter option is added 
>> to replace the protocol address in the command line with the asterisk (*).
>> Because other users can run the ps -ef command to view sensitive 
>> information such as the user name and password in the protocol 
>> address, which is insecure.
>> 
>> Signed-off-by: wujian_nanjing <wujian2@huawei.com>
>> ---
>>  doc/fftools-common-opts.texi | 11 +++++++
>>  fftools/cmdutils.c           | 75 ++++++++++++++++++++++++++++++++++++++++++--
>>  fftools/cmdutils.h           | 25 +++++++++++++++
>>  fftools/ffmpeg.c             | 10 +++---
>>  fftools/ffplay.c             |  9 ++++--
>>  fftools/ffprobe.c            | 10 +++---
>>  6 files changed, 126 insertions(+), 14 deletions(-)

>This new patch still has issues not addressed since the first review.

>Regards,

--
>  Nicolas George

I've modified most of the issues, and I've explained some of the issues that don't.
If you don't accept my explanation, do you have any other better suggestions and methods?

Thank you.

_______________________________________________
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email ffmpeg-user-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-12-23  7:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 10:10 [FFmpeg-devel] " Wujian(Chin)
2022-12-22 19:28 ` Nicolas George
2022-12-23  7:14   ` Wujian(Chin) [this message]
2022-12-23  9:13     ` [FFmpeg-devel] 答复: " Nicolas George
2022-12-23 11:04       ` [FFmpeg-devel] 答复: " Wujian(Chin)
2022-12-23 11:06         ` Nicolas George
  -- strict thread matches above, loose matches on Subject: below --
2023-01-03 11:05 [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add " Wujian(Chin)
2023-01-03 12:31 ` Nicolas George
2022-12-26 13:07 Wujian(Chin)
2022-12-26 13:21 ` Nicolas George
2022-12-27 19:49 ` Michael Niedermayer
2022-12-28  3:20   ` [FFmpeg-devel] 答复: " Wujian(Chin)
2022-12-28  8:04   ` Wujian(Chin)
2022-12-19 13:15 [FFmpeg-devel] " Wujian(Chin)
2022-12-19 13:30 ` Nicolas George
2022-12-19 13:37   ` Gyan Doshi
2022-12-19 13:44     ` Nicolas George
2022-12-20 11:42   ` [FFmpeg-devel] 答复: " Wujian(Chin)
2022-12-22 19:27     ` Nicolas George
2022-12-24  8:51       ` [FFmpeg-devel] 答复: " Wujian(Chin)
2022-12-24  8:59         ` Nicolas George
2022-12-19 13:33 ` [FFmpeg-devel] " Marvin Scholz
2022-12-19 13:37   ` Nicolas George
2022-12-19 13:40     ` Marvin Scholz
2022-12-19 13:45       ` Nicolas George
2022-12-20 11:56         ` [FFmpeg-devel] 答复: " Wujian(Chin)
2022-12-19 14:51       ` [FFmpeg-devel] " "zhilizhao(赵志立)"
2022-12-22 23:14         ` Marton Balint

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50c8043b13fb48028c5cbd8535e86fff@huawei.com \
    --to=wujian2@huawei.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=wangqinghua9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git