From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D0B814DE37 for ; Thu, 5 Jun 2025 07:02:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B445C68C970; Thu, 5 Jun 2025 10:02:15 +0300 (EEST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5E1A168C81A for ; Thu, 5 Jun 2025 10:02:09 +0300 (EEST) Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-32a7a5ab797so5258111fa.1 for ; Thu, 05 Jun 2025 00:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1749106928; x=1749711728; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=IMUB5LfbapLgmc7ApNQrf/mPn3CeRhRsk8RYH/eopmQ=; b=BZ2ThPsE6hyTeX8gZdVgz1LHSoUoJ8Sx4NfB7nM7jRZoPElw4zxeKWokqq9UgYb14F /8k4N8wctPnx6jCe3ymPMh/wsOBEjQpu/fQmVrNyiGaBdxdAuTszGCAmz4rQ2fHsXlWo t1ovZynqK7U4eT2Ga3JIzD6G++RDX6aiULE55m7xfOFzdABP48mFJL7QhvYc/vrHMNMI cVPwqNNP1cbr9R9gD5TW+3vFSsXS5txCs3t3y3ismH0TgGIMGHoQ7VK+/KhUUNAhzYeh xiLocUK34LDXb9PZxqQY9upTepB2cUepRWJwDTIXbcUInHNFZ8g7mt6U7WAShYrERQU0 Hf3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749106928; x=1749711728; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IMUB5LfbapLgmc7ApNQrf/mPn3CeRhRsk8RYH/eopmQ=; b=IA91jc3EJCpR/vxdnfBTWkEgH/ypEkp84mnJCy5iwgx9dJFDGll5AcXRruhZNnj7ek EiVsEuUZu71M7bW4RQLVXjZE0CDa49bauGd+8VfDc9KK1xqJx0lk+XTWvPrUKguz2XjT WcDQpWUxEzGwiiHWNq40S0oK3mpfAPntTIiii25cMXw0ZuPCiH3uG1OsSLZ0FY6IFSzn vzbcF26JcdpZwEQGLSmJmRuNiWmcQI8fztfl9Z7h0a99S7T23v1T8dI3UlNGoyKSLxoG HpziiZPU5b/YUK+3FfmenxN6VSVSihtkXGkDxprHxPKxuqiGx8gskRw5EdQPnTINnle5 Rc+Q== X-Gm-Message-State: AOJu0YxB/6gHqObKxd0PZTIhJucFHWqtVMdgBaUqmp/A/qhCwU4kcxx9 O2BrG7BlbPp1lMGqZH7kCnQ/jCBszn9vntHOO26fhz99vkZwqgBesUEpOSId7moiBnVyeunCZcp lHYMRMJEO X-Gm-Gg: ASbGncv7kO3TdqA35y5NQLajygaPPr9SSazPeqs8ErqrQyIAg5eac3vd5NNiEOtmWbt ZjhQpEB43XEL5r4xRSLiOH/vwSKvo8aoAdLqJ9Go0nOsV28k5k8uNaZy2OreIwKOHatlOWHzPv6 5qq378S2Hb3SAvZtvYlMMXwg8WShhE3gNNLplgcpr7psTM+K1MpdtMou4unKEAJViihGgtiYSwA 7XJG1RKSKXiWhEw2cB67bxzXzoggLnq8OWBT86kg0NvABWmufdOLuiSnkSH8JEFJNR9Z8elQxGH ihaDx0dq67C2wFnvN7845DWvP13n4xeI2exlqYELHB3SZRXs6GiZJkMlRecGgb0zAdP/QdmzqXV FqvBkMS/pvvAGP0KR3Ik6nbuM74pm4mDlO/tBGxUPyDekOpM= X-Google-Smtp-Source: AGHT+IH8QlxvstdMZCRgANkQs6GBYYmOvH3FIajfB6qL9d06bCyjrAU2MAVjXqP93I1c95p0TTzkAw== X-Received: by 2002:a05:651c:549:b0:32a:66f7:8a0d with SMTP id 38308e7fff4ca-32ac72ab2d8mr19225571fa.32.1749106927545; Thu, 05 Jun 2025 00:02:07 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32a85b1a7a0sm23832961fa.4.2025.06.05.00.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 00:02:07 -0700 (PDT) Date: Thu, 5 Jun 2025 10:02:04 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Jack Lau via ffmpeg-devel In-Reply-To: Message-ID: <509bb41c-77b7-563-84b8-73f9459a88@martin.st> References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix build error when openssl version < 3 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jack Lau Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 5 Jun 2025, Jack Lau via ffmpeg-devel wrote: > fix the missing data structure pkey in the tls_context > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-) Thanks, this does fix the build break. However, I don't quite understand the fix... > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index b589d5d90a..bddeee9af8 100644 > --- a/libavformat/tls_openssl.c > +++ b/libavformat/tls_openssl.c > @@ -467,6 +467,7 @@ typedef struct TLSContext { > TLSShared tls_shared; > SSL_CTX *ctx; > SSL *ssl; > + EVP_PKEY *pkey; > #if OPENSSL_VERSION_NUMBER >= 0x1010000fL > BIO_METHOD* url_bio_method; > #endif As far as I can see, nothing ever sets this new field, it is only used in a couple of places? // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".