From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B69694C1E0 for ; Tue, 23 Jul 2024 10:42:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF8E968D50D; Tue, 23 Jul 2024 13:42:33 +0300 (EEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8E0B268D076 for ; Tue, 23 Jul 2024 13:42:27 +0300 (EEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a77d85f7fa3so114297366b.0 for ; Tue, 23 Jul 2024 03:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721731347; x=1722336147; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IjGMqUq39fSAuDM1xd7XbYjRoQ3vhNV6l7KpvqUjNOQ=; b=SA5EVRsxLFLRuq9Zf+u4FsWLpzhbrWwUd5xoDXHc32lRUujfls7a2y1eOyNenEoOFP h+LMzOQBuXyG0yNaldoyJcYe1XgUAVjg5Q6VlaNt6GpWiCA2kOe/1OIpP3nw/5xDofZ3 Dfmd7u5fswLJSh0Afl7pX6yyixCaMsNfFmDKXImK35j7PJHyE5n55OrpAaB960s4KTOo CPotK+XE8VM/FZvgENkW2GF6hsId21coVToLnx0yUGE8GD0wDV5xy8eO88yU5FVgXrtf HvmPratC498OA2xNr2YAOvtGNOL/Cj5GLlQbDUpmzRfasndFbdabIs6Lkd1JvFZN4LgA NzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721731347; x=1722336147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IjGMqUq39fSAuDM1xd7XbYjRoQ3vhNV6l7KpvqUjNOQ=; b=l8ubEmpP+Um3kgu6SFcO5X34r3xgbAKKCZj8+qnJdcbnwmPZOEULY/UQ/QZ2SKuTik BqXEdUNa/iPVKMx/kh09Ux9tJXX3fTqOz/GZ2zvWq5pHGBl/PPXITuJwTeRJwIpbCkIR +vTcQ4Ba+KHlW8dKjtPTAXS9yxZwmGY3inKawlUqk0bJ+/7/5dJqL+LcvkhG62N1C2q2 ZkgozW7lMucH/5CHCGhiKIR/zgN6sHv50kV7q0E9pYOU0YUaK4BxA+kHt3Mst+flhZ2A dLC73w+DiXA9TJap5P+UyEPT8+pjOYv/CbNbULX9OFZVsQePCtlVcsXwQ8xSi9UuXPwQ m6rg== X-Gm-Message-State: AOJu0YzHYF8KYde4XM9GmOemar5OltKZO5+D+7wtBJCgLfm9GpafHQSu RBSYwmzshT8vFqMCvba9NGyDG+1w7UusFBV/B/lhxoxBbtoXT8JI0h/vVwRo X-Google-Smtp-Source: AGHT+IHOo/PwRlTIu/545cj8b0UuAtwLyQeY4Eo1Vnom9MN/jL1xBxR0wK3BCDX4gH4J8E42Tijx2g== X-Received: by 2002:a17:907:7282:b0:a7a:8a46:f613 with SMTP id a640c23a62f3a-a7a9435e5bcmr157745466b.26.1721731346575; Tue, 23 Jul 2024 03:42:26 -0700 (PDT) Received: from [10.0.3.6] ([213.235.133.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a92241d47sm70554266b.219.2024.07.23.03.42.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jul 2024 03:42:25 -0700 (PDT) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Tue, 23 Jul 2024 12:42:15 +0200 X-Mailer: MailMate (1.14r6022) Message-ID: <5021EDF3-6A1E-456F-AB66-69D921FB93CD@gmail.com> In-Reply-To: <20240723073720.28871-1-anton@khirnov.net> References: <20240723073720.28871-1-anton@khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: drop HEVC cropping from start_frame rather than end_frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23 Jul 2024, at 9:36, Anton Khirnov wrote: > HEVCContext.output_frame will be removed in following commits. > > Reported-By: Max Bykov > --- > Untested, testing welcome. Tested with fate-hevc-conformance-CONFWIN_A_Sony_1 and works. LGTM > > Cf. '[PATCH 37/39] lavc/hevcdec: use a ContainerFifo to hold frames > scheduled for output' currently on ML. > --- > libavcodec/videotoolbox.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 3dd804bb0c..505483ef66 100644 > --- a/libavcodec/videotoolbox.c > +++ b/libavcodec/videotoolbox.c > @@ -1053,6 +1053,14 @@ static int videotoolbox_hevc_start_frame(AVCodecContext *avctx, > const uint8_t *buffer, > uint32_t size) > { > + HEVCContext *h = avctx->priv_data; > + AVFrame *frame = h->cur_frame->f; > + > + frame->crop_right = 0; > + frame->crop_left = 0; > + frame->crop_top = 0; > + frame->crop_bottom = 0; > + > return 0; > } > > @@ -1079,11 +1087,6 @@ static int videotoolbox_hevc_end_frame(AVCodecContext *avctx) > VTContext *vtctx = avctx->internal->hwaccel_priv_data; > int ret; > > - h->output_frame->crop_right = 0; > - h->output_frame->crop_left = 0; > - h->output_frame->crop_top = 0; > - h->output_frame->crop_bottom = 0; > - > ret = ff_videotoolbox_common_end_frame(avctx, frame); > vtctx->bitstream_size = 0; > return ret; > -- > 2.43.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".