Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros
Date: Sat, 28 Jun 2025 14:48:15 +0300
Message-ID: <5019004.31r3eYUQgx@basile.remlab.net> (raw)
In-Reply-To: <20250607232905.GK29660@pb2>

Le sunnuntai 8. kesäkuuta 2025, 2.29.05 Itä-Euroopan kesäaika Michael 
Niedermayer a écrit :
> Hi
> 
> On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote:
> [...]
> 
> > > >  #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a=
> > > >  SWAP_tmp;}while(0)
> > > 
> > > 1. I don't like that you change the common case (namely the integer one)
> > > and thereby making the name longer (and making this patch huge).
> > 
> > I can just rename FFMINI/MAXI to FFMIN/MAX if preferred
> 
> are there any objections to FFMIND / FFMINF / FFMAXD / FFMAXF ?
> if not i intend to apply these in the next days (unless i forget)

Sorry for the delay. If the new macros are to be internal anyway, we could use 
_Generic to have a single version for all floating point types rather than 
distinguish single and double, and risk accidentally down- or up-converting.

In any case, thanks for working on this.

-- 
Rémi Denis-Courmont
Tapio's place new town, former Finnish Republic of Uusimaa

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".