From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B33EB4540F for ; Tue, 28 Feb 2023 11:40:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 091ED68A867; Tue, 28 Feb 2023 13:40:17 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B719C680CAE for ; Tue, 28 Feb 2023 13:40:10 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 31SBe9Et003413-31SBe9Eu003413; Tue, 28 Feb 2023 13:40:09 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id E21A3A143A; Tue, 28 Feb 2023 13:40:09 +0200 (EET) Date: Tue, 28 Feb 2023 13:40:09 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <4f57e3d9-613c-7147-ef85-9fae931b2866@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add epel_put_pixels which same as qpel in arm X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: xufuji456 <839789740@qq.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 26 Feb 2023, xufuji456 wrote: > --- > libavcodec/arm/hevcdsp_init_neon.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c > index 8094e6c62e..4063acaf51 100644 > --- a/libavcodec/arm/hevcdsp_init_neon.c > +++ b/libavcodec/arm/hevcdsp_init_neon.c > @@ -119,7 +119,7 @@ QPEL_FUNC(ff_hevc_put_qpel_h3v3_neon_8); > > #define QPEL_FUNC_UW_PIX(name) \ > void name(uint8_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t _srcstride, \ > - int height, intptr_t mx, intptr_t my, int width); > + int height, intptr_t mx, intptr_t my, int width) > QPEL_FUNC_UW_PIX(ff_hevc_put_qpel_uw_pixels_w4_neon_8); > QPEL_FUNC_UW_PIX(ff_hevc_put_qpel_uw_pixels_w8_neon_8); > QPEL_FUNC_UW_PIX(ff_hevc_put_qpel_uw_pixels_w16_neon_8); > @@ -131,7 +131,7 @@ QPEL_FUNC_UW_PIX(ff_hevc_put_qpel_uw_pixels_w64_neon_8); > > #define QPEL_FUNC_UW(name) \ > void name(uint8_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t _srcstride, \ > - int width, int height, const int16_t* src2, ptrdiff_t src2stride); > + int width, int height, const int16_t* src2, ptrdiff_t src2stride) These changes look like cosmetic changes unrelated to the rest; please split such changes to a separate patch. > QPEL_FUNC_UW(ff_hevc_put_qpel_uw_pixels_neon_8); > QPEL_FUNC_UW(ff_hevc_put_qpel_uw_v1_neon_8); > QPEL_FUNC_UW(ff_hevc_put_qpel_uw_v2_neon_8); > @@ -293,6 +293,17 @@ av_cold void ff_hevc_dsp_init_neon(HEVCDSPContext *c, const int bit_depth) > c->put_hevc_qpel[8][0][0] = ff_hevc_put_pixels_w48_neon_8; > c->put_hevc_qpel[9][0][0] = ff_hevc_put_pixels_w64_neon_8; > > + c->put_hevc_epel[0][0][0] = ff_hevc_put_pixels_w2_neon_8; > + c->put_hevc_epel[1][0][0] = ff_hevc_put_pixels_w4_neon_8; > + c->put_hevc_epel[2][0][0] = ff_hevc_put_pixels_w6_neon_8; > + c->put_hevc_epel[3][0][0] = ff_hevc_put_pixels_w8_neon_8; > + c->put_hevc_epel[4][0][0] = ff_hevc_put_pixels_w12_neon_8; > + c->put_hevc_epel[5][0][0] = ff_hevc_put_pixels_w16_neon_8; > + c->put_hevc_epel[6][0][0] = ff_hevc_put_pixels_w24_neon_8; > + c->put_hevc_epel[7][0][0] = ff_hevc_put_pixels_w32_neon_8; > + c->put_hevc_epel[8][0][0] = ff_hevc_put_pixels_w48_neon_8; > + c->put_hevc_epel[9][0][0] = ff_hevc_put_pixels_w64_neon_8; > + > c->put_hevc_qpel_uni[1][0][0] = ff_hevc_put_qpel_uw_pixels_w4_neon_8; > c->put_hevc_qpel_uni[3][0][0] = ff_hevc_put_qpel_uw_pixels_w8_neon_8; > c->put_hevc_qpel_uni[5][0][0] = ff_hevc_put_qpel_uw_pixels_w16_neon_8; > @@ -300,6 +311,12 @@ av_cold void ff_hevc_dsp_init_neon(HEVCDSPContext *c, const int bit_depth) > c->put_hevc_qpel_uni[7][0][0] = ff_hevc_put_qpel_uw_pixels_w32_neon_8; > c->put_hevc_qpel_uni[8][0][0] = ff_hevc_put_qpel_uw_pixels_w48_neon_8; > c->put_hevc_qpel_uni[9][0][0] = ff_hevc_put_qpel_uw_pixels_w64_neon_8; > + > + c->put_hevc_epel_uni[1][0][0] = ff_hevc_put_qpel_uw_pixels_w4_neon_8; > + c->put_hevc_epel_uni[3][0][0] = ff_hevc_put_qpel_uw_pixels_w8_neon_8; > + c->put_hevc_epel_uni[5][0][0] = ff_hevc_put_qpel_uw_pixels_w16_neon_8; > + c->put_hevc_epel_uni[6][0][0] = ff_hevc_put_qpel_uw_pixels_w24_neon_8; > + c->put_hevc_epel_uni[7][0][0] = ff_hevc_put_qpel_uw_pixels_w32_neon_8; > } This change breaks "make fate-hevc" and can't be applied. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".