From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1ADE94087E for ; Thu, 1 Dec 2022 01:55:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8181B68B155; Thu, 1 Dec 2022 03:55:39 +0200 (EET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CB77689BEF for ; Thu, 1 Dec 2022 03:55:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669859737; x=1701395737; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=9Y9HoH6xuA16hjuaQQzk2uNDQC5yyu4UPkiw0ZfizJs=; b=O+MUBUXzwuEwOgRsxSVyyfXW+2XYzD8gWRTehZPPkTAUGERa3xDlMKYN OKG9NFZQkWu8gBdyw2TUGAAUul13ckB+kXSv/FhwfnStczHqC4tYnBiel YtHKXplJ7K3Gprif+tTYApo3o8WKRKVR5bARNBF4N4Vu/XuBPJyQCmPsa yMVhFPnMrqNGtqTMmGIk9Ew4AKLNXueWjwJxNZ7hpVz6+H+TBF8KtTFaO Gff0MiF7If6Hn8hOvsLUgi5qxCyDHMP42ut9SooV66qJG33+C1rIrZGhx eYxvMpsR6OwIF9hJwSUecQot5pyuWTASR6y90lw2gto4Jyu0xxStJtzvT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="295923510" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="295923510" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 17:55:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="675246639" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="675246639" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 30 Nov 2022 17:55:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 17:55:28 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 17:55:28 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 30 Nov 2022 17:55:28 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 30 Nov 2022 17:55:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VI0H+mRFQnJLOkHdUj0Gg8VXcAXhH/3rkmbwQjMAjVjN6sDkjn3C3Lz/SEsEAv6XW4AFhYgYhg9HmbU7FuFnGAMEK7vVKa9QjyZmT0ZbOj3km6VEzTUznEk5p4fhoA6ICGdzegFhU5g55LeBwGlj9vnd1i8ZsNEzKiyiZiXA7NZ6sICgYIUuuMMAw1arH4tmNDxskQ5J4X0wHpPnEFP7foAukgefl+zFUakcTwirTTHqERt7/Tr2+ZyGH1Ggk/HOokDdSL7RthDgAf0TkP1tdt+ZbiaqL+EddgnHy+goisuw9tnn5i8g0rkw+H0kjff4sy22q0MhFRmSR/PZDhBM6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Y9HoH6xuA16hjuaQQzk2uNDQC5yyu4UPkiw0ZfizJs=; b=P7ZRBY7Hkxcj7kBp26sq0n2WjCwf+HUfrvnVc1ExwsWkjPecSzMNgcLswlARtZmA8UbXlGaSgAm9KOTf3rBQ1bl7fSCbXg6MK5ieLzzsRXMgATtAU9Dw52haHK4DwjAp+XPKOUh+TMydzrKlzIGfp4TeE1c6UP5jOaZyOtEtJU1jwbFsiLa9BISCq7k77rDoXui4VZQ1rnb8WrR3LgaUpr9o552Tw1G5o4V6pRpEAJMgZjU1PE6Hfcvct10uSh6iRgMxsKZU2L3DYMz0qdzeGtGpPenbNlx6/ErhZhMFsdPefQOvwFyMwSeUsQO9iHO7v3rzaRSq8+P7idPH023qsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by CH3PR11MB7345.namprd11.prod.outlook.com (2603:10b6:610:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:55:26 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b%3]) with mapi id 15.20.5857.023; Thu, 1 Dec 2022 01:55:25 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v5 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT Thread-Index: AQHY98a14IDzRXG/ME6ql34m+u/75q5UaPEAgAP3ZwA= Date: Thu, 1 Dec 2022 01:55:25 +0000 Message-ID: <4dfc60cca206ca496fd8ed2ba07a4f0faa91175a.camel@intel.com> References: <20221114011605.1157707-1-fei.w.wang@intel.com> <20221114011605.1157707-2-fei.w.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|CH3PR11MB7345:EE_ x-ms-office365-filtering-correlation-id: a3c4b0fc-ad77-41ec-e6fa-08dad33f1d9d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vZ+/czsRVP3CNEJFe2TVuIrtsNKa7dgwxoOSjg+sfkoyHbPBN1b0GJbsT6vn3JNaJhIaTA5/c9YdoEvn2ria0WAqTmLI/dAEvi6Os+ej6oCv8Pq/7AA9duCYQTLQz8B7ZIMRRhPTF+AzNskl88K0cnjrt4QIhbs8EN0lxE4z0NFv5NqAq0/cp/YFobMmuzKkMe/6Ipepa7CUiW0s/d/uhi+f7fsykr+3I/yDc8GGcPrCeu2gkAx7RJaGjOYmjxPM11GnXdBZT1NWll+y3fF/EEJnpocDnbNsB64WX/7emQt42uvYC7mx5q6WV7tcbWGz+arkZxS5ymWbkfpeG1otoC1f3KHNWu3+xkFITPQOGdpNlTmQygSj/3RlfJFUv/Xbbxo8S+0Cfr+ZmwWVhTDMXAeXKs7qBhlmqf2mKeFjSgiRODHockhn1sGmoKf9K3Te7ZCppKm9Jukp7VYY1paguV87TMaswixOvF4qO7U/ammtoPV30GiqSObhZN3kt45T8YqZRq6D/am1UhQkkFkH/APDvW0v4KjLovpflebHeSBZwYhUqEPK6hr5+1Z29D+YDQnaYsNDBto3dLgwpTTrUptnc7u+gJQ70Irv5+hARcBVmbbAlnc47xJa+gx2dmZRkwnRM/+foxkw6JPfVFLkIDehlBu/9rVIUXIT2sheXDCb1PZzaa+Jeh8m0eQF/W4spfQRKQdG0FXcJX+7IOwE8302wXiQxR6MwhHmrgEvRTaha7lCekFUvqIIGwFEYjRA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199015)(186003)(26005)(83380400001)(6512007)(6916009)(82960400001)(38100700002)(5660300002)(2616005)(36756003)(122000001)(66476007)(478600001)(66899015)(6486002)(966005)(8936002)(38070700005)(66446008)(64756008)(53546011)(66946007)(91956017)(6506007)(71200400001)(76116006)(2906002)(41300700001)(66556008)(4001150100001)(316002)(86362001)(8676002)(376344004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWd4Q2JhaW1YUzR4Mit3MDZEMVpOL2Y0aXY5dDlpM2VHL1BSRFBvT0JIVHhG?= =?utf-8?B?NFg0bXVYaGhmT09YU2RSdHFxeFpPWFpaNXJ4OU00bE5hZGdyNzMxVlVsYnp4?= =?utf-8?B?MVd0L3NzZkhxU0VKWURyalphb04zdW55THlZaWJDUndhMFYyL2JHM2wrVVhX?= =?utf-8?B?WkVWZzh4cHNxRzkxZlNPWnJ4Q1NlTHhQNGZ2K3FrZGVCTFZrVjBzc0dXWFhO?= =?utf-8?B?SWFxSk9KelZzZmppQWREdElpRmdXN1VLeTlBV3F4dVN5dzhVY3l6RElLUVFs?= =?utf-8?B?K294alZlQUw1RHdyaHlEWVIwRzhEMmpGZlN5NFhiamtGVncxZW9zaVVhM1A2?= =?utf-8?B?cmJtMDJyOC9ud04xT21WemhUbldLMDF1dm1sakM2UVQxVk1kZlg3SmpxZ1Z1?= =?utf-8?B?Zmpyemd0Y1RwM1Y1V0pGeVdiSk02cFFvY21lUWp3TkJKbUo3VFhhQ1IyVExM?= =?utf-8?B?dnllMFY1LzE0T2tSeVBnbElHY2JlQjlyRTMxSVorYXhMMVMxWnpQNWQyM0RQ?= =?utf-8?B?OUdUSzc3RHNUendua2tEQlREd3cxT3E5Y3VFbDRQTjlDTUI3QWtpRmhKM1lj?= =?utf-8?B?M0tUYlcvUmZYaXh4SEVHRC9mdTNaWmdNK1FVWXFPbHhmdVVFdnhFUkNtNGtK?= =?utf-8?B?V2IrSHFaWkpIcU1Pa0syMkhhVEw0bkRPRWE4TzVVdkEyWFZqSTlrekVmT3R0?= =?utf-8?B?YVhiMEhkZUI5SVJ1U01kc1RBQ3o5ZW4vRnZKOTBSSHNzOUdxWEFoZFllZEpq?= =?utf-8?B?eWhpZExpNXlwT3pQU05tWkJ6N0JqWlM2bGoxbnJsZi9zUGhEUFFQa3NZWnJ1?= =?utf-8?B?N2F6Snc1bUd6Z2dtUFdnbGltc0RlQmx2NEN3cmlaV0dmblV6NUhJOGVMd1Rl?= =?utf-8?B?UytNNUtUcGUwZ09CVHV5c2E5YjNCWktrSG1wRjV6di9mN0xtdDVGOVdGVVlv?= =?utf-8?B?QjljV3hLK0JrRUFmWnVYRmxBWTBubG5jMWQ4UFJpQ2JUbW9MSkxzTDBscEhG?= =?utf-8?B?dGRmVDQ0QndPYmNBTS9ISnVsZ0pQSTl2Y0NERWZDdE5DK0VjWFhBVExQNUJ4?= =?utf-8?B?SWE5bWJ3bnhPM01adFAxUEdYUEFUQW5rNy93OHM1Z0J6TGR5blIwZ0ZoUXpi?= =?utf-8?B?Wlg5UklGakV4SHYyWEJLbndTdGVycHArZjBvZlVzRkRxZ2tUeUZHQU4xb3J1?= =?utf-8?B?NnRYbWxJbmRFankydUhIaSthNTVxNEVTNWtFSXB4TWU4WnYydHdtMnAwYkRa?= =?utf-8?B?MTJybWJlMlBaMS81MUc4Y3NTMHhWUWoxdU5TSG1HNk5LQWpuU2pKT1VCbm5i?= =?utf-8?B?aXh6dWJuSmtpRjdtclRSbGZNanBDTWlZazZZQlgxOGlPVDR1SkV1Ti9xWU1T?= =?utf-8?B?b1NKYUUwT3k2WFR5azk3bXlidkdjNlFoUXQrN3A0azdVRC9BcW5LNGRvSEtQ?= =?utf-8?B?YUhqNTZZYjRaR2JYNUlDTXdwNWZwWmJkU2JGUW56cnlERXZXaW95WUxJRHdO?= =?utf-8?B?K0M5aEozSjIybURrUElBUjNUdFhsSzNGZ1RaZHBrc3dpQW5zY2RSNFJhY1Nv?= =?utf-8?B?RTFtaUJaVHpFQ0htUys5Vm9neDF5ckc2dFBZUkxzOS83cy9XM01XVXhiY3Aw?= =?utf-8?B?a2FjVGFqRFFMU1JuazlFSGFLZHJHQXh0cUZXRnNtYWdRang0bVVreERNbDI4?= =?utf-8?B?bGhyY3d1djliaVlhZEZrRlV5ZGluUjhhaGZnb2dscG9UczNGQnVSb3dvYVo5?= =?utf-8?B?MzgzcnNmRkNxZjQ1UWRkYnBraXVyQUllM0xyaG9wdEZseFgrVTN6ZGErd1Rv?= =?utf-8?B?cXlMYU0rTjk0R3FsVmwvMjhpKzVIU2RRanprUWsvU2V0dHY2QVMvVVRVbEhB?= =?utf-8?B?ZmUwaC9JZnNOdGUxWkZidGtUa2tYbk51dGVGWnFJcXhnZkF0UjNld3hGUnBV?= =?utf-8?B?MitwNlFnelEzSENtQVBOUVJEM09KZG9KekxxTjRqMmJRRmJ4Q1ZJdU91NytK?= =?utf-8?B?Wm1yeTdKMUN2clhGQ3RtOVg1WWt0L3hvdllaYUd5MHB0ekVOWTk1T05LeUZO?= =?utf-8?B?SmtPZEJTeU5YRkc4N2xaa2paTjM2eTZOWVhBS1o4UmQrTEQ5OEZHUGJhRnEz?= =?utf-8?Q?M2Z7jeqk+FCDBw2Cho/3gS2Js?= Content-ID: <5F465396210DC54998F26BE9B1FAADE5@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3c4b0fc-ad77-41ec-e6fa-08dad33f1d9d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 01:55:25.9321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ur5SDiKQZ69AOGaXzEB37qo2MShOoRo8vZieVnfLtTxs+Wn2dfn03l3JTXkxV2BO1FuUijiwv8cIl/A17DXncg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7345 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v5 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-11-28 at 13:20 +0000, Mark Thompson wrote: > On 14/11/2022 01:16, Fei Wang wrote: > > This can fix vp9 decode image corruption when the frame size is > > change, > > but the pervious frames still be referenced. > > > > Surfaces don't need to be bound to vaContext only after VAAPI > > 1.0.0: > > https://github.com/intel/libva/commit/492b692005ccd0d8da190209d5b3ae7b7825f4b8 > > > > Signed-off-by: Fei Wang > > --- > > libavcodec/vaapi_decode.c | 11 ++++++++--- > > libavcodec/vaapi_decode.h | 1 + > > libavcodec/vaapi_vp9.c | 4 ++++ > > 3 files changed, 13 insertions(+), 3 deletions(-) > > This always segfaults immediately on anything unsupported. E.g. with > fate/hevc/paramchange_yuv420p_yuv420p10.hevc: > > [hevc @ 0x555557c0e7c0] Format vaapi chosen by get_format(). > [hevc @ 0x555557c0e7c0] Format vaapi requires hwaccel initialisation. > [hevc @ 0x555557c0e7c0] Hardware does not support image size > 1056x8440 (constraints: width 0-4096 height 0-4096). > > Thread 20 "av:hevc:df0" received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7fffb4ff9700 (LWP 509456)] > ff_vaapi_decode_uninit (avctx=0x555557c0e7c0) at > src/libavcodec/vaapi_decode.c:714 > 714 vas = vaDestroyContext(ctx->hwctx->display, ctx- > >va_context); > (gdb) bt > #0 ff_vaapi_decode_uninit (avctx=0x555557c0e7c0) at > src/libavcodec/vaapi_decode.c:714 > #1 0x00005555563073d7 in ff_vaapi_decode_init (avctx=0x555557c0e7c0) > at src/libavcodec/vaapi_decode.c:704 > #2 0x0000555555e62fee in hwaccel_init (avctx=0x555557c0e7c0, > hw_config=0x55555728f770 <__compound_literal.0>) at > src/libavcodec/decode.c:1121 > #3 0x0000555555e634ec in ff_get_format (avctx=0x555557c0e7c0, > fmt=0x7fffb4ff8ccc) at src/libavcodec/decode.c:1261 > #4 0x00005555561ca829 in ff_thread_get_format (avctx=0x555557c0e7c0, > fmt=0x7fffb4ff8ccc) at src/libavcodec/pthread_frame.c:1048 > #5 0x0000555555f68f37 in get_format (s=0x555557c3e6c0, > sps=0x555557c21f80) at src/libavcodec/hevcdec.c:505 > #6 0x0000555555f69621 in hls_slice_header (s=0x555557c3e6c0) at > src/libavcodec/hevcdec.c:618 > #7 0x0000555555f7472d in decode_nal_unit (s=0x555557c3e6c0, > nal=0x7fff8802e920) at src/libavcodec/hevcdec.c:3173 > #8 0x0000555555f7508a in decode_nal_units (s=0x555557c3e6c0, > buf=0x7ffff637c010 "", length=159280) at > src/libavcodec/hevcdec.c:3355 > #9 0x0000555555f756d6 in hevc_decode_frame (avctx=0x555557c0e7c0, > rframe=0x555557c0ecc0, got_output=0x555557c0d690, > avpkt=0x555557c0ef40) at src/libavcodec/hevcdec.c:3497 > #10 0x00005555561c839c in frame_worker_thread (arg=0x555557c0d580) at > src/libavcodec/pthread_frame.c:241 > #11 0x00007ffff68ccea7 in start_thread (arg=) at > pthread_create.c:477 > #12 0x00007ffff67ecaef in clone () at > ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 > (gdb) Thanks, will fix this in next version. > > > Also, I don't see how this is testing whether the driver supports > changing the resolution at runtime? The note in libva that you cite > allows new switching render targets in the context, but I don't see > why different resolution would be allowed given that it's a parameter > passed to vaCreateContext()? > > Looking at the Mesa driver it appears that the internally-allocated > references are not going to allow size changes (where does the > template width get updated?). I don't have any hardware to test > that, though - are you able to try this on recent AMD hardware with > VP9 support? I checked on AMD RX6700XT, it can get correct output when decoding multi-resolution vp9 clips only after apply this patchset. For example, by using clip from: https://storage.googleapis.com/downloads.webmproject.org/vp9/decoder-test-streams/Profile_0_8bit.zip VP9 native decode result: ffmpeg -i Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.web m -pix_fmt yuv420p -autoscale 0 -f md5 -y - [...] MD5=51b3393fa98ad9ab99c0b45ef705ebc4 [...] Without this patchset: ffmpeg -v verbose -hwaccel vaapi -i Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.web m -pix_fmt yuv420p -autoscale 0 -f md5 -y - [...] [AVHWDeviceContext @ 0x56526336a000] VAAPI driver: Mesa Gallium driver 22.3.0-rc4 for AMD Radeon RX 6700 XT (navi22, LLVM 11.0.0, DRM 3.44, 5.13.0-40-generic). [...] MD5=2e799f0f916195f86a356907f7e4eae1 (change from time to time, but never same with native decode result) [...] With this patchset: ffmpeg -v verbose -hwaccel vaapi -i Profile_0_8bit/frm_resize/crowd_run_1080X512_fr30_bd8_frm_resize_l3.web m -pix_fmt yuv420p -autoscale 0 -f md5 -y - [...] [AVHWDeviceContext @ 0x561c08e7a000] VAAPI driver: Mesa Gallium driver 22.3.0-rc4 for AMD Radeon RX 6700 XT (navi22, LLVM 11.0.0, DRM 3.44, 5.13.0-40-generic). [...] MD5=51b3393fa98ad9ab99c0b45ef705ebc4 [...] That means both Intel and AMD driver implementation doesn't limit surface's resolution must be same with vacontext. So I think we can add some description to libva to declare that. > > What have you done to verify the METHOD_HW_FRAMES_CTX > behaviour? This has changed so that vaapi_decode_make_config() is no > longer called, which feels possibly-bad though I'm unsure of the > exact consequences. > > As I said last time, I do think you should only do this in exactly > the places where it is required, and not change any other behaviour. vaapi_decode_make_config() is called by ff_decode_get_hw_frames_ctx() in ff_vaapi_decode_init. So the change to vaapi_decode_make_config doesn't impact the final result. To avoid confusion, I will not change its behaviour in next version. Thanks Fei > > Thanks, > > - Mark > > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > > index 134f10eca5..d950471b6d 100644 > > --- a/libavcodec/vaapi_decode.c > > +++ b/libavcodec/vaapi_decode.c > > @@ -658,9 +658,6 @@ int ff_vaapi_decode_init(AVCodecContext *avctx) > > VAStatus vas; > > int err; > > > > - ctx->va_config = VA_INVALID_ID; > > - ctx->va_context = VA_INVALID_ID; > > - > > err = ff_decode_get_hw_frames_ctx(avctx, > > AV_HWDEVICE_TYPE_VAAPI); > > if (err < 0) > > goto fail; > > @@ -670,6 +667,12 @@ int ff_vaapi_decode_init(AVCodecContext > > *avctx) > > ctx->device = ctx->frames->device_ctx; > > ctx->hwctx = ctx->device->hwctx; > > > > + if (ctx->inited) > > + return 0; > > + > > + ctx->va_config = VA_INVALID_ID; > > + ctx->va_context = VA_INVALID_ID; > > + > > err = vaapi_decode_make_config(avctx, ctx->frames- > > >device_ref, > > &ctx->va_config, NULL); > > if (err) > > @@ -691,6 +694,8 @@ int ff_vaapi_decode_init(AVCodecContext *avctx) > > av_log(avctx, AV_LOG_DEBUG, "Decode context initialised: " > > "%#x/%#x.\n", ctx->va_config, ctx->va_context); > > > > + ctx->inited = 1; > > + > > return 0; > > > > fail: > > diff --git a/libavcodec/vaapi_decode.h b/libavcodec/vaapi_decode.h > > index 6beda14e52..62a4f37ed9 100644 > > --- a/libavcodec/vaapi_decode.h > > +++ b/libavcodec/vaapi_decode.h > > @@ -61,6 +61,7 @@ typedef struct VAAPIDecodeContext { > > int surface_count; > > > > VASurfaceAttrib pixel_format_attribute; > > + int inited; > > } VAAPIDecodeContext; > > > > > > diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c > > index 776382f683..245b7a1b3a 100644 > > --- a/libavcodec/vaapi_vp9.c > > +++ b/libavcodec/vaapi_vp9.c > > @@ -181,5 +181,9 @@ const AVHWAccel ff_vp9_vaapi_hwaccel = { > > .uninit = ff_vaapi_decode_uninit, > > .frame_params = ff_vaapi_common_frame_params, > > .priv_data_size = sizeof(VAAPIDecodeContext), > > +#if VA_CHECK_VERSION(1, 0, 0) > > + .caps_internal = HWACCEL_CAP_ASYNC_SAFE | > > HWACCEL_CAP_RESET_WITHOUT_UNINIT, > > +#else > > .caps_internal = HWACCEL_CAP_ASYNC_SAFE, > > +#endif > > }; > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".