From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 338B341D45 for ; Fri, 18 Feb 2022 04:38:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA45A68B2AB; Fri, 18 Feb 2022 06:38:44 +0200 (EET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AF7A68B2AB for ; Fri, 18 Feb 2022 06:38:37 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645159122; x=1676695122; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=UKC15/VaPvU3/nl5hcJ59nqB9ES9BbcCU5FTUQmL/Ng=; b=gnIdiiPrX0lkAMq2/U1udOyoq0235RLGtGWQQEVYi+TgteKjmsOnTKF/ DRLf4GzaH9A9XLrGJ2uOzJkGHnuCaHpNrTpSzG37Na9a2DgtJunKbKkNo NpnXnptN64ulv2aCBIvpBblwPUsTnQk9/jkBzjqPhvAEAJ1tymSpZ1zxs gkLuMTzm18VpC4dfW8slg9hY0Rz9MCg+8yVBi+IUzDyTLC5RLBsxy+qZS IzKe0SuqF0YRVxogG1sM9eeVL9EOQZqd4wi4gu1ezgLqeWC4ft+vaef6C 3gQAjwioyP/50oKM2ASZ1LzgIA0RxqQgxv6+XBzGfuTdKyPQmWxnKYYbD g==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="311791959" X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; d="scan'208";a="311791959" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 20:38:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; d="scan'208";a="775171152" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 17 Feb 2022 20:38:34 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 20:38:34 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 20:38:33 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 20:38:33 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 20:38:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVasKrD7IeCed2qH7Umic5fHriSURt2XJHAQnaJa4crtIswvLzbqPiIt383v2g5H9HgtFgxJY4IpuuIxHj8E0UR/KWL2Q+yLeJudIDYP2tj/yx2RU7WSkkcY2rTPu+o5sa9RAdQPESVjvSnzoz13terUjUIOcxwWnkN8yyKcRYBtQ+FlaFHc19i/gJze2BqPiK3mvpKvd4IWu+QIACqsUwcULlFVQXtr50Bgu9b+V+EQXjpiEJXs/P9BPx/6K/5FtDD8J73sKFsa+RNOHUR3iNMEFj4RQlgBcTiRYMLw8IRkQbdGybPnqZzv1P/i3hW3P+M9/2UfwDRZG+opff2DzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UKC15/VaPvU3/nl5hcJ59nqB9ES9BbcCU5FTUQmL/Ng=; b=V7o3AUactZZxvE/zttA4oBA0DUENGFKVZNwJW1POZ/cxCV6FZgP7+5ksXYPtral+zWiGkQWOIwRQyG86VntwCtZg7go2zTqJCgUgR95Ol64+IEAY7FBTKphoyJsqY7+RgXvpjF0TrKwafc0Iuw6y4hbn3zsgnWPFZORcLeC6CzVnuUD/yL/k5YStgrAqXHwc3qQUsnYmdnWI1dBNPqgl/XEflhGPOQDNImI5YoAbkTPBX7daLNDESjoMvHsdUqQywBfFOW68+lVTNMHdZxKDsScWWiElQRaP1x/Ym7+E9nJGaQsMOGfbbF9bEe0kYBy1U4bx0uxAi6LHVUp3QkMtUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3665.namprd11.prod.outlook.com (2603:10b6:408:91::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 04:38:32 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f%4]) with mapi id 15.20.4995.022; Fri, 18 Feb 2022 04:38:32 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1 4/4] vaapi_encode_h265: Query encoding block sizes and features Thread-Index: AQHYJGm1XlvT0wttOkqP4nMXTg3qUKyYue4A Date: Fri, 18 Feb 2022 04:38:31 +0000 Message-ID: <4da316fe210ae6561a1a5036cc3a2fccb385253b.camel@intel.com> References: <20220218014301.1830754-1-fei.w.wang@intel.com> <20220218014301.1830754-4-fei.w.wang@intel.com> In-Reply-To: <20220218014301.1830754-4-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fde6b9f2-c703-466b-88c0-08d9f2988477 x-ms-traffictypediagnostic: BN8PR11MB3665:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2q22/laExyTlM3D/NbJcM4p2uftTNyv7l2jjUPkGHP1dPi8IytX3BkGL6/Ts/XsCG/mR/4An+yNPsZpvb1rjFaPXria+h8et8lAaFjLv6Fa0v/4d1asuVpZtCKaCxbkz72eCkeDictDXui4Ggx9/U2GRZY7HSuIt3u9tAyyr4Wb8vbbu9IXgdQjIlktZ/5cK3sU+VarsmgbUokTiiciRmF1ZMi4P3PHNG2OoJKW718Y8s4w5rZV8ZAsVdoN8aJHz0ySj7r3b4hWQXZWv0fgFGxB9f+SFKd9nexIoZIwJZ/7vbCceDe+JsXqpNwa/JHBjN1Tyx5qH7/+yk/sMT0O4rLfKrFKJW3amzxbUqi6D2V4q83qalOfV1wLa4eB+UjXzCdvfTvb7sS4oFYqoZhJ7A98r79FSSyTsUObrR5/GhLfRulPVf00swag3o6eKauH9fLrIXFqFC4xKBdtgy7AigcROWGV1Mn0vMAbVcJGzhaHKwFxs3KODCsvc40FOmlmTw3134kgDF1DYGaDlR/p49r/EhQAJcMyxHUhzbJlNGgDuMFTH/IjWXhNQP9Qfz8QbMSLzPj4cXjHPDCq1xYxRmSzDmZ9cWmI058Qwts3UYvQg3jd25g+JewtLywKwCsD9onFi/2Am9k3ZaE70SBtZ49etvg6TjO9vJ0tKH0fwep0W8iOOOLTMDMVtR9hU29VKS5FOyXO3+N3JqX5NsMj31bjO0FgL3tInhRYvKYEYOLCatITRE1GPqgXTaVrkx4C/bGBHXN7NcfNfBkG70bHkEA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(8676002)(38070700005)(66446008)(82960400001)(38100700002)(91956017)(66476007)(2906002)(66946007)(66556008)(64756008)(76116006)(54906003)(6916009)(122000001)(316002)(8936002)(5660300002)(186003)(4326008)(26005)(508600001)(83380400001)(2616005)(71200400001)(6512007)(6486002)(6506007)(36756003)(99106002)(309714004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U1NIbDVlZHlTaHlyLytWL2plQVBTTFFrNzQ3cnh4c1dRcVhwdEkxNTZJNmdq?= =?utf-8?B?M0VoWjBGZDlRUDBrSzhBYmowRjJVUFdBR0JmdkZCdFBXSDU4dFlSM3orMndj?= =?utf-8?B?YXBlVWdRYU1vc3FGcjQwM0Z6ZW01T0tEd3F1ZWF6UWg2bVQ5enRCUjBwNVVi?= =?utf-8?B?NVk3aUk0YVZjNXk3YjFndGFxTHNEQnA0LzJRUzZ1b0dJY0RnOGFMN1p3aWxU?= =?utf-8?B?RnpBYTg0Z0ZkL1pZa202U3AvTDBDZkxQMzVVSFdMRXpjZGs3SFBtWDlHcmZS?= =?utf-8?B?dk1uTXZyU3M1NGNrNjdPMlBxTVhvNGlvWHJSbjhHM21OU2dCUWhFWlNiWGZ5?= =?utf-8?B?ZkNnSG0zZWZSVEhadG4xeVNVbFdSWVIvallyNGVYUTJWTGxQLzdTVjZKdTZB?= =?utf-8?B?UGVKSUxNQlpxWXVQbTFDeGZSbW1mOTdyK1lRT2wyTVJJZ1BqSEV4RTljemVH?= =?utf-8?B?SXJ6YzB1WXloQWNBb3N3TkVyQnRWYWpoRW5tRXVMODNtZlZiTUcxcFF1cGo0?= =?utf-8?B?bjd4Vjc5OUtPMXVRYk05bzJCNEpXTHVxUnZXbzQyM2NDWE5NRitFVjNCdDB0?= =?utf-8?B?WTEvTnI0bXUrbm5OOHBMWFZNdlJud3VTSkJ3dDVRa3FFY1cvOGNMUjBUTUNG?= =?utf-8?B?U3hBSytLNmtFQWd0WXEwQ2luQXRxeWVPVkJWeXRCYTZkMHh2ZUdoTGJGYnht?= =?utf-8?B?YzNaMkhLbjR6Ukc2aEExMXlpYXRSWlNYc2puVGpvYXhlVEI3ZzRLamhhOWdv?= =?utf-8?B?QTYyV0Mrellob2pyU3RMSnlzemhKd0JpemRHdXVoZyt3ZzkwUy8wcS9sY2VP?= =?utf-8?B?NnR4bFhYRHJGZ2dvQ2dPL3plMVY5M0FVWUd1ZHVIdHh6UklIdU9NVCs3VnZE?= =?utf-8?B?a3BWWmlTeG5PWE1pUG5OUFdFREg0NGY4K0NEQmlMUDFrUG12WEdEWGpjMzBj?= =?utf-8?B?QzdUUy9ERm0vbUxKUEh6WlhTSnd0TDJtYld0dW0xQkppMEV6V0MxVmgwd3VL?= =?utf-8?B?ZEg3OFpiZ0c3emVMUm92NEdyMnlVWFZpd0xXY1hZSCtadFJ2dTVlNUhIQTdB?= =?utf-8?B?azREK1FNM3V4NWs3VmU5K3lSMnFiVHQ1S25CWmlNcHhLNE45c3B5em9pNkRW?= =?utf-8?B?SGJRMzhHVElRWkthN2UrZVloWHo1dDNFNnJZalZmUXEybXFJSUw2WmhNK21B?= =?utf-8?B?V2lBam1IRmJFdFpHVFFMOXFUN2c3cHB2eTN3NHR1eU9pdGdjNkk3Ny94bHli?= =?utf-8?B?TEk3OEZDWU4xaFhkMkc0K1JyTUR1b0l5NFl3cFowUks5Sm0vVVo0aE1rbUNW?= =?utf-8?B?VHRrcmlQS1lsZzkxalFzM09qUTl3dGJTMmgydkxSMys3N0ZQMkZZcG5MK2tI?= =?utf-8?B?WEtGc3NJRU5tKzZIMnJXd2plSWhvSWg3NUtqOUxNajlmWURFMnpZNlJ2ZnRs?= =?utf-8?B?MW5rN3ZGZFJIaHN0QzE2VHBTTzFsSUdNeVFVb1RDTGQrUmdBR0NvM1dvR3cv?= =?utf-8?B?emZjaStCYnYzNVZhdGhPc3VsUWlPeVl6S3JGWE5LWHNHQk1WTURNUm9ZZGpW?= =?utf-8?B?Tm1RK01uMjBWSzBZQTFaS041ZDdCR1h3RHNaYjMvbTVEcHZJRnZOZDdReU5F?= =?utf-8?B?dXBkRWdRKzgwT01JTlRBV2pJSmpIZzhUdkNEd3VndEx3TGNaOWNHWGVuemRS?= =?utf-8?B?UTYwRW1yUGJmUCtlbzdXVld4SDFyWFZRdjhxUitCakV1WjhxNkJGSEViRjRR?= =?utf-8?B?VTBKZzZyV216MzRkdkFNNjJtV2NHUzBqN3haUXh6ZEFlMWlTSUJ6VlRyaXpN?= =?utf-8?B?M0xwQU5xWHdUc2tpY2w3eXE4UDBOaG5DVTBDL3hrdHN6amFtZG9QRFFENWVO?= =?utf-8?B?UEFvZFZkQmVIOGtGU0M0anhKMkZNZXJ6UHhzSFJnZlZRajhaRDVQQmRKNGhS?= =?utf-8?B?V016SDRyeWZsNG8vUFBtUUdXUVdhVUYwYnEzTGc2RjcweVF0TjhZU1Y2VDFh?= =?utf-8?B?cWpVQnVDMkgyWjM3Qml0TVVWcElZY3NXY0UwMjJlalQvS0xkYmxnU2tIUG9i?= =?utf-8?B?Mm9yMVhmeklPWVZTYUdLUGlReDlqYzlrd3VYZUhOSXg1Q0lEVExsOWw5T1FQ?= =?utf-8?B?NnlTeFNZekQ0LzNVd3hyUFZnbk9Ka0tIblRtTStDOEZYeDViZlJobExyalBK?= =?utf-8?Q?QOTyighJf8e3cMjmdj8+lQY=3D?= Content-ID: <8DE6ECADE9F3C345900A110A968039F5@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fde6b9f2-c703-466b-88c0-08d9f2988477 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 04:38:32.0075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1k/5tIRp+6qw9c83EjHqLf5JXXHHoiVGWGc64NJoAXFkEZWa9lyAYVkTwD2nhQiwj//OjjkZpmX1dnMOXMd0yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3665 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1 4/4] vaapi_encode_h265: Query encoding block sizes and features X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "sw@jkqxz.net" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-02-18 at 09:43 +0800, Fei Wang wrote: > From: Mark Thompson > > Signed-off-by: Fei Wang > --- > libavcodec/vaapi_encode_h265.c | 107 +++++++++++++++++++++++++++++++-- > 1 file changed, 102 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c > index 8319848e4a..e98502503d 100644 > --- a/libavcodec/vaapi_encode_h265.c > +++ b/libavcodec/vaapi_encode_h265.c > @@ -56,6 +56,9 @@ typedef struct VAAPIEncodeH265Context { > VAAPIEncodeContext common; > > // Encoder features. > + uint32_t va_features; > + // Block size info. > + uint32_t va_bs; > uint32_t ctu_size; > uint32_t min_cb_size; > > @@ -427,9 +430,9 @@ static int > vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) > vps->vps_max_latency_increase_plus1[i]; > } > > - // These have to come from the capabilities of the encoder. We have no > - // way to query them, so just hardcode parameters which work on the Intel > - // driver. > + // These values come from the capabilities of the first encoder > + // implementation in the i965 driver on Intel Skylake. They may > + // fail badly with other platforms or drivers. > // CTB size from 8x8 to 32x32. > sps->log2_min_luma_coding_block_size_minus3 = 0; > sps->log2_diff_max_min_luma_coding_block_size = 2; > @@ -447,6 +450,42 @@ static int > vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) > > sps->pcm_enabled_flag = 0; > > +// update sps setting according to queried result > +#if VA_CHECK_VERSION(1, 13, 0) > + if (priv->va_features) { > + VAConfigAttribValEncHEVCFeatures features = { .value = priv- > >va_features }; > + > + // Enable feature if get queried result is VA_FEATURE_SUPPORTED | > VA_FEATURE_REQUIRED > + sps->amp_enabled_flag = > + !!features.bits.amp; > + sps->sample_adaptive_offset_enabled_flag = > + !!features.bits.sao; > + sps->sps_temporal_mvp_enabled_flag = > + !!features.bits.temporal_mvp; > + sps->pcm_enabled_flag = > + !!features.bits.pcm; > + } > + > + if (priv->va_bs) { > + VAConfigAttribValEncHEVCBlockSizes bs = { .value = priv->va_bs }; > + sps->log2_min_luma_coding_block_size_minus3 = > + ff_ctz(priv->min_cb_size) - 3; > + sps->log2_diff_max_min_luma_coding_block_size = > + ff_ctz(priv->ctu_size) - ff_ctz(priv->min_cb_size); > + > + sps->log2_min_luma_transform_block_size_minus2 = > + bs.bits.log2_min_luma_transform_block_size_minus2; > + sps->log2_diff_max_min_luma_transform_block_size = > + bs.bits.log2_max_luma_transform_block_size_minus2 - > + bs.bits.log2_min_luma_transform_block_size_minus2; > + > + sps->max_transform_hierarchy_depth_inter = > + bs.bits.max_max_transform_hierarchy_depth_inter; > + sps->max_transform_hierarchy_depth_intra = > + bs.bits.max_max_transform_hierarchy_depth_intra; > + } > +#endif > + > // STRPSs should ideally be here rather than defined individually in > // each slice, but the structure isn't completely fixed so for now > // don't bother. > @@ -539,6 +578,23 @@ static int > vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) > pps->cu_qp_delta_enabled_flag = (ctx->va_rc_mode != VA_RC_CQP); > pps->diff_cu_qp_delta_depth = 0; > > +// update pps setting according to queried result > +#if VA_CHECK_VERSION(1, 13, 0) > + if (priv->va_features) { > + VAConfigAttribValEncHEVCFeatures features = { .value = priv- > >va_features }; > + if (ctx->va_rc_mode != VA_RC_CQP) > + pps->cu_qp_delta_enabled_flag = > + !!features.bits.cu_qp_delta; Please fix the indentation > + > + pps->transform_skip_enabled_flag = > + !!features.bits.transform_skip; > + // set diff_cu_qp_delta_depth as its max value if cu_qp_delta > enabled. Otherwise > + // 0 will make cu_qp_delta invalid. > + if (pps->cu_qp_delta_enabled_flag) > + pps->diff_cu_qp_delta_depth = sps- > >log2_diff_max_min_luma_coding_block_size; > + } > +#endif > + > if (ctx->tile_rows && ctx->tile_cols) { > int uniform_spacing; > > @@ -640,8 +696,8 @@ static int > vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) > > .coded_buf = VA_INVALID_ID, > > - .collocated_ref_pic_index = 0xff, > - > + .collocated_ref_pic_index = sps->sps_temporal_mvp_enabled_flag ? > + 0 : 0xff, > .last_picture = 0, > > .pic_init_qp = pps->init_qp_minus26 + 26, > @@ -674,6 +730,8 @@ static int > vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) > .entropy_coding_sync_enabled_flag = pps- > >entropy_coding_sync_enabled_flag, > .loop_filter_across_tiles_enabled_flag = > pps->loop_filter_across_tiles_enabled_flag, > + .pps_loop_filter_across_slices_enabled_flag = > + pps->pps_loop_filter_across_slices_enabled_flag, > .scaling_list_data_present_flag = (sps- > >sps_scaling_list_data_present_flag | > pps- > >pps_scaling_list_data_present_flag), > .screen_content_flag = 0, > @@ -1105,6 +1163,45 @@ static av_cold void > vaapi_encode_h265_get_encoder_caps(AVCodecContext *avctx) > VAAPIEncodeContext *ctx = avctx->priv_data; > VAAPIEncodeH265Context *priv = avctx->priv_data; > > +#if VA_CHECK_VERSION(1, 13, 0) > + { > + VAConfigAttribValEncHEVCBlockSizes block_size; > + VAConfigAttrib attr; > + VAStatus vas; > + > + attr.type = VAConfigAttribEncHEVCFeatures; > + vas = vaGetConfigAttributes(ctx->hwctx->display, ctx->va_profile, > + ctx->va_entrypoint, &attr, 1); > + if (vas != VA_STATUS_SUCCESS) { > + av_log(avctx, AV_LOG_WARNING, "Failed to query encoder " > + "features, using guessed defaults.\n"); > + } else if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > + av_log(avctx, AV_LOG_WARNING, "Driver does not advertise " > + "encoder features, using guessed defaults.\n"); > + } else { > + priv->va_features = attr.value; > + } > + > + attr.type = VAConfigAttribEncHEVCBlockSizes; > + vas = vaGetConfigAttributes(ctx->hwctx->display, ctx->va_profile, > + ctx->va_entrypoint, &attr, 1); > + if (vas != VA_STATUS_SUCCESS) { > + av_log(avctx, AV_LOG_WARNING, "Failed to query encoder " > + "block size, using guessed defaults.\n"); > + } else if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > + av_log(avctx, AV_LOG_WARNING, "Driver does not advertise " > + "encoder block size, using guessed defaults.\n"); > + } else { > + priv->va_bs = block_size.value = attr.value; > + > + priv->ctu_size = > + 1 << block_size.bits.log2_max_coding_tree_block_size_minus3 + > 3; > + priv->min_cb_size = > + 1 << block_size.bits.log2_min_luma_coding_block_size_minus3 + > 3; > + } > + } > +#endif > + > if (!priv->ctu_size) { > priv->ctu_size = 32; > priv->min_cb_size = 16; Tested with i965 and iHD drivers and it works well for me Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".