From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5ECC24A7A8 for ; Tue, 9 Apr 2024 09:03:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA81F68D210; Tue, 9 Apr 2024 12:03:22 +0300 (EEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D48968D0F6 for ; Tue, 9 Apr 2024 12:03:16 +0300 (EEST) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-516d756eb74so4334468e87.3 for ; Tue, 09 Apr 2024 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1712653395; x=1713258195; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=it6flmyMNxnN6UGFJnATIxklrUBXbf5wNyBvXaVN2Dc=; b=S3QtAobfFCE9B+ypcN0J0zdWVNvyltvRu4LK+DpTqIPM9o3Y6GrihJhE60qoIo5zcz DuiOB/n/PhusDdXxsc00SZEgFJ4tZMhzVN/axJk6pwi63WW0o/Rerqj1zS41kGuUGsa7 8hwOm1gAynFRBZg/cLB3kiYaw+0tmqHIwOROWcKDMZtuEcl0x0IFic/y57Y+JvrRsWS6 nS6nKZGgkdzkHYSJ7m7stse6XEChgv+AqdVAvVBIYwpQyszTcql89roDvlJjFrx1nmHZ DtYwMrUimfFeVG0Gv9CagW8qlm8JTNnwC8J1r6i8US3nF5gbCeE6K6fWhwb+9J9tvVs3 A/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712653395; x=1713258195; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=it6flmyMNxnN6UGFJnATIxklrUBXbf5wNyBvXaVN2Dc=; b=JGln4WN9A3H+tD6sH4tt8AHNF1d9x3irATAXlAy1ejckJAZ9DIoanGJnRFFEw5R30Y XLNWMzG4eKIXkePwzrg9Mx2/sNkeK8nVp7RjhY13xNUInkAHpkcR6311Nv04Kec2YvpZ yqTrRxhVSRAG4NR//DdsRe9zyuYM9KztOwcXhWiNIKfE1SBw2ogNGN/QJ+JtxgHaua8U sgtLIhUILKI+mQ3BgqNV84ucYohzEZQoYskYonn9V2HM3m5ZUU9CBCPUov1NEVc5DUa2 Vnu0jXZutmfonpPvNTDRtMipVWbKkPEpq424rTnYB/Tu2OZLX6CSn6TjA3h40fQias4r TLyg== X-Gm-Message-State: AOJu0YwnDUobRKvCa6G75rp2lUnWXcUpIZ73tl295AEc9Cg0kIt/aIkn Tm6dq5xxOcFebULkbWCgjE/fyhN/+m+Z3cl4HbT/6cri70Rty+cyorePSAIjo+RrqLpaDoaUZkw lqw== X-Google-Smtp-Source: AGHT+IFJyd+hf/7GiUmtJmVRwTBAwSJfjVkQfRKg/0TNzvt1LcBFG+dzCsV1QGfiuebN1MB2UWLIfQ== X-Received: by 2002:ac2:54bc:0:b0:513:e909:f234 with SMTP id w28-20020ac254bc000000b00513e909f234mr6650567lfk.57.1712653395257; Tue, 09 Apr 2024 02:03:15 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id z6-20020a056512370600b00515aa359f8fsm1484348lfr.225.2024.04.09.02.03.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 02:03:14 -0700 (PDT) Date: Tue, 9 Apr 2024 12:03:13 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240408131600.81682-2-jdek@itanimul.li> Message-ID: <4da1b82d-b8a0-74c7-f176-1dd8767cfe66@martin.st> References: <20240408131600.81682-1-jdek@itanimul.li> <20240408131600.81682-2-jdek@itanimul.li> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] configure: simplify bigendian check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 8 Apr 2024, J. Dekker wrote: > The preferred way to use LTO is --enable-lto but often times packagers > still end up with -flto in cflags for various reasons. Using grep > on binary object files is brittle and relies on specific object > representation, which in the case of LLVM bitcode, debug-info or other > intermediary formats can fail silently. > > This patch changes the check to a more commonly used define for > big-endian systems. It's not common only for big-endian systems, but for GCC-style compilers on all endians. > More checks may need to be added in the future to cover legacy machines. Don't use the word "legacy" here. This define is not standard, so it's perfectly plausible to have a modern, standards compliant compiler that just doesn't use this define. With the commmit message you added here, the change is ok, but please do reword the last sentence above. I'd suggest changing the last paragraph into this: --- This patch changes the check to a more commonly used define for GCC style compilers. More checks may be needed to cover other potential compilers that don't use the __BYTE_ORDER__ define. --- // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".