From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C4B245FDD for ; Fri, 28 Apr 2023 12:01:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2F9768BE25; Fri, 28 Apr 2023 15:01:04 +0300 (EEST) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B95468BAD6 for ; Fri, 28 Apr 2023 15:00:58 +0300 (EEST) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-18b0879e0c8so7134247fac.2 for ; Fri, 28 Apr 2023 05:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682683256; x=1685275256; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=FrP6Qw5SQPZPxL59GYmno0/7qdNM9VhIbthFdd7eTzA=; b=oBNaCFEPO+31eLZ/PdwbyrPfckw9PCZEQrFst5YPLx6EFo2HGD4S2gDPHbryN+h4k7 tzKBZLBi7QAkEeQsjVcSRSyfoinV/hBoGWGYlCosye/dwN2EEkqQMW2nbjLxhJPhvGDS NdGR7WdhH7iQXTbfcj6dM7+QtNOVR1XgSw/IhU9GpJ7kQKJt+bi1/KgfuEcTTEt3qklN n61rSGir5AGyT5yfXPDmIC+afcd0UL1VEBrHRReWysFHGyidJZ0dw4o9AUViaJxJ26zb J7kcAlSBogjNV9qNHmTH33eN34Q4zPCRIBuqSXUDXmPaOm3ZEIly7XlXmg861lC4TRJD 6SgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682683256; x=1685275256; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FrP6Qw5SQPZPxL59GYmno0/7qdNM9VhIbthFdd7eTzA=; b=DjNecE1uNtAOIBkKV0GqyQzIiFFhAodRj2amrpYol+KztaaXEZcNKImV7mnAx81jZL 2DpxL72bHyN25U0JHPRSMrZLqj6E7UTXAfS8cqxjNIyMzKX/oWHdmAAAXbpJLbRhIl4Z Pah6Sz3Gw9NaEswBFukZTKRW01i4M7CG8drYJ0kaYdqPZlPslw2zIQFYpSk2gIo7AO/D zdqpRHQ7q55V8VGP8ICPtgg76c85FusuGMim5x3A4fwm5Dl4CX2ICWO16HztZkHviljR L9tXboW0zIXDAKd4e/MmmigTLF+oGiFg6FYxRU4H3uY478LDu3uV+1Zgk+I7mTrtj5Ut Ieeg== X-Gm-Message-State: AC+VfDyYX9smB8N8RQ19A7REAVyeNEvpzQmVnRCkMdt09Yjl0lC4Bc+G HGKuQljNPMAFq0RL3tNJWaMcX1qVuXs= X-Google-Smtp-Source: ACHHUZ4ob3rdxSfc194HmbU7pt03tb6FW3tqxU7kS0IgYUYGp0HqZecekdk/ulQaSMbG0XOzmWMYyw== X-Received: by 2002:a05:6870:42d4:b0:177:c72a:a9c5 with SMTP id z20-20020a05687042d400b00177c72aa9c5mr2575179oah.18.1682683256300; Fri, 28 Apr 2023 05:00:56 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id eg27-20020a056870989b00b0018f0b02b0c4sm2111058oab.6.2023.04.28.05.00.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 05:00:55 -0700 (PDT) Message-ID: <4d9e2ce9-fdfb-3fcd-bd7d-07d9bbe5860d@gmail.com> Date: Fri, 28 Apr 2023 09:01:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 To: ffmpeg-devel@ffmpeg.org References: <20230427142601.2613-1-anton@khirnov.net> <20230427142601.2613-8-anton@khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 08/21] fftools/ffmpeg_filter: add filtergraph private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/28/2023 5:45 AM, Nicolas George wrote: > Anton Khirnov (12023-04-27): >> Start by moving OutputStream.filtered_frame to it, which really belongs >> to the filtergraph rather than the output stream. > > Then just move them to OutputStream. This is just code noise for no > practical benefit, since ffmpeg is not a library and does not have to > deal with ABI stability or types declared in private headers. The longtime goal of this work is to have completely standalone modules within the CLI and each of them threaded. So while ffmpeg may not be a library, clearly defining what fields should be accessed from "the outside" and which shouldn't would have the same effect and benefits as if it was one, particularly ensuring no future accidental usage of fields that should not be touched. The decoder side for example has no need to touch a frame the filtering side is using internally, and more so if it could result in races. There's also the fact Anton is maintaining this code and this helps him keep track of the nature of each field, plus the fact this same change has been done before elsewhere, so if you're going to argue you don't like it because in your opinion it's unnecessary, then that's not enough grounds to block it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".