From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 981094268C for ; Tue, 22 Mar 2022 12:22:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DC1B768B084; Tue, 22 Mar 2022 14:22:29 +0200 (EET) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8A1668991B for ; Tue, 22 Mar 2022 14:22:23 +0200 (EET) Received: by mail-oi1-f173.google.com with SMTP id k10so7753505oia.0 for ; Tue, 22 Mar 2022 05:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=m7JRixrPQTUxiUmlNmeXdHBuil0RHRJMht+6DCjFbOU=; b=SZ2drPlIbplDh+lOs1yQVf83Bh4n8MfWz7Eb+RNCRpKTey5wWisxgMpH54ijkWvyrL L7IT0jvUPyPAEDcyrjbUbKUziP3igM3Id5rozSXS+QkcsZonUz1CaKmHBan7Jnz5WXWs IzNYov7G++2+8o1HoJVs8+TEC20/8hm2KkMuyieGw9ChKxewZjGRErzmVGT+7/jE3Bzr +uKbljaqrqgkkkTHtzf/GwNogzYBMNpCNSUu7bj6NoDqJzKoAU9VR1wuUrwCoznT3nQv DAmnTjcdpJEWpIYnsGeBvhcyGoa5fpZSf0K2qA38E6xwY+MFvi3vuo4Sfj0KAyabNcGP VU3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=m7JRixrPQTUxiUmlNmeXdHBuil0RHRJMht+6DCjFbOU=; b=G1hkic/XdvpQktDqYzuFV4qw8/8Jq31kvod/Vz+IBXdVDnl7imur611SCdy+kVwgjR 0AD+zcmby6Tkiwisu7E8UcmVR1lVLgMT3Ox9Z3iDWNK4XEcyvwZhuTb1fCqLb8NcNpXo /yGJp8LL2cI7bqev50RmsDRAlV/4IaKWdcAWNc+r6xGKh8bNrFnSbI3AC28joBpQLmXl eFVCW9rESG+u7oChF1TaSobmrWZJ2HaxLyjXqW6nS8If7k3RdcF+daGn9K/xM+Mfjh9J 4UswhHY8GTRiw7rKdmVXt0wMGkFm/PnaC7hBV3VHh3O0qOA/f8h/pqyE5Cs1Mo8CEcwZ 1IBg== X-Gm-Message-State: AOAM532/gbLnL8B66tUoMf526KP77unJwotiY+lrHuVjmm5eWuLJlqb5 VIZqDUKP/IMMose2OZAbGrTnH/7cmieYGQ== X-Google-Smtp-Source: ABdhPJzXd+17yJ8amjOKvwis0wrPQG/LkA9AvVkAEGshVVHqaLlNd8J9j2Tw7q4S1OwCBQPVPS1ylQ== X-Received: by 2002:a05:6808:118d:b0:2d4:be7e:6748 with SMTP id j13-20020a056808118d00b002d4be7e6748mr1874939oil.123.1647951741393; Tue, 22 Mar 2022 05:22:21 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id q16-20020a9d4b10000000b005b22b93d468sm8629820otf.74.2022.03.22.05.22.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 05:22:20 -0700 (PDT) Message-ID: <4d041c05-bc5c-0751-8e22-3f1142b9f411@gmail.com> Date: Tue, 22 Mar 2022 09:22:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20220318021309.12878-1-jamrial@gmail.com> In-Reply-To: <20220318021309.12878-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dfa: don't check for the bitstream version on every copied line X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/17/2022 11:13 PM, James Almer wrote: > And use av_image_copy_plane() while at it to simplify things for > version != 0x100. > > Signed-off-by: James Almer > --- > libavcodec/dfa.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dfa.c b/libavcodec/dfa.c > index ab78d66763..c29eb76de5 100644 > --- a/libavcodec/dfa.c > +++ b/libavcodec/dfa.c > @@ -385,8 +385,8 @@ static int dfa_decode_frame(AVCodecContext *avctx, > > buf = s->frame_buf; > dst = frame->data[0]; > - for (i = 0; i < avctx->height; i++) { > - if(version == 0x100) { > + if (version == 0x100) { > + for (i = 0; i < avctx->height; i++) { > int j; > const uint8_t *buf1 = buf + (i&3)*(avctx->width/4) + (i/4)*avctx->width; > int stride = (avctx->height/4)*avctx->width; > @@ -400,12 +400,12 @@ static int dfa_decode_frame(AVCodecContext *avctx, > for(; j < avctx->width; j++) { > dst[j] = buf1[(j/4) + (j&3)*stride]; > } > - } else { > - memcpy(dst, buf, avctx->width); > - buf += avctx->width; > + dst += frame->linesize[0]; > } > - dst += frame->linesize[0]; > - } > + } else > + av_image_copy_plane(dst, frame->linesize[0], buf, avctx->width, > + avctx->width, avctx->height); > + > memcpy(frame->data[1], s->pal, sizeof(s->pal)); > > *got_frame = 1; Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".