From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DBAAF4571E for ; Tue, 21 Mar 2023 19:29:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C230E68C53B; Tue, 21 Mar 2023 21:29:51 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6344668C2E8 for ; Tue, 21 Mar 2023 21:29:45 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id E9B2EE8796 for ; Tue, 21 Mar 2023 20:29:22 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O6rd9bMaQy-c for ; Tue, 21 Mar 2023 20:29:19 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id E492DE877E for ; Tue, 21 Mar 2023 20:29:18 +0100 (CET) Date: Tue, 21 Mar 2023 20:29:18 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20230321123729.74124-2-martin@martin.st> Message-ID: <4ce99489-4b19-3c7c-88aa-1080531f925d@passwd.hu> References: <20230321123729.74124-1-martin@martin.st> <20230321123729.74124-2-martin@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/2] aviobuf: Avoid clearing the whole buffer in fill_buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: CgpPbiBUdWUsIDIxIE1hciAyMDIzLCBNYXJ0aW4gU3RvcnNqw7Ygd3JvdGU6Cgo+IE5vcm1hbGx5 LCBmaWxsX2J1ZmZlciByZWFkcyBpbiBvbmUgbWF4X3BhY2tldF9zaXplL0lPX0JVRkZFUl9TSVpF Cj4gd29ydGggb2YgZGF0YSBpbnRvIHRoZSBidWZmZXIsIHNsb3dseSBmaWxsaW5nIHRoZSBidWZm ZXIgdW50aWwgaXQKPiBpcyBmdWxsLgo+Cj4gUHJldmlvdXNseSwgd2hlbiB0aGUgYnVmZmVyIHdh cyBmdWxsLCBmaWxsX2J1ZmZlciB3b3VsZCBzdGFydCBvdmVyCj4gZnJvbSB0aGUgc3RhcnQsIGVm ZmVjdGl2ZWx5IGRpc2NhcmRpbmcgYWxsIHRoZSBwcmV2aW91c2x5IGJ1ZmZlcmVkCj4gZGF0YS4K Pgo+IEZvciBmaWxlcyB0aGF0IGFyZSByZWFkIGxpbmVhcmx5LCB0aGUgcHJldmlvdXMgYmVoYXZp b3VyIHdhcyBmaW5lLgo+Cj4gRm9yIGZpbGVzIHRoYXQgZXhoaWJpdCBzb21lIGFtb3VudCBvZiBu b25saW5lYXIgcmVhZCBwYXR0ZXJucywKPiBlc3BlY2lhbGx5IG1vdiBmaWxlcyAod2hlcmUgZmZf Y29uZmlndXJlX2J1ZmZlcnNfZm9yX2luZGV4Cj4gaW5jcmVhc2VzIHRoZSBidWZmZXIgc2l6ZSB0 byBhY2NvbW9kYXRlIGZvciB0aGUgbm9ubGluZWFyIHJlYWRpbmchKQo+IHdlIHdvdWxkIG1vc3Rs eSBiZSBhYmxlIHRvIHNlZWsgd2l0aGluIHRoZSBidWZmZXIgLSBidXQgd2hlbmV2ZXIKPiB3ZSd2 ZSBoaXQgdGhlIG1heGltdW0gYnVmZmVyIHNpemUsIHdlJ2QgZGlzY2FyZCBtb3N0IG9mIHRoZSBi dWZmZXIKPiBhbmQgc3RhcnQgb3ZlciB3aXRoIGEgdmVyeSBzbWFsbCBidWZmZXIsIHNvIHRoZSBu ZXh0IHNlZWsgYmFja3dhcmRzCj4gd291bGQgZW5kIHVwIG91dHNpZGUgb2YgdGhlIGJ1ZmZlci4K Pgo+IEtlZXAgb25lIGZvdXJ0aCBvZiB0aGUgYnVmZmVyZWQgZGF0YSwgbW92aW5nIGl0IHRvIHRo ZSBzdGFydCBvZgo+IHRoZSBidWZmZXIsIGZyZWVpbmcgdGhlIHJlc3QgdG8gYmUgcmVmaWxsZWQg d2l0aCBmdXR1cmUgZGF0YS4KPgo+IEZvciBtb3YgZmlsZXMgd2l0aCBub25saW5lYXIgcmVhZCBw YXR0ZXJucywgdGhpcyBhbG1vc3QgZW50aXJlbHkKPiBhdm9pZHMgZG9pbmcgc2Vla3Mgb24gdGhl IGxvd2VyIElPIGxldmVsLCB3aGVyZSB3ZSBwcmV2aW91c2x5IHdvdWxkCj4gZW5kIHVwIGRvaW5n IHNlZWtzIG9jY2FzaW9uYWxseS4KCk1heWJlIHRoZSBkZW11eGVyIHNob3VsZCB1c2UgZmZpb19l bnN1cmVfc2Vla2JhY2soKSBpbnN0ZWFkIGlmIGl0IGtub3dzCnRoYXQgYSBzZWVrYmFjayB3aWxs IGhhcHBlbj8gVW5jb25kaXRpb25hbCBtZW1tb3ZlIG9mIGV2ZW4gZm91cnRoIG9mIGFsbCAKZGF0 YSBkb2VzIG5vdCBzZWVtIGxpa2UgYSBnb29kIGlkZWEuCgpSZWdhcmRzLApNYXJ0b24KCj4KPiBT aWduZWQtb2ZmLWJ5OiBNYXJ0aW4gU3RvcnNqw7YgPG1hcnRpbkBtYXJ0aW4uc3Q+Cj4gLS0tCj4g SSdtIG9wZW4gdG8gc3VnZ2VzdGlvbnMgb24gd2hldGhlciAxLzQgb2YgdGhlIGJ1ZmZlciBpcyBh IHJlYXNvbmFibGUKPiBhbW91bnQgdG8ga2VlcC4gSXQgZG9lcyBvZiBjb3Vyc2UgaW5jdXIgc29t ZSBhbW91bnQgb2Ygb3ZlcmhlYWQKPiBmb3Igd2VsbCBiZWhhdmVkIGxpbmVhciBmaWxlcywgYnV0 IGlzIGEgZGVjZW50IGltcHJvdmVtZW50IGZvcgo+IG5vbmxpbmVhciBtb3YgZmlsZXMuCj4KPiBB bHRlcm5hdGl2ZWx5IHdlIGNvdWxkIHRyaWdnZXIgdGhpcyBiZWhhdmlvdXIgb25seSBhZnRlciB3 ZSd2ZQo+IG9ic2VydmVkIGEgY291cGxlIHNlZWtzIGJhY2t3YXJkcz8KPiAtLS0KPiBsaWJhdmZv cm1hdC9hdmlvYnVmLmMgfCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tCj4gMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvbGliYXZmb3JtYXQvYXZpb2J1Zi5jIGIvbGliYXZmb3JtYXQvYXZp b2J1Zi5jCj4gaW5kZXggNGFkNzM0YTNjMy4uZGZjM2U3NzAxNiAxMDA2NDQKPiAtLS0gYS9saWJh dmZvcm1hdC9hdmlvYnVmLmMKPiArKysgYi9saWJhdmZvcm1hdC9hdmlvYnVmLmMKPiBAQCAtNTM0 LDggKzUzNCw3IEBAIHN0YXRpYyB2b2lkIGZpbGxfYnVmZmVyKEFWSU9Db250ZXh0ICpzKQo+ICAg ICBGRklPQ29udGV4dCAqY29uc3QgY3R4ID0gKEZGSU9Db250ZXh0ICopczsKPiAgICAgaW50IG1h eF9idWZmZXJfc2l6ZSA9IHMtPm1heF9wYWNrZXRfc2l6ZSA/Cj4gICAgICAgICAgICAgICAgICAg ICAgICAgICBzLT5tYXhfcGFja2V0X3NpemUgOiBJT19CVUZGRVJfU0laRTsKPiAtICAgIHVpbnQ4 X3QgKmRzdCAgICAgICAgPSBzLT5idWZfZW5kIC0gcy0+YnVmZmVyICsgbWF4X2J1ZmZlcl9zaXpl IDw9IHMtPmJ1ZmZlcl9zaXplID8KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICBzLT5idWZf ZW5kIDogcy0+YnVmZmVyOwo+ICsgICAgdWludDhfdCAqZHN0ICAgICAgICA9IHMtPmJ1Zl9lbmQ7 Cj4gICAgIGludCBsZW4gICAgICAgICAgICAgPSBzLT5idWZmZXJfc2l6ZSAtIChkc3QgLSBzLT5i dWZmZXIpOwo+Cj4gICAgIC8qIGNhbid0IGZpbGwgdGhlIGJ1ZmZlciB3aXRob3V0IHJlYWRfcGFj a2V0LCBqdXN0IHNldCBFT0YgaWYgYXBwcm9wcmlhdGUgKi8KPiBAQCAtNTQ2LDExICs1NDUsNDYg QEAgc3RhdGljIHZvaWQgZmlsbF9idWZmZXIoQVZJT0NvbnRleHQgKnMpCj4gICAgIGlmIChzLT5l b2ZfcmVhY2hlZCkKPiAgICAgICAgIHJldHVybjsKPiAKPiAtICAgIGlmIChzLT51cGRhdGVfY2hl Y2tzdW0gJiYgZHN0ID09IHMtPmJ1ZmZlcikgewo+IC0gICAgICAgIGlmIChzLT5idWZfZW5kID4g cy0+Y2hlY2tzdW1fcHRyKQo+ICsgICAgaWYgKGxlbiA8IG1heF9idWZmZXJfc2l6ZSAmJiBzLT5i dWZmZXJfc2l6ZSA+IG1heF9idWZmZXJfc2l6ZSkgewo+ICsgICAgICAgIC8qIElmIHRoZSBidWZm ZXIgaXMgYWxtb3N0IGZ1bGwgYW5kIHdlJ3JlIG5vdCB0cnlpbmcgdG8gcmVhZAo+ICsgICAgICAg ICAgIG9uZSB3aG9sZSBidWZmZXIgd29ydGggb2YgZGF0YSBhdCBvbmNlOyBrZWVwIHNvbWUgYW1v dW50IG9mCj4gKyAgICAgICAgICAgdGhlIGN1cnJlbnRseSBidWZmZXJlZCBkYXRhLCBidXQgbW92 ZSBpdCB0byB0aGUgc3RhcnQgb2YgdGhlCj4gKyAgICAgICAgICAgYnVmZmVyLCB0byBhbGxvdyBm aWxsaW5nIHRoZSBidWZmZXIgd2l0aCBtb3JlIGRhdGEuICovCj4gKyAgICAgICAgaW50IGtlZXAg PSAocy0+YnVmX2VuZCAtIHMtPmJ1ZmZlcikvNDsKPiArICAgICAgICBpbnQgc2hpZnQgPSBzLT5i dWZfZW5kIC0ga2VlcCAtIHMtPmJ1ZmZlcjsKPiArCj4gKyAgICAgICAgaWYgKHMtPnVwZGF0ZV9j aGVja3N1bSAmJiBzLT5jaGVja3N1bV9wdHIgLSBzLT5idWZmZXIgPCBzaGlmdCkgewo+ICsgICAg ICAgICAgICAvKiBDaGVja3N1bSB1cCB0byB0aGUgYnVmZmVyICsgc2hpZnQgcG9zaXRpb24gKHRo YXQgd2UncmUKPiArICAgICAgICAgICAgICAgc2hpZnRpbmcgb3V0IG9mIHRoZSBidWZmZXIuICov Cj4gICAgICAgICAgICAgcy0+Y2hlY2tzdW0gPSBzLT51cGRhdGVfY2hlY2tzdW0ocy0+Y2hlY2tz dW0sIHMtPmNoZWNrc3VtX3B0ciwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcy0+YnVmX2VuZCAtIHMtPmNoZWNrc3VtX3B0cik7Cj4gLSAgICAgICAgcy0+ Y2hlY2tzdW1fcHRyID0gcy0+YnVmZmVyOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzLT5idWZmZXIgKyBzaGlmdCAtIHMtPmNoZWNrc3VtX3B0cik7Cj4g KyAgICAgICAgfQo+ICsKPiArICAgICAgICBtZW1tb3ZlKHMtPmJ1ZmZlciwgcy0+YnVmX2VuZCAt IGtlZXAsIGtlZXApOwo+ICsgICAgICAgIHMtPmJ1Zl9lbmQgLT0gc2hpZnQ7Cj4gKyAgICAgICAg cy0+YnVmX3B0ciAtPSBzaGlmdDsKPiArICAgICAgICBpZiAocy0+dXBkYXRlX2NoZWNrc3VtKSB7 Cj4gKyAgICAgICAgICAgIGlmIChzLT5jaGVja3N1bV9wdHIgLSBzLT5idWZmZXIgPCBzaGlmdCkK PiArICAgICAgICAgICAgICAgIHMtPmNoZWNrc3VtX3B0ciA9IHMtPmJ1ZmZlcjsKPiArICAgICAg ICAgICAgZWxzZQo+ICsgICAgICAgICAgICAgICAgcy0+Y2hlY2tzdW1fcHRyIC09IHNoaWZ0Owo+ ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgZHN0ID0gcy0+YnVmX2VuZDsKPiArICAgICAgICBs ZW4gPSBzLT5idWZmZXJfc2l6ZSAtIChkc3QgLSBzLT5idWZmZXIpOwo+ICsgICAgfSBlbHNlIGlm IChsZW4gPCBtYXhfYnVmZmVyX3NpemUpIHsKPiArICAgICAgICAvKiBJZiB0aGUgYnVmZmVyIGlz IGZ1bGwgc28gd2UgY2FuJ3QgZml0IGEgd2hvbGUgd3JpdGUgb2YgbWF4X2J1ZmZlcl9zaXplLAo+ ICsgICAgICAgICAgIGp1c3QgcmVzdGFydCB0aGUgcG9pbnRlcnMgZnJvbSB0aGUgc3RhcnQgb2Yg dGhlIGJ1ZmZlci4gKi8KPiArICAgICAgICBkc3QgPSBzLT5idWZmZXI7Cj4gKyAgICAgICAgbGVu ID0gcy0+YnVmZmVyX3NpemU7Cj4gKwo+ICsgICAgICAgIGlmIChzLT51cGRhdGVfY2hlY2tzdW0p IHsKPiArICAgICAgICAgICAgLyogQ2hlY2tzdW0gYWxsIGRhdGEgdGhhdCBnZXRzIHNoaWZ0ZWQg b3V0IG9mIHRoZSBidWZmZXIuICovCj4gKyAgICAgICAgICAgIGlmIChzLT5idWZfZW5kID4gcy0+ Y2hlY2tzdW1fcHRyKQo+ICsgICAgICAgICAgICAgICAgcy0+Y2hlY2tzdW0gPSBzLT51cGRhdGVf Y2hlY2tzdW0ocy0+Y2hlY2tzdW0sIHMtPmNoZWNrc3VtX3B0ciwKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHMtPmJ1Zl9lbmQgLSBzLT5jaGVja3N1 bV9wdHIpOwo+ICsgICAgICAgICAgICBzLT5jaGVja3N1bV9wdHIgPSBzLT5idWZmZXI7Cj4gKyAg ICAgICAgfQo+ICAgICB9Cj4KPiAgICAgLyogbWFrZSBidWZmZXIgc21hbGxlciBpbiBjYXNlIGl0 IGVuZGVkIHVwIGxhcmdlIGFmdGVyIHByb2JpbmcgKi8KPiAtLSAKPiAyLjM3LjEgKEFwcGxlIEdp dC0xMzcuMSkKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdAo+IGZmbXBlZy1kZXZlbEBmZm1wZWcub3Jn Cj4gaHR0cHM6Ly9mZm1wZWcub3JnL21haWxtYW4vbGlzdGluZm8vZmZtcGVnLWRldmVsCj4KPiBU byB1bnN1YnNjcmliZSwgdmlzaXQgbGluayBhYm92ZSwgb3IgZW1haWwKPiBmZm1wZWctZGV2ZWwt cmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGlu ZyBsaXN0CmZmbXBlZy1kZXZlbEBmZm1wZWcub3JnCmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ZmbXBlZy1kZXZlbAoKVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUs IG9yIGVtYWlsCmZmbXBlZy1kZXZlbC1yZXF1ZXN0QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1 bnN1YnNjcmliZSIuCg==