From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC17046318 for ; Fri, 12 Jan 2024 20:46:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4459168CCE5; Fri, 12 Jan 2024 22:46:51 +0200 (EET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C0FC268BA47 for ; Fri, 12 Jan 2024 22:46:44 +0200 (EET) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50e766937ddso7856791e87.3 for ; Fri, 12 Jan 2024 12:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705092403; x=1705697203; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=s6uQs7A6Q9E44bT3khtAEnm7HnVuYfznYd/W7Ov7gGU=; b=I4gN+cu94EiVr6lhjLMO9yj2S8eoBRB4FkKRq8I/EbRnREL5UPqnaTWwqo+/B0/luK t0aYlBRxPbqQvSklKe6ZiEbzjRCkE8OxEe3vgLJCi/txtJkOHajg+POPdTu6NuPwdLmw cOrwJENrrrwJiCO6gDtPDDbgU3Qb5/xYW6V5pbZDKYPOS2sPyuVVPXJyqKlsB1b/ag9s E8/ePwUvfBuBiSBTtyZlEWsQJjAra27BAYrLzVYFGRKd4tMRJ8RZj/TJdlmRzktmzmYh tAVqMvpy96c0chJh1qqSA6I1Tye5a+g/H0RzcQPDbocLRg1YnMqTn6haQICL3OnfNRG/ s/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705092403; x=1705697203; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s6uQs7A6Q9E44bT3khtAEnm7HnVuYfznYd/W7Ov7gGU=; b=Im+X3zCy/KACJj2zNuH+cmbLfBs7C7m2KD02MourDKYgRGvOh7epVNNnGyf+wQZ4mf Q/IYJ/l2LjSfPJA41cM+p4VMs8bWxAlfHStQDR6iKNRSIva5UGfeNjJ1wXoEoHZQteP3 bTN+XtDFqgI7RvfFAd86fpl62ondf9Rn2+9ff29qO//J4Mx2J1UzSqONJgzj1jtyI514 fUB7Ek91TXDxAMFAHtP537MM4DZ8ikR28pzQAdbjqjnRBqx7cH5RF0P0LJCjp7PTMuXM bfAWOtpjcBsJK3+nnYrXS1pTJIQdeCfcwMRk03gn72XfIDYOcFnVg3nlPon4GkCWi7wt GHQQ== X-Gm-Message-State: AOJu0YyYAJePWfY2Kv2K2fXuwWFYJghen4uz/MornoMAxn6FcsRS6OuB dD9f81ToyCB8OhZ48pTF+xIgvOp7HB4= X-Google-Smtp-Source: AGHT+IGXb02kgsDR8ppxePx1hIIuZQOVTUVgdo7fVq2ErggN1MmDDkldtR5EAsOFq78/+lzxDWzATQ== X-Received: by 2002:a05:6512:1112:b0:50e:e8f0:1d42 with SMTP id l18-20020a056512111200b0050ee8f01d42mr865595lfg.119.1705092402673; Fri, 12 Jan 2024 12:46:42 -0800 (PST) Received: from [192.168.0.180] ([77.222.158.233]) by smtp.gmail.com with ESMTPSA id tb17-20020a1709078b9100b00a2ca5207157sm1292763ejc.63.2024.01.12.12.46.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 12:46:42 -0800 (PST) Message-ID: <4c74ce27-ee9a-4315-903f-d971dc63cf5b@gmail.com> Date: Fri, 12 Jan 2024 22:46:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Paul Orlyk To: ffmpeg-devel@ffmpeg.org References: <20231228193329.GV6420@pb2> <20240112190710.GZ6420@pb2> Content-Language: en-US In-Reply-To: <20240112190710.GZ6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix server compatibility issues with rtspclientsink GStreamer plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/12/24 21:07, Michael Niedermayer wrote: > On Wed, Jan 03, 2024 at 02:51:36PM +0200, Paul Orlyk wrote: >> On 12/28/23 21:33, Michael Niedermayer wrote: >>> On Wed, Dec 27, 2023 at 03:44:09PM +0200, Paul Orlyk wrote: >>>> mode field in Transport header can be sent in upper case so make string >>>> comparison case insensitive. >>>> Also, GStreamer expects to see mode=record instead of mode=receive in >>>> Transport header in response. >>>> >>>> Signed-off-by: Paul Orlyk >>>> --- >>>> libavformat/rtsp.c | 4 ++-- >>>> libavformat/rtspdec.c | 4 ++-- >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c >>>> index 583f5338e8..61e24a5c7a 100644 >>>> --- a/libavformat/rtsp.c >>>> +++ b/libavformat/rtsp.c >>>> @@ -1012,8 +1012,8 @@ static void rtsp_parse_transport(AVFormatContext *s, >>>> if (*p == '=') { >>>> p++; >>>> get_word_sep(buf, sizeof(buf), ";, ", &p); >>>> - if (!strcmp(buf, "record") || >>>> - !strcmp(buf, "receive")) >>>> + if (!av_strcasecmp(buf, "record") || >>>> + !av_strcasecmp(buf, "receive")) >>>> th->mode_record = 1; >>>> } >>>> } >>>> diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c >>>> index 39fd92fb66..d6a223cbc6 100644 >>>> --- a/libavformat/rtspdec.c >>>> +++ b/libavformat/rtspdec.c >>>> @@ -303,7 +303,7 @@ static int rtsp_read_setup(AVFormatContext*s, char* >>>> host, char *controlurl) >>>> rtsp_st->interleaved_min = request.transports[0].interleaved_min; >>> patch is damaged by linebreaks >>> >>> >>> [...] >> >> >> Sorry for that. Please find it attached. > >> rtsp.c | 4 ++-- >> rtspdec.c | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> 8ed5709b8c5cb30aeaa18d609b86b9be0557a06e 0001-avformat-rtsp-Fix-server-compatibility-issues-with-r.patch >> From 156ceeded6cd076b781205adc034144186a9a7ea Mon Sep 17 00:00:00 2001 >> From: Paul Orlyk >> Date: Wed, 27 Dec 2023 15:30:20 +0200 >> Subject: [PATCH] avformat/rtsp: Fix server compatibility issues with >> rtspclientsink GStreamer plugin >> >> mode field in Transport header can be sent in upper case so make string comparison case insensitive. > >> Also, GStreamer expects to see mode=record instead of mode=receive in Transport header in response. > > It appears to me that these are 2 seperate issues ? > if its 2 patches, i can apply the av_strcasecmp(). Essentially they are. I combined them in the context of GStreamer compatibility. Would it be better at this point to send them separately? > > For the receive vs record i would prefer to see some quote from a RFC instead > of just an implementation > > thx > > [...] Regarding receive vs record: RFC 7826 "Real-Time Streaming Protocol Version 2.0" (https://datatracker.ietf.org/doc/html/rfc7826), section 18.54: mode: The mode parameter indicates the methods to be supported for this session. The currently defined valid value is "PLAY". If not provided, the default is "PLAY". The "RECORD" value was defined in RFC 2326; in this specification, it is unspecified but reserved. RECORD and other values may be specified in the future. RFC 2326 "Real Time Streaming Protocol (RTSP)" (https://datatracker.ietf.org/doc/html/rfc2326), section 12.39: mode: The mode parameter indicates the methods to be supported for this session. Valid values are PLAY and RECORD. If not provided, the default is PLAY. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".