From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9F9AC4C622 for ; Mon, 4 Aug 2025 07:06:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id CDF7468BCA6; Mon, 4 Aug 2025 10:06:20 +0300 (EEST) Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0ECAB68A114 for ; Mon, 4 Aug 2025 10:06:12 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:To:Subject:Content-Type:MIME-Version: Message-ID; bh=Z2Z4QehL5GpxQSgkeQEthrXqrQxRDjvPl+ZvT96GrZ0=; b=l sWHnmDkeqTeTW135VG2En8uFuE7a+c1cSuN/m75mc8uyavyDU0RA5vwqT3pUI7KV R4WJnpDbUv/96ow6wdvZVpLD7P663IcYWuku8+Pyk6jcQ1rxnUJgTguqeEpf08IP Ipa5WQagetkJ4pMag5M9DYJCVDR9JCHx8jb2JT22wM= Received: from caifan0425$163.com ( [1.202.162.52] ) by ajax-webmail-wmsvr-40-107 (Coremail) ; Mon, 4 Aug 2025 15:06:05 +0800 (CST) X-Originating-IP: [1.202.162.52] Date: Mon, 4 Aug 2025 15:06:05 +0800 (CST) From: "Cai Fan" To: "FFmpeg development discussions and patches" , michael@niedermayer.cc X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.14 build 20250519(9504565a) Copyright (c) 2002-2025 www.mailtech.cn 163com In-Reply-To: <20250803225700.GK29660@pb2> References: <20250731021339.2955179-1-caifan0425@163.com> <20250731082135.3114297-1-caifan0425@163.com> <20250803225700.GK29660@pb2> X-NTES-SC: AL_Qu2eBv6Svkkt4yeZZekfmUkQh+o5Xca0vvkm1YNVPZ14jCHp8CE8QXNTLUDr0cWDIAGKkAiHXRhx5N9HXLRTZowM887wmiPZZBgzJnAhnXzvgg== MIME-Version: 1.0 Message-ID: <4c02d37b.5a99.19873e6da14.Coremail.caifan0425@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: aygvCgD3F8zdW5BoGcoRAA--.35243W X-CM-SenderInfo: xfdlwtrqqujki6rwjhhfrp/1tbiPR+fuWiQUv6iWAADsp X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] =?gbk?q?=5BPATCH_v2_1/1=5D_libavformat/img2enc=2E?= =?gbk?q?c=3A_rm_warning_=A1=AE=2Etmp=A1=AF_directive_output_may_be_trunca?= =?gbk?q?ted?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, Thank you for the suggestion. The tmp field in VideoMuxData is a fixed-size embedded array (char tmp[4][1024]), not a pointer. This makes using av_asprintf() not suitable. typedef struct VideoMuxData { const AVClass *class; /**< Class for private options. */ int start_img_number; int img_number; int split_planes; char tmp[4][1024]; // Fixed-size buffer within the struct char target[4][1024]; int update; int use_strftime; int frame_pts; const char *muxer; int use_rename; AVDictionary *protocol_opts; } VideoMuxData; VideoMuxData *img = s->priv_data; At 2025-08-04 06:57:00, "Michael Niedermayer" wrote: >On Thu, Jul 31, 2025 at 04:21:35PM +0800, Cai Fan wrote: >> Signed-off-by: Cai Fan >> --- >> libavformat/img2enc.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c >> index 41638d92b8..9a5718a8da 100644 >> --- a/libavformat/img2enc.c >> +++ b/libavformat/img2enc.c >> @@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt) >> } >> for (i = 0; i < 4; i++) { >> av_dict_copy(&options, img->protocol_opts, 0); >> - snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename); >> + int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename); >> + if (len < 0 || len >= sizeof(img->tmp[i])) { >> + av_log(s, AV_LOG_ERROR, "filename '%s' exceeds buffer size %zu\n", filename, sizeof(img->tmp[i])); >> + ret = AVERROR(EINVAL); >> + goto fail; >> + } > >is there a reason this doesnt use av_asprintf() ? >that is allocate as needed > >thx > >[...] >-- >Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > >No great genius has ever existed without some touch of madness. -- Aristotle _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".