From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 82EAE45D01 for ; Tue, 4 Apr 2023 14:57:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A083168B4BB; Tue, 4 Apr 2023 17:57:10 +0300 (EEST) Received: from 7.mo582.mail-out.ovh.net (7.mo582.mail-out.ovh.net [46.105.59.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B84A968B104 for ; Tue, 4 Apr 2023 17:57:04 +0300 (EEST) Received: from director1.ghost.mail-out.ovh.net (unknown [10.108.16.135]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 06EAF23EE9 for ; Tue, 4 Apr 2023 14:57:03 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-n6zng (unknown [10.110.171.164]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id A3C251FE50 for ; Tue, 4 Apr 2023 14:57:03 +0000 (UTC) Received: from mediaarea.net ([37.59.142.107]) by ghost-submission-6684bf9d7b-n6zng with ESMTPSA id TYrDIL86LGRF2gQAMT1Xug (envelope-from ) for ; Tue, 04 Apr 2023 14:57:03 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S0017588dadb-317f-4363-a203-bdb4ffb76d99, 8A542822168A0A136783BE1ED24AF467455C0BD4) smtp.auth=zen-lists@mediaarea.net X-OVh-ClientIp: 84.143.149.1 Content-Type: multipart/mixed; boundary="------------RBA8tAQ7Vi5m6F8UJTEBMrCL" Message-ID: <4bcc6a3e-d0c8-f7ce-0620-7e9e9e745a5f@mediaarea.net> Date: Tue, 4 Apr 2023 16:57:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <09775b73ab48e425f3b557aaa8d5847643ebe9b7.camel@haerdin.se> <0b6c3856-082c-cb33-e07c-3adf0502b93c@mediaarea.net> <20230401143739.GD1164690@pb2> <85c1e58e-cc90-5814-cba5-d91201dec993@mediaarea.net> <20230401154301.GF1164690@pb2> <71eaedd7-d771-50a7-ed13-3733b8c2187f@mediaarea.net> <20230402200740.GK1164690@pb2> <7291a984-856c-3cd4-483f-f55f13af6be2@mediaarea.net> <20230404144355.GU1164690@pb2> From: Jerome Martinez In-Reply-To: <20230404144355.GU1164690@pb2> X-Ovh-Tracer-Id: 4233102178428356857 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiledgkedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpegtkfffgggfuffvfhfhjgesmhdtreertdefjeenucfhrhhomheplfgvrhhomhgvucforghrthhinhgviicuoehjvghrohhmvgesmhgvughirggrrhgvrgdrnhgvtheqnecuggftrfgrthhtvghrnhepgeelgfelieevgfdvgfevkeeivddvkeejteeugffgvdehheejheekueegvdejhfdunecukfhppeduvdejrddtrddtrddupdekgedrudegfedrudegledruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehjvghrohhmvgesmhgvughirggrrhgvrgdrnhgvtheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrghdpoffvtefjohhsthepmhhoheekvddpmhhouggvpehsmhhtphhouhht Subject: Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------RBA8tAQ7Vi5m6F8UJTEBMrCL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/04/2023 16:43, Michael Niedermayer wrote: > On Mon, Apr 03, 2023 at 12:07:06AM +0200, Jerome Martinez wrote: >> On 02/04/2023 22:07, Michael Niedermayer wrote: >> >> + if (f->version == 4 && f->micro_version > 2) { >> + av_log(f->avctx, AV_LOG_ERROR, "unsupported version 4 micro_version %d\n", >> + f->micro_version); >> + return AVERROR_PATCHWELCOME; >> + } >> } >> f->ac = get_symbol(c, state, 0); > you do not know if the decoder will have any problem with these files But you don't don't if the decoder will have no problem, it seems safer to me to reject something we are not sure to support. Anyway, I don't really care (the decoder will just fail later if it is not compatible + it is explicitly flagged as experimental), attached is a version without the micro_version check. > [...] Jérôme --------------RBA8tAQ7Vi5m6F8UJTEBMrCL Content-Type: text/plain; charset=UTF-8; name="0001-avcodec-ffv1dec-reject-unsupported-ffv1-versions.patch" Content-Disposition: attachment; filename*0="0001-avcodec-ffv1dec-reject-unsupported-ffv1-versions.patch" Content-Transfer-Encoding: base64 RnJvbSBkYzAzODI3MDllNTQ4ZWYyNTE0MTk4YmM4NjYwMjgwNjYxMzRkMzNlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJvbWUgTWFydGluZXogPGplcm9tZUBtZWRpYWFy ZWEubmV0PgpEYXRlOiBNb24sIDMgQXByIDIwMjMgMDA6MDQ6NTMgKzAyMDAKU3ViamVjdDog W1BBVENIXSBhdmNvZGVjL2ZmdjFkZWM6IHJlamVjdCB1bnN1cHBvcnRlZCBmZnYxIHZlcnNp b25zCgpBbmQgYWRkIHNpbWlsYXIgY2hlY2sgaW4gbGliYXZmb3JtYXQvbXhmZW5jCi0tLQog bGliYXZjb2RlYy9mZnYxZGVjLmMgfCA1ICsrKysrCiBsaWJhdmZvcm1hdC9teGZlbmMuYyB8 IDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg YS9saWJhdmNvZGVjL2ZmdjFkZWMuYyBiL2xpYmF2Y29kZWMvZmZ2MWRlYy5jCmluZGV4IDE4 MGQyNGU2OTUuLmEzZjkzMDIyMzMgMTAwNjQ0Ci0tLSBhL2xpYmF2Y29kZWMvZmZ2MWRlYy5j CisrKyBiL2xpYmF2Y29kZWMvZmZ2MWRlYy5jCkBAIC00MzksNiArNDM5LDExIEBAIHN0YXRp YyBpbnQgcmVhZF9leHRyYV9oZWFkZXIoRkZWMUNvbnRleHQgKmYpCiAgICAgICAgIGF2X2xv ZyhmLT5hdmN0eCwgQVZfTE9HX0VSUk9SLCAiSW52YWxpZCB2ZXJzaW9uIGluIGdsb2JhbCBo ZWFkZXJcbiIpOwogICAgICAgICByZXR1cm4gQVZFUlJPUl9JTlZBTElEREFUQTsKICAgICB9 CisgICAgaWYgKGYtPnZlcnNpb24gPiA0KSB7CisgICAgICAgIGF2X2xvZyhmLT5hdmN0eCwg QVZfTE9HX0VSUk9SLCAidW5zdXBwb3J0ZWQgdmVyc2lvbiAlZFxuIiwKKyAgICAgICAgICAg IGYtPnZlcnNpb24pOworICAgICAgICByZXR1cm4gQVZFUlJPUl9QQVRDSFdFTENPTUU7Cisg ICAgfQogICAgIGlmIChmLT52ZXJzaW9uID4gMikgewogICAgICAgICBjLT5ieXRlc3RyZWFt X2VuZCAtPSA0OwogICAgICAgICBmLT5taWNyb192ZXJzaW9uID0gZ2V0X3N5bWJvbChjLCBz dGF0ZSwgMCk7CmRpZmYgLS1naXQgYS9saWJhdmZvcm1hdC9teGZlbmMuYyBiL2xpYmF2Zm9y bWF0L214ZmVuYy5jCmluZGV4IDBhMWFlNTM1M2MuLmRmNWJiNTVhZDggMTAwNjQ0Ci0tLSBh L2xpYmF2Zm9ybWF0L214ZmVuYy5jCisrKyBiL2xpYmF2Zm9ybWF0L214ZmVuYy5jCkBAIC0y NDkzLDYgKzI0OTMsMTAgQEAgc3RhdGljIGludCBteGZfcGFyc2VfZmZ2MV9mcmFtZShBVkZv cm1hdENvbnRleHQgKnMsIEFWU3RyZWFtICpzdCwgQVZQYWNrZXQgKnBrdCkKICAgICAgICAg ICAgIGF2X2xvZyhzLCBBVl9MT0dfRVJST1IsICJJbnZhbGlkIHZlcnNpb24gaW4gZmZ2MSBn bG9iYWwgaGVhZGVyXG4iKTsKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICB9Cisg ICAgICAgIGlmICh2ID4gNCkgeworICAgICAgICAgICAgYXZfbG9nKHMsIEFWX0xPR19FUlJP UiwgInVuc3VwcG9ydGVkIGZmdjEgdmVyc2lvbiAlZFxuIiwgdik7CisgICAgICAgICAgICBy ZXR1cm4gMDsKKyAgICAgICAgfQogICAgICAgICBzYy0+bWljcm9fdmVyc2lvbiA9IGdldF9m ZnYxX3Vuc2lnbmVkX3N5bWJvbCgmYywgc3RhdGUpOwogICAgIH0gZWxzZSB7CiAgICAgICAg IHVpbnQ4X3Qga2V5c3RhdGUgPSAxMjg7Ci0tIAoyLjEzLjMud2luZG93cy4xCgo= --------------RBA8tAQ7Vi5m6F8UJTEBMrCL Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------RBA8tAQ7Vi5m6F8UJTEBMrCL--