From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 667EB43D8A for ; Mon, 9 Jan 2023 02:22:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C732168BBA3; Mon, 9 Jan 2023 04:22:14 +0200 (EET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7587268B14C for ; Mon, 9 Jan 2023 04:22:08 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673230933; x=1704766933; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SKfc1l9hN3GE4vpnhBbcJ0M82b/PlzqoY7oCmQxzmMo=; b=WSK5P4fUQEUfOxOJGw+FZUpsx7VYdi8ELUIMkQOkklgHgq5B+RiCdwQ4 E59RTeBocVIh1oyD9+s5WNJ1ZPrsQzDKi/dr4WcrmMZMISX2Wu0mttf1q vzZ2PITMlia7IUcDM3r6+bkcZlbu5MPYS9n2HaRb1Th2Sl+5z+LYPtbl7 JtV0Qj0U9kf3QFvKffwVyuOJvqToHGch9Z+VjR5+/wDawNlFpHHqHOy+u t7JgH0oiIWx+eSd2FxNfzm877+bsXA1+exjnvkjhtws2ISQP6zJEty1pg ozqwBe8wGak6OKZESKAinpHRzcBqmIvkCKOAfxWrlVS+s4u1Eu6BRW7mL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="324026590" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="324026590" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2023 18:22:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="634052976" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="634052976" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 08 Jan 2023 18:22:05 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 8 Jan 2023 18:22:04 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 8 Jan 2023 18:22:04 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 8 Jan 2023 18:22:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OfAINuZrbC88t87bMQe8Pq6AB56+dZ1rqgrbL8r9Wuqoz5kYMP2tlhk+8Mh+KlKIAYE/SBe1Npcm7xA36vvGnt0/GGq+KJpqEe11QiZIIJT10U993CzFPxSNQnVQN8qUoRI8KDjauDZt3NNyCG5NSsllcXGbtGBFXzWIuIYEmVN2lOlGYeVsQE8fpzBwyoTvi42504XH2CFiQ3vZFg2uUruF6LNqGqooPFV38IKKD/WEINDTY26Zw19imlnWntKEFJ+MwFJqccnrx7MOYpw1+ANScrUu1gumhNk4oRZrxlRi3+s0TCRDs2kqXGLamMZszKGDJIFgjQ7HMPewaZsGtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SKfc1l9hN3GE4vpnhBbcJ0M82b/PlzqoY7oCmQxzmMo=; b=XYM05W38zteiM0txYSfsedM4erjlHYw1Fx837q9vvUey/axvsbgR9euH438ZsH6oHGi+vqDeoUFgTPkCx9p4+tmMH/JARw3OK+LJP7TmbRkQ9Bb1AA70CK6oTnq/0kSH3YzEtdH02JpOmJi4xxhVQFaf6SlSTXDyB14uYkDoCt7OtIioYDTeei2UoP76hDvdQ8EC3ALPb5hhXb3wXYIvtElXKYzppO1kVgGt4Vr5X4F/4o7fsaYGH7yrWMJxW9kYaHE/4kxy0i8s1WtUzLkQTEMdhic+BYFeWMWSgDQkmEfk6pOsZSAQyCjnEaEjvCOdpSNFYFNxlpvUbDmSLLakYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SA1PR11MB6893.namprd11.prod.outlook.com (2603:10b6:806:2b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 02:22:02 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%4]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 02:22:02 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames Thread-Index: AQHZG8twscbVz5XTakOuIwIEcfd0xa6VarcA Date: Mon, 9 Jan 2023 02:22:02 +0000 Message-ID: <4b82107f2055a9a784fbf97fe8838ce9349534b7.camel@intel.com> References: <20221229212024.422950-1-nowrep@gmail.com> In-Reply-To: <20221229212024.422950-1-nowrep@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|SA1PR11MB6893:EE_ x-ms-office365-filtering-correlation-id: beba60ad-ecbb-44b3-d6ed-08daf1e84b41 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9HjUrjK+3J0sjCZUN7FVg3pfVVHpRyp3v4XEEyImxOWAAKuDGJHw6RHwLk8TUInC4CA/37VRNYR1YOMaPWAI85X0jwotTEFv4zAmpJv9MQD51h3s9ua7M0xHuFs2/5+KLUBmS4WnA0aq2J/Fi6SumAGO+OEjXb4Iuh8s01G44JjRzcwjsKdkX6NfCdbRdz7bTDBPZ/qgj1oZXcGV/Etw6aNVsccxlyf4Jh526ncIlHgdMB8mdmm2dvindsmq8qG2by4QkwFzQtAp69MJzvXtpfuXkl1mGAtaVExgv5ERjvjbCPo6P9yN4BfyY5Rg0XHQs0/UmSQ6oJox3JRvKgRtU05xOvlXhy7mmQJJTiHMf7NQnp+Xq/ddeI3rH5hWFy1JrmbeCvBdwmx+8/N4ACbOW+UncgiwvUAysFHLCAYbICf2AGmZu0pv/HRKHDmwF4q+/Sdkdz57hNo9DnCsC6DLwcLyGhIjlHX3IKGjezeZFFxTGHeIyIwYRRaJVUcrLyT3vNnLkfZnTNboakpTAwJCDStAxLwMSObVyxqubYpEnhTlFWqZpPmxiyk203SyH+CTqj/cDHctWUVU6WlcJUKHyB31LxR5u1/AXvFmSbIAlPESZIdC14Y0vcaKfUyg3oZn0LwdrnWOrxGT4eTVACkcs/TP2cK+aXDANkZmCDPkeXFpf05RGiR+PBb/hlxFesTWvFkQrluLfigLeYd9jGsqow== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(26005)(186003)(86362001)(6512007)(4744005)(8676002)(66446008)(64756008)(66556008)(66476007)(4326008)(83380400001)(91956017)(8936002)(66946007)(76116006)(71200400001)(36756003)(5660300002)(2616005)(2906002)(478600001)(316002)(6916009)(41300700001)(38070700005)(6506007)(38100700002)(122000001)(6486002)(82960400001)(4001150100001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZTZJZ3EyeEVoc05NbHNBTzgyRG9sS2pBaFJoQlNCVnI3cmZvby9iTDd0OEt2?= =?utf-8?B?TkMwZmd1cHZ3Y1BiR0xhNGlLYlg3UFFGWDBWc0tRZnZtWDZpNzFRRUFEckpm?= =?utf-8?B?VURreWhrZVY1WW9DTkRkcFc2ZkpPRWl0dVVFOHRibE1pc2ZNV2V1QTMxUG1Z?= =?utf-8?B?ZnNLUy84UDF5MS9teEVlQUVHSGthUnNqbnhSeFRFb1prdGVKb1doNkJvbjlz?= =?utf-8?B?Y3FyUVdHSHlpWjJQUjVudVhidDRvRDNSSWNEN3ZvZ0xmTGFCM1BJY2dTL09a?= =?utf-8?B?bjJvdVM1dC92bWhBZDNjSXcrdis1WU45Tm9aY2tiT05PYlB3YVh0RGUwaCt5?= =?utf-8?B?NXlGaEN2VFg3cnJMWnllZDFteCtHWkIxNmpGWmIzNEM5RnZwc2dFbkhEM0h2?= =?utf-8?B?WEh5ZTAwWEVJL0lsa0ZldjM2RjNTSFFJNGE3ajYyalJ0WVgrZjlyaVpOVUk1?= =?utf-8?B?Q05xanQydkFLcG83UGIyT0gzV2FhWG4xYW9QSWEyQkppTTl5WDM0amxxVmZU?= =?utf-8?B?aktzeXpDcFdyU2NpMTVNMFdRcmVCb21KcVVGZDR0VXorWkpPY0hYcE5XR0xa?= =?utf-8?B?QjlUdmQzTXR3TktNNDVPN1JPQy9LSU12dUxrVHBGeEtEblJPYnFZalRybHFu?= =?utf-8?B?Y3p4OXZ6THo2eEtnbVhZUmlMaTZkWFpPRmJsamkvWFVBTTZLRmtueVN3ZlRh?= =?utf-8?B?VG5WdUxhWWNqMkUvV1lHSUtwMWloQmZ2VzBBL3NDMUxBazA4UmZaY2hjYUE5?= =?utf-8?B?c05WL2t3WXAzNUkxUnJrQm9YdFhDRjYyT3hCOHZmd25ycjVqbElJcEszcjJG?= =?utf-8?B?eFBEa3Vhb3hQbW5HNVpyNXZ4Vjdta1dyYnhLcTJRZjhCZ01FZk9qRHpsblRq?= =?utf-8?B?dyt2b2RQL1EwVDJ1d1hGdHJwZTRKc1RYQ3Y3THlDR1dhMkNJWWJ1VHozZ3Ey?= =?utf-8?B?Z0ZGRlJRaEVDdE55aVdDbUpnL2NsSkErcnVpMWo2Y0VIWUYwc1loQ0xDUjdU?= =?utf-8?B?S0gxMFBhQUZNU1o3b0s0allVRjlUSlh2SVBUZWdjMG9LQWtlck11ZWo0Zk45?= =?utf-8?B?ZkcwMEtabXZqSEpXOGtUUkVkYVNKTDdOYmVyWXBFOTZUV0ROeEZwY012R3di?= =?utf-8?B?VkdUUytNSVZjaSt2ZW1ReWl5OVFpbTdFM3RrZXNPVVVxK2JnVFFQVk9BcThL?= =?utf-8?B?S2hBRTVsRDB2Wld2b1I1eVZXR3djL21WVU1CL1R5ZjVqMFpXQkovMUZ1WGFE?= =?utf-8?B?YWd6bFYxaFozS1FNK0t0YWw4NTFkNEpVbjBzaFdoOW5kNVg1eHFkOUlOM3NR?= =?utf-8?B?TldtMi9Pd1RuNWYxMm9raS8wVkxTTmV0THdYelM0L25pUWtwa0loNmVNZi9E?= =?utf-8?B?UHN0L290YlBmYUFqeFJDRHpsVUVpaG03Vm1xSUFCY0dicUZ4eFR5M2xSckFV?= =?utf-8?B?S2NlcUJKeWVxWTVoS1JzMkxMSktyZGtVL2p0d2JLYjZ3ZEVWbmFmM3RBVzF5?= =?utf-8?B?ZFBnZE43QzJkbjU0NGJjUVlzYmFONHdqUit3bE1QM3BtK1ZTbXBxVDZCWTZt?= =?utf-8?B?bzkrMmhRcXZlWWcrbEpLcXZPTVZTY0RPbXIzQW40UHN2emFmTFRpTnJGV3Bt?= =?utf-8?B?RnJhbmM1aURzNndoaVRUZml4V3lrYW9RWlFLRHdRVEg0RUpmSEQzL2NBZ0RQ?= =?utf-8?B?YkpkTWRVaVR5K2JYNktMZ3NEbVA4RXgyK05hMUF3V2pWVEh5bkl5Y3liVjJB?= =?utf-8?B?dVhhUEpLTWpjUVVLZXJvWUZvNDVWdnd4bG85T1hFWEtwN05LYUlCQkdPZVR3?= =?utf-8?B?WW44NjhpS2tmdzdvMkxmODEvYldGUlYxR04rNjVaWGcrNmU1cklUWUJvc2xy?= =?utf-8?B?VmdQMzZ0REpGRXpaTGtOVVYxVzFqNzNPeEhXTXB2TEUrTkgraVUycjVGdkN0?= =?utf-8?B?OTNKMXp3V2FyS1FsQS8xZEU0K3kvVWY5M1JZVCs3Nlk5Z0pTeXQxekZaNTNo?= =?utf-8?B?aWVUdlJ4MVZqMmJRSkI0ellJT1pxY2xYaTFZNmlRYlIyc1V3VWlzNWZWMURi?= =?utf-8?B?VWtzM24xT0hhUFBKVWpQV0dDTXd1K2wzTFB3SWk3LzFCYlZkK3NxVlNqY1d1?= =?utf-8?B?UUNKd0d2UUMwYmJDS0V3ejEzM092TFVQZlRqVk8wTjV5bytCSDBFR1NJUnhp?= =?utf-8?B?bmc9PQ==?= Content-ID: <8E33B2ED56B00643A3054F5B2EB1F36D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beba60ad-ecbb-44b3-d6ed-08daf1e84b41 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 02:22:02.3503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Azn3OmqJGmGa+4NGTzF0ev/riD2bOkAhkGY3GRi6wBogDQ8ya7gnNfwLkiJ1LU2q+vB3CxsPxtY6SHeNs7z6vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6893 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "nowrep@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote: > --- > libavcodec/vaapi_encode_h264.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index dd17be2..d6926c4 100644 > --- a/libavcodec/vaapi_encode_h264.c > +++ b/libavcodec/vaapi_encode_h264.c > @@ -350,7 +350,7 @@ static int > vaapi_encode_h264_init_sequence_params(AVCodecContext *avctx) > sps->chroma_format_idc = 1; > > sps->log2_max_frame_num_minus4 = 4; > - sps->pic_order_cnt_type = 0; > + sps->pic_order_cnt_type = ctx->max_b_depth ? 0 : 2; pic_order_cnt_type (0) should work for ctx->max_b_depth == 0. If 2 is preferred for your vaapi driver, it would be better to query the capability from the driver, like as what commit 9f02e033875185409c861846f209b04a3be339d2 did. Thanks Haihao > sps->log2_max_pic_order_cnt_lsb_minus4 = 4; > > sps->max_num_ref_frames = priv->dpb_frames; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".