From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "nowrep@gmail.com" <nowrep@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames
Date: Mon, 9 Jan 2023 02:22:02 +0000
Message-ID: <4b82107f2055a9a784fbf97fe8838ce9349534b7.camel@intel.com> (raw)
In-Reply-To: <20221229212024.422950-1-nowrep@gmail.com>
On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote:
> ---
> libavcodec/vaapi_encode_h264.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
> index dd17be2..d6926c4 100644
> --- a/libavcodec/vaapi_encode_h264.c
> +++ b/libavcodec/vaapi_encode_h264.c
> @@ -350,7 +350,7 @@ static int
> vaapi_encode_h264_init_sequence_params(AVCodecContext *avctx)
> sps->chroma_format_idc = 1;
>
> sps->log2_max_frame_num_minus4 = 4;
> - sps->pic_order_cnt_type = 0;
> + sps->pic_order_cnt_type = ctx->max_b_depth ? 0 : 2;
pic_order_cnt_type (0) should work for ctx->max_b_depth == 0. If 2 is preferred
for your vaapi driver, it would be better to query the capability from the
driver, like as what commit 9f02e033875185409c861846f209b04a3be339d2 did.
Thanks
Haihao
> sps->log2_max_pic_order_cnt_lsb_minus4 = 4;
>
> sps->max_num_ref_frames = priv->dpb_frames;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-09 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 21:20 David Rosca
2023-01-09 2:22 ` Xiang, Haihao [this message]
2023-01-09 7:37 ` David Rosca
2023-01-09 21:10 ` Mark Thompson
2023-01-10 8:24 ` David Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b82107f2055a9a784fbf97fe8838ce9349534b7.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=nowrep@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git