[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: Actually use X2->RGBA64 conversions

[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: Actually use X2->RGBA64 conversions

[Andreas Rheinhardt]

[-- Attachment #1: Type: text/plain, Size: 113 bytes --]

Patch attached.
(I honestly don't know what has happened in these conversion paths
before my commit.)

- Andreas

[-- Attachment #2: 0001-swscale-swscale_unscaled-Actually-use-X2-RGBA64-conv.patch --]
[-- Type: text/x-patch, Size: 1455 bytes --]

From 6789133a2228af2d929eb4458e635323cf58243c Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Mon, 31 Mar 2025 17:01:51 +0200
Subject: [PATCH] swscale/swscale_unscaled: Actually use X2->RGBA64 conversions

The conversion functions were added in
e7382b4d0101f02e61fdf5ad2c48aca500bb413f, yet they were never
really enabled. Found via -ffunction-sections and --gc-sections.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libswscale/swscale_unscaled.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c
index 4959963b18..b84120549e 100644
--- a/libswscale/swscale_unscaled.c
+++ b/libswscale/swscale_unscaled.c
@@ -1901,7 +1901,8 @@ static rgbConvFn findRgbConvFn(SwsInternal *c)
         else if (CONV_IS(X2RGB10LE, BGR48BE)
               || CONV_IS(X2BGR10LE, RGB48BE)) conv = HAVE_BIGENDIAN ? x2rgb10tobgr48_nobswap
                                                                     : x2rgb10tobgr48_bswap;
-        else if (CONV_IS(X2RGB10LE, RGBA64LE)
+    } else if (isX2RGB(srcFormat) && isRGBA64(dstFormat)) {
+        if      (CONV_IS(X2RGB10LE, RGBA64LE)
               || CONV_IS(X2BGR10LE, BGRA64LE)) conv = HAVE_BIGENDIAN ? x2rgb10to64_bswap
                                                                      : x2rgb10to64_nobswap;
         else if (CONV_IS(X2RGB10LE, RGBA64BE)
-- 
2.45.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] swscale/swscale_unscaled: Actually use X2->RGBA64 conversions

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 321 bytes --]

On 3/31/2025 12:04 PM, Andreas Rheinhardt wrote:
> Patch attached.

LGTM.

> (I honestly don't know what has happened in these conversion paths
> before my commit.)

The unscaled path for X2RGB10 -> RGBA64 was never used, going through 
the standard conversion path of X2RGB10 -> YUV444P16 -> RGBA64 instead.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".