From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D410E46115 for ; Tue, 6 Jun 2023 13:35:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D610E68C1CC; Tue, 6 Jun 2023 16:35:36 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A453268C1AF for ; Tue, 6 Jun 2023 16:35:30 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 4A97D332F50 for ; Tue, 6 Jun 2023 15:35:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1686058529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=roNUYuL02ZLoSe12VWhl0KFFgVhQn749HLoz5TGfJbc=; b=NqqCo3wey4tu9F1FDyN/tFVF8d8PQmkOJ9RZFBtBCcB4b7rhXTlFwJe9J4zXLAMFw2eZIF VIf6XGqe5XYtvF7xepwtypY4y30/0pQ0wJfhgGhcT+MutVgSK3O3RF1HciddUG+02rAyXk 9+cMMBR7HBgv5O2VYd784kmd/ywc2VQ0Z3BPSm24RLqIHzdDISz/VYiAuLCeIh2bhay5GI gxO5pAXM78LfQ5scv/V/8GeFlG39HOks82vhqmPR0f0N+mcZIubXKL5/7ii3ZjMJRr+i4P BHvcpn2IVxilXpOmHZCILz7JcRJgXCvB1rOAP6fzIYStyHTWM951zIEMs9P7KQ== Message-ID: <4b2e5f71-f8b0-8abf-d3bc-daea4fbe3134@rothenpieler.org> Date: Tue, 6 Jun 2023 15:35:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: ffmpeg-devel@ffmpeg.org References: <168596036850.3843.16759199081478040168@lain.khirnov.net> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 05.06.2023 14:29, Roman Arzumanyan wrote: > Thanks for the review, Anton. Please find the updated patch attached. > BTW - what do you mean by "you should also forward the actual error code"? > Within the cuvid_handle_video_sequence() function in case of error, > function still returns 0 and sets internal context error, so I kept > behavior intact. Do I miss something? applied with minor amendments. Turned the if-statements around, we don't do them that way around in ffmpeg code. And switched the surfaces option to have a default of -1, to not rely on a magic value of 25. That could surprise users who happen to request 25 surfaces. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".