From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback
Date: Tue, 6 Jun 2023 15:35:26 +0200
Message-ID: <4b2e5f71-f8b0-8abf-d3bc-daea4fbe3134@rothenpieler.org> (raw)
In-Reply-To: <CAJZRZVkhtGWg26FUw_BUDO+y_30CVPasQhRhjJU=fr1LR8RwFA@mail.gmail.com>
On 05.06.2023 14:29, Roman Arzumanyan wrote:
> Thanks for the review, Anton. Please find the updated patch attached.
> BTW - what do you mean by "you should also forward the actual error code"?
> Within the cuvid_handle_video_sequence() function in case of error,
> function still returns 0 and sets internal context error, so I kept
> behavior intact. Do I miss something?
applied with minor amendments.
Turned the if-statements around, we don't do them that way around in
ffmpeg code.
And switched the surfaces option to have a default of -1, to not rely on
a magic value of 25. That could surprise users who happen to request 25
surfaces.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-06 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJZRZVnbFVOQaUuvA=F7qUmr+P_wfrjJnga2cq=tdNtm4Ky0sQ@mail.gmail.com>
2023-06-05 7:30 ` Roman Arzumanyan
2023-06-05 10:19 ` Anton Khirnov
2023-06-05 12:29 ` Roman Arzumanyan
2023-06-06 13:35 ` Timo Rothenpieler [this message]
2023-08-08 21:55 ` Michael Diesel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b2e5f71-f8b0-8abf-d3bc-daea4fbe3134@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git