[FFmpeg-devel] Re: [PATCH v3 5/5] doc/protocols: Add command-line description for ipv6 options

[Marton Balint via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

On Fri, 29 Aug 2025, Peter Enderborg via ffmpeg-devel wrote:

> Two new options added for receive IPv6 multicast streams.
> 1 multicast_max_joins
> 2 multicast_interface
>
> Change-Id: Ief0389815cff3edf26f7db5cbff033ce8bb24639
> Signed-off-by: Peter Enderborg <peterend@axis.com>
> ---
> doc/protocols.texi | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/doc/protocols.texi b/doc/protocols.texi
> index 6b582fde30..3def969dbe 100644
> --- a/doc/protocols.texi
> +++ b/doc/protocols.texi
> @@ -1207,7 +1207,15 @@ This is a deprecated option. Instead, @option{localrtpport} should be
> used.
>
> @item localaddr=@var{addr}
> -Local IP address of a network interface used for sending packets or joining
> +Local IP address of a network interface used for sending or receiving packets or joining
> +multicast groups.
> +
> +@item multicast_interface=@var{interfacename}
> +Local IP address of a network interface used for receiving packets or joining
> +multicast groups.

Why is this not simply "interface"? I would expect this option to be
interchangable with localaddr at least for ipv4, so the user can decide to 
specify the interface by its ip address or its name.

> +
> +@item multicast_max_join=@var{n}
> +Local IP address of a network interface used for receiving packets or joining
> multicast groups.

This seems like unintended copy paste. What is the actual use case for 
this option? How it is decided which additional interfaces are used for 
multicast? How does this option relates to the localaddr and interface 
options?

>
> @item timeout=@var{n}
> @@ -1229,6 +1237,13 @@ port will be used for the local RTP and RTCP ports.
> @item
> If @option{localrtcpport} (the local RTCP port) is not set it will be
> set to the local RTP port value plus 1.
> +
> +@item
> +On IPv6 the default receive behavior is using outgoing routing table for selection of
> +a interface for multicast streams. With @option{multicast_max_join} receiving
> +can be added for multiple interfaces. With @option{multicast_interface} a
> +interface is directly selected for receiving.
> +

I guess this paragraph belongs to the earlier part.

> @end enumerate

Please merge the documentation patch with corresponding feature patches.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org