Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding - Thilo Borgmann via ffmpeg-devel

From: Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Thilo Borgmann <thilo.borgmann@mail.de>
Subject: Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding
Date: Thu, 25 Jan 2024 16:39:19 +0100
Message-ID: <4ae8bd17-1589-4a7f-93fc-db7db53c33c5@mail.de> (raw)
In-Reply-To: <170617704310.8914.705271194770221831@lain.khirnov.net>

Am 25.01.24 um 11:04 schrieb Anton Khirnov:
> Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14)
>> ---
>>   libavcodec/webp.c | 50 +++++++++++++++++++++++++++++++++++++++++------
>>   1 file changed, 44 insertions(+), 6 deletions(-)
>>
>> diff --git a/libavcodec/webp.c b/libavcodec/webp.c
>> index 4fd107aa0c..58a20b73da 100644
>> --- a/libavcodec/webp.c
>> +++ b/libavcodec/webp.c
>> @@ -194,6 +194,7 @@ typedef struct WebPContext {
>>       AVFrame *alpha_frame;               /* AVFrame for alpha data decompressed from VP8L */
>>       AVPacket *pkt;                      /* AVPacket to be passed to the underlying VP8 decoder */
>>       AVCodecContext *avctx;              /* parent AVCodecContext */
>> +    AVCodecContext *avctx_vp8;          /* wrapper context for VP8 decoder */
> 
> Nested codec contexts are in general highly undesirable and should be
> avoided whenever possible.

AFAICT we do it that way in the other codecs as well (cri, ftr, imm5, tdsc, tiff). So what do you suggest to do to avoid having it nested?

-Thilo

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".