From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D4E83445A4 for ; Thu, 20 Oct 2022 01:42:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6070C68BDB1; Thu, 20 Oct 2022 04:42:51 +0300 (EEST) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB03768BDA3 for ; Thu, 20 Oct 2022 04:42:44 +0300 (EEST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-132fb4fd495so22855863fac.12 for ; Wed, 19 Oct 2022 18:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YsbxMgt+RTI2lDJjzCfKF+QR7SqprueGkwuI2Of9K4A=; b=ooCs69WUnd1ZTixWQtmrO7kQCA39K2q/oaFsKC4IWQlljNaI4DQUNntV0TGayUbtQ/ yR2sxTdzT1Wyvzej3g1kEiRT2ajPsMC7LmUFTlGhuulqnILTthMyw8OrCsAx8UmeiDRk Ot1y8OR8QXdWL2wGATDIDF7kz4SRcC/ZSppRMUJljCTUBWFASh++LijjtDpYoLf4xbTR plS/qTgnFB7X8G9TSnnPoFrAOAci35ST67xtOA3ReC6Le/gTrOTq+ezXjiOCDMAMhR1h 9QNFXDksfxnVgh/q3/zbCMa7gKWck+hBKmID6nzjFebAR1v0CEMvH91DNZ4fRXAxicB8 xbJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YsbxMgt+RTI2lDJjzCfKF+QR7SqprueGkwuI2Of9K4A=; b=xmNibsfn6KZHK/HKKAjdEhV6aaVBH0RqYuWJ61IIvP9xDShRM32S52GCvuyuTWU4kX NgWt339h+8lCt+5hzLxPU/fii9z7lsrgcb/r0U8KUTnfuFGAlctwK07vGsS5U4Uf8DT3 tdATgT1HdY4/IyW2doTJJrZ/fhAuEEwAzzTxF6eYLGYK08xMpHWBUj+NbL1NNn76iGcM zg8IrqAnjQ+sJlzaF4sxGQTgBOjDBna+wHCeBE6gzam0EnnDqSS5kY+ECEct+NcMMI/a YZYkAH1ZzbL5wF8OGBvk/xt6qIYHbgFd5IswjS+/68Aq2WkSFFnHWzk0LvBS7ggX5oaT 2QBA== X-Gm-Message-State: ACrzQf0JQUdi9hJRegtuzQsP52k+dd1ULRW+bpMJZ40ULp0Fidy7Dugz US60BKUVeKiQ51K7P8+cGF9/U9XB+9o= X-Google-Smtp-Source: AMsMyM72Q+ri+3KHk/zZKvbj//OC6VnOrabMWhffKASb8DQCmRHi86ODkjpTQbIeAgJlEHHsOOEgeA== X-Received: by 2002:a05:6870:9126:b0:132:b724:e96c with SMTP id o38-20020a056870912600b00132b724e96cmr23805761oae.199.1666230162244; Wed, 19 Oct 2022 18:42:42 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id t41-20020a05680815a900b0035476861b1dsm7303621oiw.49.2022.10.19.18.42.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 18:42:41 -0700 (PDT) Message-ID: <4adabb90-7d6a-eb6a-4457-3d62017d7cbf@gmail.com> Date: Wed, 19 Oct 2022 22:42:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <406d03fabf0bcf44fbfc894cf9960e3ad3947caf.1666229366.git.pross@xvid.org> <48a2b0b2ccefd79444b467e7d69527028ee5f3cb.1666229366.git.pross@xvid.org> From: James Almer In-Reply-To: <48a2b0b2ccefd79444b467e7d69527028ee5f3cb.1666229366.git.pross@xvid.org> Subject: Re: [FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/19/2022 10:30 PM, Peter Ross wrote: > This will enable the acurate identification of FFmpeg produced > SVQ1 streams, should there be new bugs found in the encoder. > --- > libavcodec/svq1enc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c > index 9bd5a04368..6aacaef88d 100644 > --- a/libavcodec/svq1enc.c > +++ b/libavcodec/svq1enc.c > @@ -41,6 +41,7 @@ > #include "svq1.h" > #include "svq1encdsp.h" > #include "svq1enc_cb.h" > +#include "version.h" > > #include "libavutil/avassert.h" > #include "libavutil/frame.h" > @@ -628,6 +629,14 @@ static av_cold int svq1_encode_init(AVCodecContext *avctx) > > ff_h263_encode_init(&s->m); // mv_penalty > > + if (!(s->avctx->flags & AV_CODEC_FLAG_BITEXACT)) { > + avctx->extradata = av_malloc(sizeof(LIBAVCODEC_IDENT)); > + if (!avctx->extradata) > + return AVERROR(ENOMEM); > + memcpy(avctx->extradata, LIBAVCODEC_IDENT, sizeof(LIBAVCODEC_IDENT)); > + avctx->extradata_size = sizeof(LIBAVCODEC_IDENT); Can you explain what effect is this meant to have and where? Do or should muxers like mp4 and matroska expect extradata from svq1 streams that they are meant to write to the output file? > + } > + > return 0; > } > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".