From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 77C8A456A9
	for <ffmpegdev@gitmailbox.com>; Fri, 17 Feb 2023 22:42:58 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8C41B68BE58;
	Sat, 18 Feb 2023 00:42:55 +0200 (EET)
Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com
 [209.85.210.47])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2714068BE11
 for <ffmpeg-devel@ffmpeg.org>; Sat, 18 Feb 2023 00:42:49 +0200 (EET)
Received: by mail-ot1-f47.google.com with SMTP id
 g3-20020a9d6a03000000b0068d4a8a8d2dso491693otn.12
 for <ffmpeg-devel@ffmpeg.org>; Fri, 17 Feb 2023 14:42:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=yVZ38FMkNGCObihLjGJGNoc6uKC8ReHCPAnK6qX3dWY=;
 b=F53v0r3Cex/UGYKWw1CFkNSaf7DewElQp8ykUzNLb/w9824PjOROpM6SSEYpB4WnQw
 cPl1Z5ZI9OwKDZ18SNHKGpBgoC1Jzlb3ucIfWMslNBTKKDvmD1dr3U/7s2xZQ0FrUKLf
 4mf5KUmkyguLUA/MpzXQvy2DVEMKpJfnwnNE2v2zhSng8YpIRudHAmHfEzrHv6tebOar
 6eQUMv2o9FFK73SPAcU/j2dm9E0eurgNH8fF3uws2S7MjbM8v4/uAe4IWKMTIBAauOXr
 FHoyE3RXn6X2siBv4rbIKMcdefFFmjViUdeiz60XdYaiG5Pwd4DXktG5brSSL72LNpy+
 dPqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=yVZ38FMkNGCObihLjGJGNoc6uKC8ReHCPAnK6qX3dWY=;
 b=D0YtfFC6b/kIUGTWrbWBbJKMdNEvS2ZbaXgCadwGr37VxlKVesVKc3KFOY+KgCKOtF
 oI4xpREpmrLm+IaIokwo29YmAfbegJrd5WNo8nNu9e8ePXVwF0GVDKh3L4DoCViSL/SC
 CcZijBzfD649mnAfufVHg13x8cpFQUyq1c9oxS62Ii/HBjKyqqFVPtE/yZlJae7HlVq5
 EX5+NHnM+cnWqCOmg+BLMnyiJ5HXnnnmgwGVgoH+2uPSrhyGCpYCu9Z3yP3UVnhzkPb1
 yEtwo5jnB7x08WZ3mk+K5n1wq9tp03tuxA2oGhcnFO4cKklmHsAlZ5ti62yHkw7e0d4/
 DIIQ==
X-Gm-Message-State: AO0yUKV5WMEzonW3ZvkrpXD0rQrsbYHJ8QY3VQs1aJ1E3iD3UZjcF9wY
 FhJUD1CrPY7P3oaRCpzlCV8entSEWsQ=
X-Google-Smtp-Source: AK7set8w57MoUsGEq5SUOilWWncNroN6DZYCdhqBbCJqATyH0wVRY+2S6p0i0MKSwTIdKOhhzn887g==
X-Received: by 2002:a05:6830:923:b0:690:ece7:62d5 with SMTP id
 v35-20020a056830092300b00690ece762d5mr2438697ott.28.1676673767391; 
 Fri, 17 Feb 2023 14:42:47 -0800 (PST)
Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar.
 [190.225.105.197]) by smtp.gmail.com with ESMTPSA id
 o20-20020a9d7194000000b00690eeb8b436sm1038314otj.65.2023.02.17.14.42.46
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 17 Feb 2023 14:42:47 -0800 (PST)
Message-ID: <4ad2565c-e1d6-39f2-2a9f-8e0bb6ed310c@gmail.com>
Date: Fri, 17 Feb 2023 19:43:07 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <306450> <20230217194634.4154710-1-marth64@proxyid.net>
From: James Almer <jamrial@gmail.com>
In-Reply-To: <20230217194634.4154710-1-marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of
 spatial audio extensions
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/4ad2565c-e1d6-39f2-2a9f-8e0bb6ed310c@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 2/17/2023 4:46 PM, Marth64 wrote:
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> Update doc/APIchanges and update libavcodec minor version
> 
>   doc/APIchanges             |  4 ++++
>   libavcodec/ac3dec.c        |  4 ++++
>   libavcodec/ac3dec.h        |  1 +
>   libavcodec/avcodec.h       | 18 ++++++++++++------
>   libavcodec/codec_desc.c    |  2 ++
>   libavcodec/dca_syncwords.h |  3 +++
>   libavcodec/dca_xll.c       | 27 ++++++++++++++++++++++++++-
>   libavcodec/dca_xll.h       |  3 +++
>   libavcodec/eac3dec.c       | 11 ++++++++++-
>   libavcodec/mlpdec.c        | 15 +++++++++++++--
>   libavcodec/profiles.c      | 24 ++++++++++++++++++------
>   libavcodec/profiles.h      |  2 ++
>   libavcodec/version.h       |  2 +-
>   13 files changed, 99 insertions(+), 17 deletions(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 6baf914760..04dda4132e 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -14,6 +14,10 @@ libavutil:     2021-04-27
>   
>   API changes, most recent first:
>   
> +2023-0x-xx - xxxxxxxxxx - lavc 59.64.100
> +  Add DCA_SYNCWORD_XLL_X and DCA_SYNCWORD_XLL_X_IMAX syncword constants
> +  as part of facilitating DTS:X and DTS:X IMAX detection.

This should mention the new API that's exposed in public headers. In 
this case it's the new FF_PROFILE_* defines.

Also, could you split this in three patches? One for DTS, one for EAC3 
and one for TrueHD? The order is not important, and the version bump and 
the APIChanges entry would then be added in the last patch.
Also, remove the mention about ffprobe since you're not touching it at 
all. The new profiles will be reported by any tool that prints them, 
like ffmpeg, not just ffprobe.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".