From: "Martin Storsjö" <martin@martin.st>
To: "Swinney, Jonathan" <jswinney@amazon.com>
Cc: "J. Dekker" <jdek@itanimul.li>,
"Pop, Sebastian" <spop@amazon.com>,
"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] checkasm: updated tests for sw_scale
Date: Tue, 21 Jun 2022 23:16:41 +0300 (EEST)
Message-ID: <4a2e77c6-1ce4-74b6-583a-e671f1efc1aa@martin.st> (raw)
In-Reply-To: <005de8b06dea40c4a60fdad9a084138f@EX13D07UWB004.ant.amazon.com>
On Mon, 13 Jun 2022, Swinney, Jonathan wrote:
> - added a test for yuv2plane1 (currently disabled for x86_64)
What's the reason for having it disabled for x86 - is it another case
where the current implementations there aren't bitexact? Could we avoid
that by setting the bitexact flag for the new yuv2yuv1 test?
> - fixed test for yuv2planeX for aarch64 which was previously not working
> at all
Could we make the test fuzzy and allow minor differences from the
reference, when the bitexact flag isn't set, and separately test with the
bitexact flag and require exact matches?
> @@ -95,7 +210,7 @@ static void check_yuv2yuvX(void)
> ff_sws_init_scale(ctx);
> for(isi = 0; isi < INPUT_SIZES; ++isi){
> dstW = input_sizes[isi];
> - for(osi = 0; osi < 64; osi += 16){
> + for(osi = 0; osi < 1; osi += 16){
This looks like a stray leftover change?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-21 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 16:36 Swinney, Jonathan
2022-06-21 20:16 ` Martin Storsjö [this message]
2022-06-22 9:22 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2e77c6-1ce4-74b6-583a-e671f1efc1aa@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=jdek@itanimul.li \
--cc=jswinney@amazon.com \
--cc=spop@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git