Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

[Richard Kern <kernrj@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]



> On May 1, 2022, at 1:31 PM, Simone Karin Lehmann <simone@lisanet.de> wrote:
> 
> Hi,
> 
> may I kindly ask you to check, if this patch could now be applied? 
I’ll look at it today. 

> 
> Regards
> Simone
> 
> Von meinem iPad gesendet
> 
>> Am 25.04.2022 um 22:33 schrieb Simone Karin Lehmann <simone@lisanet.de>:
>> 
>> 
>> 
>>>>> Am 25.04.2022 um 21:14 schrieb Rick Kern <kernrj@gmail.com>:
>>>>> 
>>>>> 
>>>>>  { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc),
>>>>> AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, VE },
>>>>> +    { "prio_speed", "prioritize encoding speed", OFFSET(prio_speed),
>>>>> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE },
>>>>> 
>>> It might be simpler to make the default value of prio_speed -1, and set
>>> this property on the encoder session only when it's non-negative. Then we
>>> won't need to worry about the default value changing for different codecs
>>> or different OS versions. It could also be moved into COMMON_OPTIONS in
>>> this case.
>> 
>> oh yes, that’s way better. I didn’t think of that in the first place. Thanks for the hint.
>> 
>> Here’s the modified patch
>> 
>> Simone
>> 

[-- Attachment #2: 0001-add-options-to-h264-hevc-and-prores-encoders-to-prio.patch --]
[-- Type: application/octet-stream, Size: 3289 bytes --]

[-- Attachment #3: Type: text/plain, Size: 541 bytes --]

>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[-- Attachment #4: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".