From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE0D742488 for ; Fri, 22 Apr 2022 04:18:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F3A2468B2B6; Fri, 22 Apr 2022 07:17:59 +0300 (EEST) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 448AC68AEFA for ; Fri, 22 Apr 2022 07:17:53 +0300 (EEST) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Kl1NJ3Y18z9sSM for ; Fri, 22 Apr 2022 06:17:52 +0200 (CEST) Message-ID: <49b6da7c-854c-19ce-46cf-caefa96c70f2@gyani.pro> Date: Fri, 22 Apr 2022 09:47:35 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220419205704.3548965-1-vigneshv@google.com> <62f20540-ad9f-cda3-20ff-9c4952e220a4@gyani.pro> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-04-21 09:46 pm, Vignesh Venkatasubramanian wrote: > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: >> >> >> On 2022-04-20 09:54 am, Gyan Doshi wrote: >>> >>> On 2022-04-20 02:49 am, Paul B Mahol wrote: >>>> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < >>>> vigneshv-at-google.com@ffmpeg.org> wrote: >>>> >>>>> Add support for parsing AVIF still images. This patches supports >>>>> AVIF still images that have exactly 1 item (i.e.) no alpha channel. >>>>> Essentially, we will have to parse the "iloc" box and populate >>>>> the mov index. >>>>> >>>>> With this patch, we can decode still AVIF images like so: >>>>> ffmpeg -i image.avif image.png >>>>> >>>>> Partially fixes trac ticket #7621 >>>>> >>>> LGTM >>> Will push tomorrow if no one else has. >> Can you provide a sample AVIF image and command that this patch allows >> decoding of? >> >> I tried a couple of samples from Netflix[1] and MS[2] and none worked, >> even with forcing MOV demuxer ("moov atom not found" or "error reading >> header"). > Thanks for verifying. The test files you tried are invalid/not > supported by this patch. Please see the explanation below. > >> [1]: http://download.opencontent.netflix.com/?prefix=AV1/Chimera/AVIF/ > These files are not valid AVIF since they don't have the major brand > set to "mif1" and not "avif". They are also missing a few other > mandatory boxes. libavif (the reference AVIF library) also is not able > to parse these files. These files were likely made when the AVIF > specification was not yet finalized. > > $ ./avifdec --info Chimera-AV1-8bit-1280x720-3363kbps-100.avif > ERROR: Failed to decode image: BMFF parsing failed > Diagnostics: > * [Strict] Item ID 1 of type 'av01' is missing mandatory pixi property > >> [2]: >> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft >> > These files have EXIF metadata and will contain more than one item > entry in the iloc box. This patch does not support that (however, i > have a follow-up patch to fix this). The files in this directory > return AVERROR_PATCHWELCOME as intended. > > For a set of working AVIF files that are supported by this patch you > can try the files under "Link-U" and "Netflix" subdirectories of this repo: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Link-U > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Netflix/avif Ok, these work. > The command is as mentioned in the commit message: > ./ffmpeg -i output.png > > Please let me know if you have more questions. Thank you! Add informative log msgs in the patchwelcome blocks. Are there plans to add support for transforms like cropping, rotation? Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".