From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2CA6043C9F for ; Tue, 4 Oct 2022 00:04:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AA5F68BB9A; Tue, 4 Oct 2022 03:03:57 +0300 (EEST) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA63768BB87 for ; Tue, 4 Oct 2022 03:03:50 +0300 (EEST) Received: by mail-vs1-f48.google.com with SMTP id n186so7236763vsc.9 for ; Mon, 03 Oct 2022 17:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date; bh=6uK4kimH+vLJAHgtNAdF5pLv3528PVkXz5ljXHIu3Sw=; b=GO0wa5XtAi24feJhE3cOTZ1MC/0nxIAg2YpQXxiGIShzm5QlBALSYZrr9aNMmhm/vj ncZAYO0RF9Ya/VTdgMDsYb3LHUcmXsznzQLB4W64LrgP1Rte4QaYYx93EizWigcL2Oz3 KYEMqsdXUAyVQYVqUEHLRUYJyMeAlCV/GrtMUYLB9wEisCXycrVsZNNNy2hZjKSreZpi zNG8lo+ZrrBZwhQE6jw7MUHAbmvOLAYqSKKbx1Odyd/wxPMNtTl7Dzum2HMHKRo7KoSJ JYtg8HQTwbaWyekPFfKo1UPgVAbf0/GvRrLkaSmFYpCOQ5Ec6UpgcRFxw0gVtpliwK01 hxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6uK4kimH+vLJAHgtNAdF5pLv3528PVkXz5ljXHIu3Sw=; b=IDuDQaGNNKh1OPls2MAxZ0mEetFe0/8dvA34f6TG3EbXYmv0q47FVj+wyswCQr9+eq T8fLJb3/CY3PLVXNKdUANvb+nN2tmZ1LOEjeflOKp1ctL+HWClfPJW8zm/ND5mbW7klm 9KYCDjopQJmjvNG0EecqpSB+F11FRca/FMmvzlnQTfKAH422ifBzNbwq5Le9Sb7cZNwA zkIsotd82uPAYXPMh6nftVmcjTXFRHhl2PmbqBe6pKUCpKYWFFQlRnz0ws2JfJ1PYehH pNKNAWH5rDKGJSKLSOmXkPmwDOlX5BHaIrz+8dcRC4WdrqzhHX9/0LitQYtwa/iQYZnQ RQDw== X-Gm-Message-State: ACrzQf3xWslRwoZCOZ81eKDoW99ocynGk2yJL73SVw0qveZltjdqs7Oc 2VmwJnWHLSHni0BPeaAxj5RpE2xVgIQ= X-Google-Smtp-Source: AMsMyM4Zz7K5ni57y0TGlSBVaRgiAkiT2zWGajxHCjg0DHWGz6ss7ELQWVpamFuj9m+A90uRgdGrcA== X-Received: by 2002:a67:d81e:0:b0:398:2c98:229b with SMTP id e30-20020a67d81e000000b003982c98229bmr9764204vsj.73.1664841828553; Mon, 03 Oct 2022 17:03:48 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id t18-20020a1faa12000000b003a2354653e3sm7617043vke.5.2022.10.03.17.03.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 17:03:47 -0700 (PDT) Message-ID: <494f8554-76a6-1bf0-42c4-b63f29bdf95c@gmail.com> Date: Mon, 3 Oct 2022 21:03:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/sunrast: Use ptrdiff_t for stride X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/30/2022 2:02 PM, Andreas Rheinhardt wrote: > Fixes segfaults with negative linesizes; in particular, > this affected the sunraster-(1|8|24)bit-(raw|rle) and > sunraster-8bit_gray-raw FATE tests. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sunrast.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/sunrast.c b/libavcodec/sunrast.c > index 77feef06e1..45b29e4d72 100644 > --- a/libavcodec/sunrast.c > +++ b/libavcodec/sunrast.c > @@ -31,7 +31,8 @@ static int sunrast_decode_frame(AVCodecContext *avctx, AVFrame *p, > { > const uint8_t *buf = avpkt->data; > const uint8_t *buf_end = avpkt->data + avpkt->size; > - unsigned int w, h, depth, type, maptype, maplength, stride, x, y, len, alen; > + unsigned int w, h, depth, type, maptype, maplength, x, y, len, alen; > + ptrdiff_t stride; > uint8_t *ptr, *ptr2 = NULL; > const uint8_t *bufstart = buf; > int ret; > @@ -141,7 +142,7 @@ static int sunrast_decode_frame(AVCodecContext *avctx, AVFrame *p, > > if (type == RT_BYTE_ENCODED) { > int value, run; > - uint8_t *end = ptr + h * stride; > + uint8_t *end = ptr + (ptrdiff_t)h * stride; Is the cast needed if stride is already ptrdiff_t? > > x = 0; > while (ptr != end && buf < buf_end) { _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".