From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2067944E4A for ; Sat, 26 Nov 2022 01:00:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F37168B347; Sat, 26 Nov 2022 03:00:07 +0200 (EET) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C84A16807F9 for ; Sat, 26 Nov 2022 03:00:00 +0200 (EET) Received: by mail-oi1-f182.google.com with SMTP id v82so6014888oib.4 for ; Fri, 25 Nov 2022 17:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TpibW+zPm0GQX61jySOvXKeHj6wBN+Hd17WYtOEntuQ=; b=N7gs9PhOKlnDUrx20gftKikB+kwh+cbkIsGXakwaRoR/8yYbdNTAAAuY/qNc+tcz93 ye5zlm3abPq8tWEUxWDAGgCEKCvAWspsMxfofpcndNokFT4N6bo0AQDTuLI4v04oprIC joLb3G38iyrshGH/IB9gRP4lbugoV9ln8p0rOkxH/KlcWm58NHWs5WaNkpze0NW/axwr otkgAOrRM68IX6QnJcSU/f3dmiegwINGA+miJUMNmLxdlZMe/yY7MYyWMNz7iyEQ4k4r R+iKhdFZFNS01Q0lN8BJPLoVm3lO+4RHFH7SG1xr4qIlXqgywZ6hbBstl3+0SJVwSr7b djxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TpibW+zPm0GQX61jySOvXKeHj6wBN+Hd17WYtOEntuQ=; b=7OdP4tAxq/K8PrYxwlSflV1zhSiJ6Qo7yY8qZmLFJ3RG3e1ZOo6PTH0b0Ri52lEEz3 caZxNM4uHaxNyNOZN6FzbR9hyszjQS5XrFU/6Zgj55bxnRff+TkV3Vn42Grf+ZOXxp8Z MPjOmaOKe2DYbHznK5jc/cjUHx8BojU8Ohd7BtKeRSMadGOZMl8u5BySk506pJwywSpd nQfpHe6xibOl6gSqRTeDbm9oMFcdrRE4lDsFJoqg0zR8Zr3o5H8fXdssSCMAh9/VsOOA oLS3qzTb7byJrJd4qRI1Etiu+YMx/al+7GfXouZR62w7473eTQ1AiFmcv+cer2SQIHWL MS4A== X-Gm-Message-State: ANoB5pkYY1v/yflitTIoJrkshUhhtISM8RBm773k+panHrEoB0qYhiyR 5DJjxpKqz1uWCC47p/RUKVsGFY1JrE8= X-Google-Smtp-Source: AA0mqf41JCEpbZMOCkif1OgusCN9VSOOdrfxqMfRV3vU6fILXYORKgLSGuaDWc2aVx8JE2i1RTmprw== X-Received: by 2002:aca:5dc4:0:b0:35a:6b1a:531 with SMTP id r187-20020aca5dc4000000b0035a6b1a0531mr19560387oib.153.1669424398819; Fri, 25 Nov 2022 16:59:58 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id 64-20020a9d0346000000b0066c39c99ae5sm2278223otv.25.2022.11.25.16.59.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 16:59:58 -0800 (PST) Message-ID: <494bbc9b-ab82-0c62-f471-3ac9be03e80a@gmail.com> Date: Fri, 25 Nov 2022 22:00:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221124052209.520239-1-haihao.xiang@intel.com> <166938393779.4503.7930861168279237996@lain.khirnov.net> <12d8e532-f236-83b8-61cf-6c9ee72b10ee@gmail.com> <4bcec8d4-8593-9a23-3130-8aa52b1f3c11@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/25/2022 9:58 PM, Soft Works wrote: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Saturday, November 26, 2022 12:58 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support >> P010 format >> >> On 11/25/2022 8:51 PM, Soft Works wrote: >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel On Behalf Of >>>> James Almer >>>> Sent: Saturday, November 26, 2022 12:35 AM >>>> To: ffmpeg-devel@ffmpeg.org >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't >> support >>>> P010 format >>>> >>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: >>>>> [AMD Official Use Only - General] >>>>> >>>>> Will it make sense to accept P010 input, however encode to h264 >>>> 8bit? >>>> >>>> If it works (the encoder accepts the 10 bit input even if it >> encodes >>>> it >>>> as 8bit), then i don't see why not. I assume it would also be >> faster >>>> than using swscale to convert said 10bit input to nv12 before >> passing >>>> that to the encoder. >>>> >>>> Removing support for a pixel format as input in an encoder needs a >>>> reason other than "It's rarely used", more so when it's a single >>>> line. >>>> It either needs to not work, or somehow get in the way of further >>>> improvements. >>> >>> Oh sorry, I noticed that there was a misunderstanding. >>> >>> When I said "It's rarely used", I didn't mean that as a >> justification >>> for the removal, it was meant as an explanation why none of the >>> hwaccels has implemented it. >>> >>> softworkz >> >> Alright, then i'll repeat my question: Does it work? > > No. What does this encoder currently do when you feed it p010 input? What does it output? > >> If it does >> not, >> then that should have been mentioned in the patch as the reason why >> this >> is being done. > > For me it was clear, albeit a bit short. Anyway, I'll let Haihao, respond. > > Best, > softworkz > > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".