On 2/5/2025 11:47 AM, Lynne wrote:
> Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5
> 
> The issue is that while avctx->pix_fmt is synchronized between
> threads, f->pix_fmt was not.
> 
> Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2.

Can confirm "make fate-vsynth{1,2,3,_lena} THREADS=2" (as well as higher 
thread count) passes with this patch.

> ---
>   libavcodec/ffv1dec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c
> index fcf3d525ac..0284845503 100644
> --- a/libavcodec/ffv1dec.c
> +++ b/libavcodec/ffv1dec.c
> @@ -1114,6 +1114,7 @@ static int update_thread_context(AVCodecContext *dst, const AVCodecContext *src)
>       fdst->plane_count         = fsrc->plane_count;
>       fdst->ac                  = fsrc->ac;
>       fdst->colorspace          = fsrc->colorspace;
> +    fdst->pix_fmt             = fsrc->pix_fmt;
>   
>       fdst->ec                  = fsrc->ec;
>       fdst->intra               = fsrc->intra;