From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CAF8549157 for ; Tue, 5 Mar 2024 14:49:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4746468CFCC; Tue, 5 Mar 2024 16:49:35 +0200 (EET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 647E768CDFB for ; Tue, 5 Mar 2024 16:49:29 +0200 (EET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dc5d0162bcso49684515ad.0 for ; Tue, 05 Mar 2024 06:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709650167; x=1710254967; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WdAcngyCG/OCoTqUA6fHbfUQq1HFQFwm8szkWyl1LJQ=; b=PVTlEpBV2JIK9oaE1D3WBgaSHbaUT7v3omg8BDmRQ4xOoIg8pdSWgW/q1WLV9zt6y+ Qw+lQ1v+oSzFZgdlX/yVpbQ+Hes5B4rqUzKh3oXRFvQWqbPBjtDnFFNr3pRSWQspiouD INA5YqY8X7hbQdsKRp6TKCPOfWiu693jVf+V2I7F0b6U5KPYzO5lUDduJuV2NRUGr3C3 Nn/dHlS90bTZjAr3TTNYTSWC7aAC+Vf3gSe7WNEr/I2q72HHD5nkDMUZlGmko5ws/N4s dXuROlvvtW5hn7XFIbfTqps2qZPonQ1VjoBGVAF9fbySnAQIzIjFL020yET1XXrxj7h8 05yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709650167; x=1710254967; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WdAcngyCG/OCoTqUA6fHbfUQq1HFQFwm8szkWyl1LJQ=; b=rsXOrFbPWD5BY3zbp7MD2j1qL9UcX/zPtOJM+Tbn+HnUxkMvrtlMkXH0vSBJtUoOk3 bX/ZXgAWsL7ptDIS0U8kViTkqXx8JHZcVNUP8SCOWlc8XQX42kC98iCx7Z73lF8hjgU5 PXgLFUEcXqast3nORHYcJQnJJpfOGcVvUMswviT/wbvt1/117ZskI1SrCkTqIN07mAnf 0abvnbqXPFkOan9MrfSiyJqx5s4WnmhHgC40TqeSPp/wVM1RYe8nq8HAhbf3cAspN9Cc r2CvE8fD8VaoZJtLQrz58yhSgNrycZO7OWa84Q0SKusDfUPtyEPOKuziCyCes9cAYM9E IhRA== X-Gm-Message-State: AOJu0YwOrEsFDc9qmuuXJB54OzDGibtz5oQncmUzLVegkhkOUK57mR4t PVtENukdzaFH58xN5reGAhzV5bPjPtrT9yIruqDyjjt6mEsTNfep9QCxD7Gj X-Google-Smtp-Source: AGHT+IFxbQRBAnYui9WletNqSF8OoKcGRhEGSyViKzWqdQehWNf/VvPeusqP1n//jobuwfxB9KZXZw== X-Received: by 2002:a17:902:d4d1:b0:1d9:a647:5579 with SMTP id o17-20020a170902d4d100b001d9a6475579mr2220978plg.1.1709650166699; Tue, 05 Mar 2024 06:49:26 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id im15-20020a170902bb0f00b001db5c8202a4sm10799701plb.59.2024.03.05.06.49.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Mar 2024 06:49:26 -0800 (PST) Message-ID: <48f25054-c5ce-4d3f-91c8-d89fbff70c35@gmail.com> Date: Tue, 5 Mar 2024 11:49:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240304185646.9755-1-jamrial@gmail.com> <96729593-7417-46f8-8b3c-f7ea646bb5b2@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/5/2024 11:43 AM, Stefano Sabatini wrote: > On date Tuesday 2024-03-05 11:38:20 -0300, James Almer wrote: >> On 3/5/2024 11:34 AM, Stefano Sabatini wrote: >>> On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: >>>> Components and pieces are side data specific fields and there's a variable >>>> amount of them. >>>> They also need to be identified in some form, so print a type too. >>>> >>>> Signed-off-by: James Almer >>>> --- >>>> You can see the difference with >>>> >>>> ffprobe -show_frames -of compact $fate_samples/mov/dovi-p7.mp4 >>>> ffprobe -show_frames -of xml $fate_samples/mov/dovi-p7.mp4 >>>> >>>> fftools/ffprobe.c | 33 +++++++++++++++++++++++++++------ >>>> 1 file changed, 27 insertions(+), 6 deletions(-) >>>> > [...] >>> LGTM. Not clear if this is fixing a regression or if the format (at >>> least for XML/compact) was always wrong. >> > >> I'm on the fence on this. Try removing the SECTION_FLAG_HAS_TYPE from >> SECTION_ID_FRAME_SIDE_DATA_COMPONENT and SECTION_ID_FRAME_SIDE_DATA_PIECE >> and the output is broken again for the compact output. So at least >> compact_print_section_header() may be faulty. I did not investigate much >> because I'm not familiar with the code. > > That is, if you define the type (as in the current implementation) it > looks correct? Yes. Without the type, the unexpected line breaks return. So the path in compact_print_section_header() taken when SECTION_FLAG_HAS_TYPE is not set may be wrong. > >> In any case, this change is needed because of the >> SECTION_FLAG_HAS_VARIABLE_FIELDS addition for side data where the printed >> fields are not a fixed amount. > > Agree. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".