Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var
@ 2024-04-17 11:31 Gyan Doshi
  2024-04-17 11:55 ` James Almer
  0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2024-04-17 11:31 UTC (permalink / raw)
  To: ffmpeg-devel

sum_delta_pts is unused since 3b358f151d
---
 libavformat/ivfenc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c
index 09782eecd6..9feaea3516 100644
--- a/libavformat/ivfenc.c
+++ b/libavformat/ivfenc.c
@@ -24,7 +24,7 @@
 
 typedef struct IVFEncContext {
     unsigned frame_cnt;
-    uint64_t last_pts, sum_delta_pts, last_pkt_duration;
+    uint64_t last_pts, last_pkt_duration;
 } IVFEncContext;
 
 static int ivf_init(AVFormatContext *s)
@@ -80,8 +80,6 @@ static int ivf_write_packet(AVFormatContext *s, AVPacket *pkt)
     avio_wl32(pb, pkt->size);
     avio_wl64(pb, pkt->pts);
     avio_write(pb, pkt->data, pkt->size);
-    if (ctx->frame_cnt)
-        ctx->sum_delta_pts += pkt->pts - ctx->last_pts;
     ctx->last_pkt_duration = pkt->duration;
     ctx->frame_cnt++;
     ctx->last_pts = pkt->pts;
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var
  2024-04-17 11:31 [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var Gyan Doshi
@ 2024-04-17 11:55 ` James Almer
  2024-04-17 13:02   ` Gyan Doshi
  0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2024-04-17 11:55 UTC (permalink / raw)
  To: ffmpeg-devel

On 4/17/2024 8:31 AM, Gyan Doshi wrote:
> sum_delta_pts is unused since 3b358f151d
> ---
>   libavformat/ivfenc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c
> index 09782eecd6..9feaea3516 100644
> --- a/libavformat/ivfenc.c
> +++ b/libavformat/ivfenc.c
> @@ -24,7 +24,7 @@
>   
>   typedef struct IVFEncContext {
>       unsigned frame_cnt;
> -    uint64_t last_pts, sum_delta_pts, last_pkt_duration;
> +    uint64_t last_pts, last_pkt_duration;
>   } IVFEncContext;
>   
>   static int ivf_init(AVFormatContext *s)
> @@ -80,8 +80,6 @@ static int ivf_write_packet(AVFormatContext *s, AVPacket *pkt)
>       avio_wl32(pb, pkt->size);
>       avio_wl64(pb, pkt->pts);
>       avio_write(pb, pkt->data, pkt->size);
> -    if (ctx->frame_cnt)
> -        ctx->sum_delta_pts += pkt->pts - ctx->last_pts;
>       ctx->last_pkt_duration = pkt->duration;
>       ctx->frame_cnt++;
>       ctx->last_pts = pkt->pts;

Ok.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var
  2024-04-17 11:55 ` James Almer
@ 2024-04-17 13:02   ` Gyan Doshi
  0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2024-04-17 13:02 UTC (permalink / raw)
  To: ffmpeg-devel



On 2024-04-17 05:25 pm, James Almer wrote:
> On 4/17/2024 8:31 AM, Gyan Doshi wrote:
>> sum_delta_pts is unused since 3b358f151d
>> ---
>>   libavformat/ivfenc.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c
>> index 09782eecd6..9feaea3516 100644
>> --- a/libavformat/ivfenc.c
>> +++ b/libavformat/ivfenc.c
>> @@ -24,7 +24,7 @@
>>     typedef struct IVFEncContext {
>>       unsigned frame_cnt;
>> -    uint64_t last_pts, sum_delta_pts, last_pkt_duration;
>> +    uint64_t last_pts, last_pkt_duration;
>>   } IVFEncContext;
>>     static int ivf_init(AVFormatContext *s)
>> @@ -80,8 +80,6 @@ static int ivf_write_packet(AVFormatContext *s, 
>> AVPacket *pkt)
>>       avio_wl32(pb, pkt->size);
>>       avio_wl64(pb, pkt->pts);
>>       avio_write(pb, pkt->data, pkt->size);
>> -    if (ctx->frame_cnt)
>> -        ctx->sum_delta_pts += pkt->pts - ctx->last_pts;
>>       ctx->last_pkt_duration = pkt->duration;
>>       ctx->frame_cnt++;
>>       ctx->last_pts = pkt->pts;
>
> Ok.

Thanks. Pushed as 38c322681e9715b288172eaed1e90205aa46e969

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-17 13:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 11:31 [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var Gyan Doshi
2024-04-17 11:55 ` James Almer
2024-04-17 13:02   ` Gyan Doshi

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git